[dpdk-test-report] |WARNING| pw20742 [PATCH 08/16] net/avp: device initialization

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/20742

_coding style issues_


CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#72: FILE: drivers/net/avp/avp_ethdev.c:109:
+#define RTE_AVP_F_PROMISC (1<<1)
                             ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#73: FILE: drivers/net/avp/avp_ethdev.c:110:
+#define RTE_AVP_F_CONFIGURED (1<<2)
                                ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#74: FILE: drivers/net/avp/avp_ethdev.c:111:
+#define RTE_AVP_F_LINKUP (1<<3)
                            ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#75: FILE: drivers/net/avp/avp_ethdev.c:112:
+#define RTE_AVP_F_DETACHED (1<<4)
                              ^

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#128: FILE: drivers/net/avp/avp_ethdev.c:205:
+	unsigned retry = RTE_AVP_MAX_REQUEST_RETRY;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#130: FILE: drivers/net/avp/avp_ethdev.c:207:
+	unsigned count;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#248: FILE: drivers/net/avp/avp_ethdev.c:325:
+	unsigned i;

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#266: FILE: drivers/net/avp/avp_ethdev.c:343:
+				    "Translating host physical 0x%"PRIx64" "

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#266: FILE: drivers/net/avp/avp_ethdev.c:343:
+				    "Translating host physical 0x%"PRIx64" "

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#288: FILE: drivers/net/avp/avp_ethdev.c:365:
+		 * own */

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#303: FILE: drivers/net/avp/avp_ethdev.c:380:
+	unsigned i;

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#312: FILE: drivers/net/avp/avp_ethdev.c:389:
+			    "resource[%u]: phys=0x%"PRIx64" "

CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#313: FILE: drivers/net/avp/avp_ethdev.c:390:
+			    "len=%"PRIu64" addr=%p
",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#313: FILE: drivers/net/avp/avp_ethdev.c:390:
+			    "len=%"PRIu64" addr=%p
",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#370: FILE: drivers/net/avp/avp_ethdev.c:447:
+	PMD_DRV_LOG(NOTICE, "Detaching port %u from AVP device 0x%"PRIx64"
",

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#479: FILE: drivers/net/avp/avp_ethdev.c:556:
+	unsigned i;

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#482: FILE: drivers/net/avp/avp_ethdev.c:559:
+	PMD_DRV_LOG(NOTICE, "Attaching port %u to AVP device 0x%"PRIx64"
",

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around pci_dev->intr_handle
#630: FILE: drivers/net/avp/avp_ethdev.c:707:
+	ret = rte_intr_enable(&(pci_dev->intr_handle));

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around pci_dev->intr_handle
#651: FILE: drivers/net/avp/avp_ethdev.c:728:
+	ret = rte_intr_callback_register(&(pci_dev->intr_handle),

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#699: FILE: drivers/net/avp/avp_ethdev.c:776:
+	unsigned i;

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#765: FILE: drivers/net/avp/avp_ethdev.c:842:
+	PMD_DRV_LOG(DEBUG, "AVP first host tx queue at 0x%"PRIx64"
",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#767: FILE: drivers/net/avp/avp_ethdev.c:844:
+	PMD_DRV_LOG(DEBUG, "AVP first host alloc queue at 0x%"PRIx64"
",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#777: FILE: drivers/net/avp/avp_ethdev.c:854:
+	PMD_DRV_LOG(DEBUG, "AVP first host rx queue at 0x%"PRIx64"
",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#779: FILE: drivers/net/avp/avp_ethdev.c:856:
+	PMD_DRV_LOG(DEBUG, "AVP first host free queue at 0x%"PRIx64"
",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#788: FILE: drivers/net/avp/avp_ethdev.c:865:
+	PMD_DRV_LOG(DEBUG, "AVP host request queue at 0x%"PRIx64"
",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#790: FILE: drivers/net/avp/avp_ethdev.c:867:
+	PMD_DRV_LOG(DEBUG, "AVP host response queue at 0x%"PRIx64"
",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#792: FILE: drivers/net/avp/avp_ethdev.c:869:
+	PMD_DRV_LOG(DEBUG, "AVP host sync address at 0x%"PRIx64"
",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#794: FILE: drivers/net/avp/avp_ethdev.c:871:
+	PMD_DRV_LOG(DEBUG, "AVP host mbuf address at 0x%"PRIx64"
",

total: 0 errors, 7 warnings, 21 checks, 811 lines checked