[dpdk-test-report] |WARNING| pw19936 [PATCH RFCv2 3/4] ring: allow common ring to use 8 or 16 byte values

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Jan 24 11:40:06 CET 2017
Previous message: [dpdk-test-report] |WARNING| pw19935 [PATCH RFCv2 2/4] ring: separate common and rte_ring specific functions
Next message: [dpdk-test-report] |WARNING| pw19937 [PATCH RFCv2 4/4] ring: add new event ring class
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/19936

_coding style issues_


WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#65: FILE: lib/librte_ring/rte_common_ring.c:104:
+rte_common_ring_get_memsize(unsigned count, unsigned int elem_sz)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#82: FILE: lib/librte_ring/rte_common_ring.c:123:
+	unsigned flags, unsigned int elem_sz)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#99: FILE: lib/librte_ring/rte_common_ring.c:164:
+		unsigned flags, unsigned int elem_sz)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#154: FILE: lib/librte_ring/rte_common_ring.h:237:
+ssize_t rte_common_ring_get_memsize(unsigned count, unsigned int elem_sz);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#163: FILE: lib/librte_ring/rte_common_ring.h:274:
+	unsigned flags, unsigned int elem_sz);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#172: FILE: lib/librte_ring/rte_common_ring.h:316:
+				 int socket_id, unsigned flags,

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#195: FILE: lib/librte_ring/rte_common_ring.h:370:
 		switch (n & 0x3) { \
+			case 3: r->ring[idx++] = objs[i++]; \
+			case 2: r->ring[idx++] = objs[i++]; \
+			case 1: r->ring[idx++] = objs[i++]; \

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#199: FILE: lib/librte_ring/rte_common_ring.h:371:
+			case 3: r->ring[idx++] = objs[i++]; \

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#200: FILE: lib/librte_ring/rte_common_ring.h:372:
+			case 2: r->ring[idx++] = objs[i++]; \

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#201: FILE: lib/librte_ring/rte_common_ring.h:373:
+			case 1: r->ring[idx++] = objs[i++]; \

ERROR:SPACING: space required before the open parenthesis '('
#211: FILE: lib/librte_ring/rte_common_ring.h:381:
+} while(0)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#218: FILE: lib/librte_ring/rte_common_ring.h:388:
+		for (i = 0; i < (n & ((~(unsigned)0x3))); i+=4, idx+=4) { \

ERROR:SPACING: spaces required around that '+=' (ctx:VxV)
#218: FILE: lib/librte_ring/rte_common_ring.h:388:
+		for (i = 0; i < (n & ((~(unsigned)0x3))); i+=4, idx+=4) { \
 		                                           ^

ERROR:SPACING: spaces required around that '+=' (ctx:VxV)
#218: FILE: lib/librte_ring/rte_common_ring.h:388:
+		for (i = 0; i < (n & ((~(unsigned)0x3))); i+=4, idx+=4) { \
 		                                                   ^

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#224: FILE: lib/librte_ring/rte_common_ring.h:394:
+		switch (n & 0x3) { \
+			case 3: ring[idx++] = objs[i++]; \
+			case 2: ring[idx++] = objs[i++]; \
+			case 1: ring[idx++] = objs[i++]; \

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#225: FILE: lib/librte_ring/rte_common_ring.h:395:
+			case 3: ring[idx++] = objs[i++]; \

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#226: FILE: lib/librte_ring/rte_common_ring.h:396:
+			case 2: ring[idx++] = objs[i++]; \

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#227: FILE: lib/librte_ring/rte_common_ring.h:397:
+			case 1: ring[idx++] = objs[i++]; \

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#245: FILE: lib/librte_ring/rte_common_ring.h:415:
+		for (i = 0; i < (n & (~(unsigned)0x3)); i+=4, idx+=4) {\

ERROR:SPACING: spaces required around that '+=' (ctx:VxV)
#245: FILE: lib/librte_ring/rte_common_ring.h:415:
+		for (i = 0; i < (n & (~(unsigned)0x3)); i+=4, idx+=4) {\
 		                                         ^

ERROR:SPACING: spaces required around that '+=' (ctx:VxV)
#245: FILE: lib/librte_ring/rte_common_ring.h:415:
+		for (i = 0; i < (n & (~(unsigned)0x3)); i+=4, idx+=4) {\
 		                                                 ^

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#251: FILE: lib/librte_ring/rte_common_ring.h:421:
+		switch (n & 0x3) { \
+			case 3: objs[i++] = r->ring[idx++]; \
+			case 2: objs[i++] = r->ring[idx++]; \
+			case 1: objs[i++] = r->ring[idx++]; \

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#252: FILE: lib/librte_ring/rte_common_ring.h:422:
+			case 3: objs[i++] = r->ring[idx++]; \

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#253: FILE: lib/librte_ring/rte_common_ring.h:423:
+			case 2: objs[i++] = r->ring[idx++]; \

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#254: FILE: lib/librte_ring/rte_common_ring.h:424:
+			case 1: objs[i++] = r->ring[idx++]; \

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#279: FILE: lib/librte_ring/rte_common_ring.h:445:
 		switch (n & 0x3) { \
+			case 3: objs[i++] = ring[idx++]; \
+			case 2: objs[i++] = ring[idx++]; \
+			case 1: objs[i++] = ring[idx++]; \

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#283: FILE: lib/librte_ring/rte_common_ring.h:446:
+			case 3: objs[i++] = ring[idx++]; \

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#284: FILE: lib/librte_ring/rte_common_ring.h:447:
+			case 2: objs[i++] = ring[idx++]; \

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#285: FILE: lib/librte_ring/rte_common_ring.h:448:
+			case 1: objs[i++] = ring[idx++]; \

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#304: FILE: lib/librte_ring/rte_common_ring.h:485:
+			 unsigned n, unsigned int elem_sz,

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#314: FILE: lib/librte_ring/rte_common_ring.h:537:
+	switch (elem_sz) {
+		case sizeof(void *): ENQUEUE_PTRS(); break;
+		case sizeof(rte_xmm_t): ENQUEUE_16B(); break;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#315: FILE: lib/librte_ring/rte_common_ring.h:538:
+		case sizeof(void *): ENQUEUE_PTRS(); break;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#316: FILE: lib/librte_ring/rte_common_ring.h:539:
+		case sizeof(rte_xmm_t): ENQUEUE_16B(); break;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#328: FILE: lib/librte_ring/rte_common_ring.h:598:
+			 unsigned n, unsigned int elem_sz,

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#338: FILE: lib/librte_ring/rte_common_ring.h:636:
+	switch (elem_sz) {
+		case sizeof(void *): ENQUEUE_PTRS(); break;
+		case sizeof(rte_xmm_t): ENQUEUE_16B(); break;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#339: FILE: lib/librte_ring/rte_common_ring.h:637:
+		case sizeof(void *): ENQUEUE_PTRS(); break;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#340: FILE: lib/librte_ring/rte_common_ring.h:638:
+		case sizeof(rte_xmm_t): ENQUEUE_16B(); break;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#352: FILE: lib/librte_ring/rte_common_ring.h:686:
+		 unsigned n, unsigned int elem_sz,

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#362: FILE: lib/librte_ring/rte_common_ring.h:736:
+	switch (elem_sz) {
+		case sizeof(void *): DEQUEUE_PTRS(); break;
+		case sizeof(rte_xmm_t): DEQUEUE_16B(); break;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#363: FILE: lib/librte_ring/rte_common_ring.h:737:
+		case sizeof(void *): DEQUEUE_PTRS(); break;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#364: FILE: lib/librte_ring/rte_common_ring.h:738:
+		case sizeof(rte_xmm_t): DEQUEUE_16B(); break;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#376: FILE: lib/librte_ring/rte_common_ring.h:789:
+		 unsigned n, unsigned int elem_sz,

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#386: FILE: lib/librte_ring/rte_common_ring.h:824:
+	switch (elem_sz) {
+		case sizeof(void *): DEQUEUE_PTRS(); break;
+		case sizeof(rte_xmm_t): DEQUEUE_16B(); break;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#387: FILE: lib/librte_ring/rte_common_ring.h:825:
+		case sizeof(void *): DEQUEUE_PTRS(); break;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#388: FILE: lib/librte_ring/rte_common_ring.h:826:
+		case sizeof(rte_xmm_t): DEQUEUE_16B(); break;

WARNING:LONG_LINE: line over 90 characters
#433: FILE: lib/librte_ring/rte_ring.h:218:
+	return __rte_common_ring_mp_do_enqueue(r, obj_table, n, sizeof(void *), RTE_RING_QUEUE_FIXED);

WARNING:LONG_LINE: line over 90 characters
#442: FILE: lib/librte_ring/rte_ring.h:240:
+	return __rte_common_ring_sp_do_enqueue(r, obj_table, n, sizeof(void *), RTE_RING_QUEUE_FIXED);

WARNING:LONG_LINE: line over 90 characters
#451: FILE: lib/librte_ring/rte_ring.h:359:
+	return __rte_common_ring_mc_do_dequeue(r, obj_table, n, sizeof(void *), RTE_RING_QUEUE_FIXED);

WARNING:LONG_LINE: line over 90 characters
#460: FILE: lib/librte_ring/rte_ring.h:380:
+	return __rte_common_ring_sc_do_dequeue(r, obj_table, n, sizeof(void *), RTE_RING_QUEUE_FIXED);

WARNING:LONG_LINE: line over 90 characters
#469: FILE: lib/librte_ring/rte_ring.h:571:
+	return __rte_common_ring_mp_do_enqueue(r, obj_table, n, sizeof(void *), RTE_RING_QUEUE_VARIABLE);

WARNING:LONG_LINE: line over 90 characters
#478: FILE: lib/librte_ring/rte_ring.h:590:
+	return __rte_common_ring_sp_do_enqueue(r, obj_table, n, sizeof(void *), RTE_RING_QUEUE_VARIABLE);

WARNING:LONG_LINE: line over 90 characters
#487: FILE: lib/librte_ring/rte_ring.h:639:
+	return __rte_common_ring_mc_do_dequeue(r, obj_table, n, sizeof(void *), RTE_RING_QUEUE_VARIABLE);

WARNING:LONG_LINE: line over 90 characters
#496: FILE: lib/librte_ring/rte_ring.h:659:
+	return __rte_common_ring_sc_do_dequeue(r, obj_table, n, sizeof(void *), RTE_RING_QUEUE_VARIABLE);

total: 33 errors, 20 warnings, 396 lines checked
Previous message: [dpdk-test-report] |WARNING| pw19935 [PATCH RFCv2 2/4] ring: separate common and rte_ring specific functions
Next message: [dpdk-test-report] |WARNING| pw19937 [PATCH RFCv2 4/4] ring: add new event ring class
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list