[dpdk-test-report] |WARNING| pw19937 [PATCH RFCv2 4/4] ring: add new event ring class

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Jan 24 11:40:14 CET 2017
Previous message: [dpdk-test-report] |WARNING| pw19936 [PATCH RFCv2 3/4] ring: allow common ring to use 8 or 16 byte values
Next message: [dpdk-test-report] |SUCCESS| pw19938 [PATCH] net/szedata2: fix incorrect device memory access
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/19937

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#117: FILE: app/test/test_event_ring.c:42:
+#define ERR_OUT() do { \
+	printf("Error %s:%d
", __FILE__, __LINE__); \
+	return -1; \
+} while (0)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#140: FILE: app/test/test_event_ring.c:65:
+			unsigned j;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#218: FILE: lib/librte_ring/rte_event_ring.c:37:
+rte_event_ring_get_memsize(unsigned count)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#224: FILE: lib/librte_ring/rte_event_ring.c:43:
+rte_event_ring_init(struct rte_ring *r, const char *name, unsigned count,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#225: FILE: lib/librte_ring/rte_event_ring.c:44:
+	unsigned flags)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#232: FILE: lib/librte_ring/rte_event_ring.c:51:
+rte_event_ring_create(const char *name, unsigned count, int socket_id,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#233: FILE: lib/librte_ring/rte_event_ring.c:52:
+		unsigned flags)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#246: FILE: lib/librte_ring/rte_event_ring.c:65:
+rte_event_ring_set_water_mark(struct rte_ring *r, unsigned count)

WARNING:TYPO_SPELLING: 'preemptable' may be misspelled - perhaps 'preemptible'?
#327: FILE: lib/librte_ring/rte_event_ring.h:53:
+ * Note: the ring implementation is not preemptable. A lcore must not

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#357: FILE: lib/librte_ring/rte_event_ring.h:83:
+ssize_t rte_event_ring_get_memsize(unsigned count);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#393: FILE: lib/librte_ring/rte_event_ring.h:119:
+int rte_event_ring_init(struct rte_ring *r, const char *name, unsigned count,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#394: FILE: lib/librte_ring/rte_event_ring.h:120:
+	unsigned flags);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#435: FILE: lib/librte_ring/rte_event_ring.h:161:
+struct rte_ring *rte_event_ring_create(const char *name, unsigned count,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#436: FILE: lib/librte_ring/rte_event_ring.h:162:
+				 int socket_id, unsigned flags);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#463: FILE: lib/librte_ring/rte_event_ring.h:189:
+int rte_event_ring_set_water_mark(struct rte_ring *r, unsigned count);

WARNING:LONG_LINE: line over 90 characters
#494: FILE: lib/librte_ring/rte_event_ring.h:220:
+rte_event_ring_mp_enqueue_bulk(struct rte_ring *r, const struct rte_event * const obj_table,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#495: FILE: lib/librte_ring/rte_event_ring.h:221:
+			 unsigned n)

WARNING:LONG_LINE: line over 90 characters
#497: FILE: lib/librte_ring/rte_event_ring.h:223:
+	return __rte_common_ring_mp_do_enqueue(r, obj_table, n, sizeof(struct rte_event), RTE_RING_QUEUE_FIXED);

WARNING:LONG_LINE: line over 90 characters
#516: FILE: lib/librte_ring/rte_event_ring.h:242:
+rte_event_ring_sp_enqueue_bulk(struct rte_ring *r, const struct rte_event * const obj_table,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#517: FILE: lib/librte_ring/rte_event_ring.h:243:
+			 unsigned n)

WARNING:LONG_LINE: line over 90 characters
#519: FILE: lib/librte_ring/rte_event_ring.h:245:
+	return __rte_common_ring_sp_do_enqueue(r, obj_table, n, sizeof(struct rte_event), RTE_RING_QUEUE_FIXED);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#543: FILE: lib/librte_ring/rte_event_ring.h:269:
+		      unsigned n)

WARNING:LONG_LINE: line over 90 characters
#636: FILE: lib/librte_ring/rte_event_ring.h:362:
+rte_event_ring_mc_dequeue_bulk(struct rte_ring *r, struct rte_event * const obj_table, unsigned n)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#636: FILE: lib/librte_ring/rte_event_ring.h:362:
+rte_event_ring_mc_dequeue_bulk(struct rte_ring *r, struct rte_event * const obj_table, unsigned n)

WARNING:LONG_LINE: line over 90 characters
#638: FILE: lib/librte_ring/rte_event_ring.h:364:
+	return __rte_common_ring_mc_do_dequeue(r, obj_table, n, sizeof(struct rte_event), RTE_RING_QUEUE_FIXED);

WARNING:LONG_LINE: line over 90 characters
#657: FILE: lib/librte_ring/rte_event_ring.h:383:
+rte_event_ring_sc_dequeue_bulk(struct rte_ring *r, struct rte_event * const obj_table, unsigned n)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#657: FILE: lib/librte_ring/rte_event_ring.h:383:
+rte_event_ring_sc_dequeue_bulk(struct rte_ring *r, struct rte_event * const obj_table, unsigned n)

WARNING:LONG_LINE: line over 90 characters
#659: FILE: lib/librte_ring/rte_event_ring.h:385:
+	return __rte_common_ring_sc_do_dequeue(r, obj_table, n, sizeof(struct rte_event), RTE_RING_QUEUE_FIXED);

WARNING:LONG_LINE: line over 90 characters
#681: FILE: lib/librte_ring/rte_event_ring.h:407:
+rte_event_ring_dequeue_bulk(struct rte_ring *r, struct rte_event * const obj_table, unsigned n)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#681: FILE: lib/librte_ring/rte_event_ring.h:407:
+rte_event_ring_dequeue_bulk(struct rte_ring *r, struct rte_event * const obj_table, unsigned n)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#846: FILE: lib/librte_ring/rte_event_ring.h:572:
+static inline unsigned __attribute__((always_inline))

WARNING:LONG_LINE: line over 90 characters
#847: FILE: lib/librte_ring/rte_event_ring.h:573:
+rte_event_ring_mp_enqueue_burst(struct rte_ring *r, const struct rte_event * const obj_table,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#848: FILE: lib/librte_ring/rte_event_ring.h:574:
+			 unsigned n)

WARNING:LONG_LINE: line over 90 characters
#850: FILE: lib/librte_ring/rte_event_ring.h:576:
+	return __rte_common_ring_mp_do_enqueue(r, obj_table, n, sizeof(struct rte_event), RTE_RING_QUEUE_VARIABLE);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#865: FILE: lib/librte_ring/rte_event_ring.h:591:
+static inline unsigned __attribute__((always_inline))

WARNING:LONG_LINE: line over 90 characters
#866: FILE: lib/librte_ring/rte_event_ring.h:592:
+rte_event_ring_sp_enqueue_burst(struct rte_ring *r, const struct rte_event * const obj_table,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#867: FILE: lib/librte_ring/rte_event_ring.h:593:
+			 unsigned n)

WARNING:LONG_LINE: line over 90 characters
#869: FILE: lib/librte_ring/rte_event_ring.h:595:
+	return __rte_common_ring_sp_do_enqueue(r, obj_table, n, sizeof(struct rte_event), RTE_RING_QUEUE_VARIABLE);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#888: FILE: lib/librte_ring/rte_event_ring.h:614:
+static inline unsigned __attribute__((always_inline))

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#890: FILE: lib/librte_ring/rte_event_ring.h:616:
+		      unsigned n)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#915: FILE: lib/librte_ring/rte_event_ring.h:641:
+static inline unsigned __attribute__((always_inline))

WARNING:LONG_LINE: line over 90 characters
#916: FILE: lib/librte_ring/rte_event_ring.h:642:
+rte_event_ring_mc_dequeue_burst(struct rte_ring *r, struct rte_event * const obj_table, unsigned n)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#916: FILE: lib/librte_ring/rte_event_ring.h:642:
+rte_event_ring_mc_dequeue_burst(struct rte_ring *r, struct rte_event * const obj_table, unsigned n)

WARNING:LONG_LINE: line over 90 characters
#918: FILE: lib/librte_ring/rte_event_ring.h:644:
+	return __rte_common_ring_mc_do_dequeue(r, obj_table, n, sizeof(struct rte_event), RTE_RING_QUEUE_VARIABLE);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#935: FILE: lib/librte_ring/rte_event_ring.h:661:
+static inline unsigned __attribute__((always_inline))

WARNING:LONG_LINE: line over 90 characters
#936: FILE: lib/librte_ring/rte_event_ring.h:662:
+rte_event_ring_sc_dequeue_burst(struct rte_ring *r, struct rte_event * const obj_table, unsigned n)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#936: FILE: lib/librte_ring/rte_event_ring.h:662:
+rte_event_ring_sc_dequeue_burst(struct rte_ring *r, struct rte_event * const obj_table, unsigned n)

WARNING:LONG_LINE: line over 90 characters
#938: FILE: lib/librte_ring/rte_event_ring.h:664:
+	return __rte_common_ring_sc_do_dequeue(r, obj_table, n, sizeof(struct rte_event), RTE_RING_QUEUE_VARIABLE);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#957: FILE: lib/librte_ring/rte_event_ring.h:683:
+static inline unsigned __attribute__((always_inline))

WARNING:LONG_LINE: line over 90 characters
#958: FILE: lib/librte_ring/rte_event_ring.h:684:
+rte_event_ring_dequeue_burst(struct rte_ring *r, struct rte_event * const obj_table, unsigned n)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#958: FILE: lib/librte_ring/rte_event_ring.h:684:
+rte_event_ring_dequeue_burst(struct rte_ring *r, struct rte_event * const obj_table, unsigned n)

total: 0 errors, 51 warnings, 885 lines checked
Previous message: [dpdk-test-report] |WARNING| pw19936 [PATCH RFCv2 3/4] ring: allow common ring to use 8 or 16 byte values
Next message: [dpdk-test-report] |SUCCESS| pw19938 [PATCH] net/szedata2: fix incorrect device memory access
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list