[dpdk-test-report] |WARNING| pw27023 [PATCH v11 03/11] net/failsafe: add fail-safe PMD
checkpatch at dpdk.org
checkpatch at dpdk.org
Tue Jul 18 14:50:22 CEST 2017
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27023
_coding style issues_
ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#663: FILE: drivers/net/failsafe/failsafe_args.c:48:
+int mac_from_arg = 0;
CHECK:CAMELCASE: Avoid CamelCase: <PRIu8>
#1705: FILE: drivers/net/failsafe/failsafe_ops.c:613:
+ PRIu8 " with error %d", i, ret);
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects?
#1913: FILE: drivers/net/failsafe/failsafe_private.h:153:
+#define FOREACH_SUBDEV_STATE(s, i, dev, state) \
+ for (i = fs_find_next((dev), 0, state); \
+ i < PRIV(dev)->subs_tail && (s = &PRIV(dev)->subs[i]); \
+ i = fs_find_next((dev), i + 1, state))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects?
#1913: FILE: drivers/net/failsafe/failsafe_private.h:153:
+#define FOREACH_SUBDEV_STATE(s, i, dev, state) \
+ for (i = fs_find_next((dev), 0, state); \
+ i < PRIV(dev)->subs_tail && (s = &PRIV(dev)->subs[i]); \
+ i = fs_find_next((dev), i + 1, state))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'state' - possible side-effects?
#1913: FILE: drivers/net/failsafe/failsafe_private.h:153:
+#define FOREACH_SUBDEV_STATE(s, i, dev, state) \
+ for (i = fs_find_next((dev), 0, state); \
+ i < PRIV(dev)->subs_tail && (s = &PRIV(dev)->subs[i]); \
+ i = fs_find_next((dev), i + 1, state))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects?
#1932: FILE: drivers/net/failsafe/failsafe_private.h:172:
+#define TX_SUBDEV(dev) \
+ (PRIV(dev)->subs_tx >= PRIV(dev)->subs_tail ? NULL \
+ : (PRIV(dev)->subs[PRIV(dev)->subs_tx].state < DEV_PROBED ? NULL \
+ : &PRIV(dev)->subs[PRIV(dev)->subs_tx]))
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'ops' may be better as '(ops)' to avoid precedence issues
#1941: FILE: drivers/net/failsafe/failsafe_private.h:181:
+#define SUBOPS(s, ops) \
+ (ETH(s)->dev_ops->ops)
total: 1 errors, 0 warnings, 1960 lines checked
More information about the test-report
mailing list