[dpdk-test-report] |WARNING| pw25401 [PATCH 35/38] net/dpaa: add support for packet type parsing

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Jun 16 07:42:02 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25401

_coding style issues_


ERROR:SPACING: space required after that close brace '}'
#324: FILE: drivers/net/dpaa/dpaa_rxtx.h:148:
+		}__attribute__((__packed__));

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#352: FILE: drivers/net/dpaa/dpaa_rxtx.h:176:
+#define first_ip_option        first_ip_err_code & 0x01

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#353: FILE: drivers/net/dpaa/dpaa_rxtx.h:177:
+#define first_unknown_ip_proto first_ip_err_code & 0x02

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#354: FILE: drivers/net/dpaa/dpaa_rxtx.h:178:
+#define first_fragmented       first_ip_err_code & 0x04

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#355: FILE: drivers/net/dpaa/dpaa_rxtx.h:179:
+#define first_ip_type          first_ip_err_code & 0x18

ERROR:SPACING: space required after that close brace '}'
#357: FILE: drivers/net/dpaa/dpaa_rxtx.h:181:
+		}__attribute__((__packed__));

CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_buf' may be better as '(_buf)' to avoid precedence issues
#401: FILE: drivers/net/dpaa/dpaa_rxtx.h:225:
+#define GET_RX_PRS(_buf) \
+	(struct dpaa_eth_parse_results_t *)((uint8_t *)_buf + DEFAULT_RX_ICEOF)

total: 6 errors, 0 warnings, 1 checks, 360 lines checked


More information about the test-report mailing list