[dpdk-test-report] |WARNING| pw21055 [PATCH 04/13] net/sfc: factor out libefx-based Rx datapath

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Mar 2 08:10:21 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21055

_coding style issues_


WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EEXIST)
#226: FILE: drivers/net/sfc/sfc_dp.c:81:
+		return EEXIST;

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#278: FILE: drivers/net/sfc/sfc_dp.h:40:
+#define SFC_DIV_ROUND_UP(a, b) \
+	__extension__ ({		\
+		typeof(a) _a = (a);	\
+		typeof(b) _b = (b);	\
+					\
+		(_a + (_b - 1)) / _b;	\
+	})

WARNING:TYPO_SPELLING: 'initalize' may be misspelled - perhaps 'initialize'?
#432: FILE: drivers/net/sfc/sfc_dp_rx.h:102:
+ * Allocate and initalize datapath receive queue.

CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#1182: FILE: drivers/net/sfc/sfc_rx.c:428:
+	rxq->pending = rxq->completed = rxq->added = rxq->pushed = 0;

total: 1 errors, 2 warnings, 1 checks, 1371 lines checked


More information about the test-report mailing list