[dpdk-test-report] |WARNING| pw21069 [PATCH 3/6] prgdev: add bus probe and remove functions

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Mar 2 12:08:02 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21069

_coding style issues_


WARNING:TYPO_SPELLING: 'occured' may be misspelled - perhaps 'occurred'?
#49: 
hotplug occured.

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#178: FILE: lib/librte_prgdev/rte_prgdev.c:111:
+			(unsigned) pci_dev->id.vendor_id,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#179: FILE: lib/librte_prgdev/rte_prgdev.c:112:
+			(unsigned) pci_dev->id.device_id);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#232: FILE: lib/librte_prgdev/rte_prgdev.c:165:
+	unsigned i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#244: FILE: lib/librte_prgdev/rte_prgdev.c:177:
+	unsigned i;

WARNING:TYPO_SPELLING: 'unkown' may be misspelled - perhaps 'unknown'?
#323: FILE: lib/librte_prgdev/rte_prgdev.h:70:
+	RTE_PRG_STAT_UNKNOWN = 0,  /** Device in a unkown state */

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#363: FILE: lib/librte_prgdev/rte_prgdev.h:110:
+/*
+*     prg_dev_init routine

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#370: FILE: lib/librte_prgdev/rte_prgdev.h:117:
+/*
+*     prg_dev_uninit routine

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#446: FILE: lib/librte_prgdev/rte_prgdev.h:193:
+	/* A array to store hardware, firmware, running image info.Each device
+	* can define and interpret the info. For example, a device can define

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#488: FILE: lib/librte_prgdev/rte_prgdev.h:235:
+#define RTE_PRG_VALID_DEVID_OR_ERR_RET(dev_id, retval) do { \
+	if (!rte_prgdev_is_valid_dev(dev_id)) { \
+		PRG_LOG_DEBUG("Invalid dev_id=%d", dev_id); \
+		return retval; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#495: FILE: lib/librte_prgdev/rte_prgdev.h:242:
+#define RTE_PRG_FUNC_PTR_OR_ERR_RET(func, retval) do { \
+	if ((func) == NULL) { \
+		PRG_LOG_DEBUG("Function not supported
"); \
+		return retval; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#502: FILE: lib/librte_prgdev/rte_prgdev.h:249:
+#define RTE_PRG_PRIMARY_PROC_OR_ERR_RET(retval) do { \
+	if (rte_eal_process_type() != RTE_PROC_PRIMARY) { \
+		PRG_LOG_DEBUG("prgdev doesn't support secondary process"); \
+		return retval; \
+	} \
+} while (0)

total: 0 errors, 12 warnings, 473 lines checked


More information about the test-report mailing list