[dpdk-test-report] |WARNING| pw21229 [PATCH] ppp implemantation

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Mar 3 08:27:54 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21229

_coding style issues_


WARNING:TYPO_SPELLING: 'implemantation' may be misspelled - perhaps 'implementation'?
#27: 
Subject: [dpdk-dev] [PATCH] ppp implemantation

ERROR:CODE_INDENT: code indent should use tabs where possible
#171: FILE: app/test-pmd/config.c:3281:
+                printf("%s: File operations failed
", __func__);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#171: FILE: app/test-pmd/config.c:3281:
+                printf("%s: File operations failed
", __func__);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#174: FILE: app/test-pmd/config.c:3284:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#174: FILE: app/test-pmd/config.c:3284:
+        }$

ERROR:SPACING: space required before the open parenthesis '('
#177: FILE: app/test-pmd/config.c:3287:
+	for(uint32_t i = 0; i < pkg_size; i++) {

ERROR:CODE_INDENT: code indent should use tabs where possible
#223: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:202:
+        i40e_aqc_opc_write_personalization_profile^I= 0x0270,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#223: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:202:
+        i40e_aqc_opc_write_personalization_profile^I= 0x0270,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#224: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:203:
+        i40e_aqc_opc_get_personalization_profile_list^I= 0x0271,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#224: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:203:
+        i40e_aqc_opc_get_personalization_profile_list^I= 0x0271,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#235: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1450:
+        u8      reserved[4];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#235: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1450:
+        u8      reserved[4];$

ERROR:CODE_INDENT: code indent should use tabs where possible
#236: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1451:
+        __le32  profile_track_id;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#236: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1451:
+        __le32  profile_track_id;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#237: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1452:
+        __le32  addr_high;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#237: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1452:
+        __le32  addr_high;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#238: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1453:
+        __le32  addr_low;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#238: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1453:
+        __le32  addr_low;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#244: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1459:
+        __le32 error_offset;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#244: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1459:
+        __le32 error_offset;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#245: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1460:
+        __le32 error_info;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#245: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1460:
+        __le32 error_info;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#246: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1461:
+        __le32 addr_high;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#246: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1461:
+        __le32 addr_high;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#247: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1462:
+        __le32 addr_low;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#247: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1462:
+        __le32 addr_low;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#379: FILE: drivers/net/i40e/base/i40e_common.c:7105:
+^I^I         pkg_hdr->segment_offset[i]);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#423: FILE: drivers/net/i40e/base/i40e_common.c:7149:
+                return I40E_NOT_SUPPORTED;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#423: FILE: drivers/net/i40e/base/i40e_common.c:7149:
+                return I40E_NOT_SUPPORTED;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#482: FILE: drivers/net/i40e/base/i40e_common.c:7208:
+        struct i40e_profile_section_header *sec = NULL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#482: FILE: drivers/net/i40e/base/i40e_common.c:7208:
+        struct i40e_profile_section_header *sec = NULL;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#483: FILE: drivers/net/i40e/base/i40e_common.c:7209:
+        struct i40e_profile_info *pinfo;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#483: FILE: drivers/net/i40e/base/i40e_common.c:7209:
+        struct i40e_profile_info *pinfo;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#484: FILE: drivers/net/i40e/base/i40e_common.c:7210:
+        u32 offset = 0, info = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#484: FILE: drivers/net/i40e/base/i40e_common.c:7210:
+        u32 offset = 0, info = 0;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#487: FILE: drivers/net/i40e/base/i40e_common.c:7213:
+        sec->tbl_size = 1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#487: FILE: drivers/net/i40e/base/i40e_common.c:7213:
+        sec->tbl_size = 1;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#488: FILE: drivers/net/i40e/base/i40e_common.c:7214:
+        sec->data_end = sizeof(struct i40e_profile_section_header) +$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#488: FILE: drivers/net/i40e/base/i40e_common.c:7214:
+        sec->data_end = sizeof(struct i40e_profile_section_header) +$

ERROR:CODE_INDENT: code indent should use tabs where possible
#489: FILE: drivers/net/i40e/base/i40e_common.c:7215:
+                sizeof(struct i40e_profile_info);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#489: FILE: drivers/net/i40e/base/i40e_common.c:7215:
+                sizeof(struct i40e_profile_info);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#490: FILE: drivers/net/i40e/base/i40e_common.c:7216:
+        sec->section.type = SECTION_TYPE_INFO;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#490: FILE: drivers/net/i40e/base/i40e_common.c:7216:
+        sec->section.type = SECTION_TYPE_INFO;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#491: FILE: drivers/net/i40e/base/i40e_common.c:7217:
+        sec->section.offset = sizeof(struct i40e_profile_section_header);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#491: FILE: drivers/net/i40e/base/i40e_common.c:7217:
+        sec->section.offset = sizeof(struct i40e_profile_section_header);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#492: FILE: drivers/net/i40e/base/i40e_common.c:7218:
+        sec->section.size = sizeof(struct i40e_profile_info);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#492: FILE: drivers/net/i40e/base/i40e_common.c:7218:
+        sec->section.size = sizeof(struct i40e_profile_info);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#493: FILE: drivers/net/i40e/base/i40e_common.c:7219:
+        pinfo = (struct i40e_profile_info *)(profile_info_sec +$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#493: FILE: drivers/net/i40e/base/i40e_common.c:7219:
+        pinfo = (struct i40e_profile_info *)(profile_info_sec +$

ERROR:CODE_INDENT: code indent should use tabs where possible
#494: FILE: drivers/net/i40e/base/i40e_common.c:7220:
+                                             sec->section.offset);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#494: FILE: drivers/net/i40e/base/i40e_common.c:7220:
+                                             sec->section.offset);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#495: FILE: drivers/net/i40e/base/i40e_common.c:7221:
+        pinfo->track_id = track_id;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#495: FILE: drivers/net/i40e/base/i40e_common.c:7221:
+        pinfo->track_id = track_id;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#496: FILE: drivers/net/i40e/base/i40e_common.c:7222:
+        pinfo->version = profile->version;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#496: FILE: drivers/net/i40e/base/i40e_common.c:7222:
+        pinfo->version = profile->version;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#497: FILE: drivers/net/i40e/base/i40e_common.c:7223:
+        pinfo->op = I40E_PPP_ADD_TRACKID;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#497: FILE: drivers/net/i40e/base/i40e_common.c:7223:
+        pinfo->op = I40E_PPP_ADD_TRACKID;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#498: FILE: drivers/net/i40e/base/i40e_common.c:7224:
+        memcpy(pinfo->name, profile->name, I40E_PPP_NAME_SIZE);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#498: FILE: drivers/net/i40e/base/i40e_common.c:7224:
+        memcpy(pinfo->name, profile->name, I40E_PPP_NAME_SIZE);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#500: FILE: drivers/net/i40e/base/i40e_common.c:7226:
+        status = i40e_aq_write_ppp(hw, (void *)sec, sec->data_end,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#500: FILE: drivers/net/i40e/base/i40e_common.c:7226:
+        status = i40e_aq_write_ppp(hw, (void *)sec, sec->data_end,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#501: FILE: drivers/net/i40e/base/i40e_common.c:7227:
+                                   track_id, &offset, &info, NULL);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#501: FILE: drivers/net/i40e/base/i40e_common.c:7227:
+                                   track_id, &offset, &info, NULL);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#502: FILE: drivers/net/i40e/base/i40e_common.c:7228:
+        if (status)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#502: FILE: drivers/net/i40e/base/i40e_common.c:7228:
+        if (status)$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#502: FILE: drivers/net/i40e/base/i40e_common.c:7228:
+        if (status)
+                        PMD_DRV_LOG(ERR, "Failed to add to list: "

ERROR:CODE_INDENT: code indent should use tabs where possible
#503: FILE: drivers/net/i40e/base/i40e_common.c:7229:
+                        PMD_DRV_LOG(ERR, "Failed to add to list: "$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#503: FILE: drivers/net/i40e/base/i40e_common.c:7229:
+                        PMD_DRV_LOG(ERR, "Failed to add to list: "$

ERROR:CODE_INDENT: code indent should use tabs where possible
#504: FILE: drivers/net/i40e/base/i40e_common.c:7230:
+                                    "offset %d, info %d",$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#504: FILE: drivers/net/i40e/base/i40e_common.c:7230:
+                                    "offset %d, info %d",$

ERROR:CODE_INDENT: code indent should use tabs where possible
#505: FILE: drivers/net/i40e/base/i40e_common.c:7231:
+                                    offset, info);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#505: FILE: drivers/net/i40e/base/i40e_common.c:7231:
+                                    offset, info);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#507: FILE: drivers/net/i40e/base/i40e_common.c:7233:
+        return status;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#507: FILE: drivers/net/i40e/base/i40e_common.c:7233:
+        return status;$

total: 37 errors, 37 warnings, 0 checks, 613 lines checked


More information about the test-report mailing list