[dpdk-test-report] |WARNING| pw21231 [PATCH] ppp implemantation

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Mar 3 08:28:03 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21231

_coding style issues_


WARNING:TYPO_SPELLING: 'implemantation' may be misspelled - perhaps 'implementation'?
#27: 
Subject: [dpdk-dev] [PATCH] ppp implemantation

ERROR:CODE_INDENT: code indent should use tabs where possible
#171: FILE: app/test-pmd/config.c:3281:
+                printf("%s: File operations failed
", __func__);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#171: FILE: app/test-pmd/config.c:3281:
+                printf("%s: File operations failed
", __func__);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#174: FILE: app/test-pmd/config.c:3284:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#174: FILE: app/test-pmd/config.c:3284:
+        }$

ERROR:SPACING: space required before the open parenthesis '('
#177: FILE: app/test-pmd/config.c:3287:
+	for(uint32_t i = 0; i < pkg_size; i++) {

ERROR:CODE_INDENT: code indent should use tabs where possible
#223: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:202:
+        i40e_aqc_opc_write_personalization_profile^I= 0x0270,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#223: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:202:
+        i40e_aqc_opc_write_personalization_profile^I= 0x0270,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#224: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:203:
+        i40e_aqc_opc_read_personalization_profile_list^I= 0x0271,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#224: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:203:
+        i40e_aqc_opc_read_personalization_profile_list^I= 0x0271,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#235: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1450:
+        u8      flags;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#235: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1450:
+        u8      flags;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#238: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1453:
+        u8      reserved[3];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#238: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1453:
+        u8      reserved[3];$

ERROR:CODE_INDENT: code indent should use tabs where possible
#239: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1454:
+        __le32  profile_track_id;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#239: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1454:
+        __le32  profile_track_id;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#240: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1455:
+        __le32  addr_high;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#240: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1455:
+        __le32  addr_high;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#241: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1456:
+        __le32  addr_low;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#241: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1456:
+        __le32  addr_low;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#247: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1462:
+        __le32 error_offset;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#247: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1462:
+        __le32 error_offset;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#248: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1463:
+        __le32 error_info;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#248: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1463:
+        __le32 error_info;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#249: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1464:
+        __le32 addr_high;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#249: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1464:
+        __le32 addr_high;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#250: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1465:
+        __le32 addr_low;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#250: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1465:
+        __le32 addr_low;$

WARNING:LONG_LINE: line over 90 characters
#329: FILE: drivers/net/i40e/base/i40e_common.c:7054:
+	i40e_fill_default_direct_cmd_desc(&desc, i40e_aqc_opc_read_personalization_profile_list);

ERROR:CODE_INDENT: code indent should use tabs where possible
#367: FILE: drivers/net/i40e/base/i40e_common.c:7092:
+^I^I         pkg_hdr->segment_offset[i]);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#561: FILE: drivers/net/i40e/i40e_ethdev.c:11228:
+        struct rte_eth_dev *dev = &rte_eth_devices[port];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#561: FILE: drivers/net/i40e/i40e_ethdev.c:11228:
+        struct rte_eth_dev *dev = &rte_eth_devices[port];$

ERROR:CODE_INDENT: code indent should use tabs where possible
#563: FILE: drivers/net/i40e/i40e_ethdev.c:11230:
+        struct i40e_package_header *pkg_hdr;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#563: FILE: drivers/net/i40e/i40e_ethdev.c:11230:
+        struct i40e_package_header *pkg_hdr;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#564: FILE: drivers/net/i40e/i40e_ethdev.c:11231:
+        struct i40e_generic_seg_header *profile_seg_hdr;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#564: FILE: drivers/net/i40e/i40e_ethdev.c:11231:
+        struct i40e_generic_seg_header *profile_seg_hdr;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#565: FILE: drivers/net/i40e/i40e_ethdev.c:11232:
+        struct i40e_generic_seg_header *metadata_seg_hdr;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#565: FILE: drivers/net/i40e/i40e_ethdev.c:11232:
+        struct i40e_generic_seg_header *metadata_seg_hdr;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#566: FILE: drivers/net/i40e/i40e_ethdev.c:11233:
+        uint32_t track_id;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#566: FILE: drivers/net/i40e/i40e_ethdev.c:11233:
+        uint32_t track_id;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#567: FILE: drivers/net/i40e/i40e_ethdev.c:11234:
+        enum i40e_status_code status;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#567: FILE: drivers/net/i40e/i40e_ethdev.c:11234:
+        enum i40e_status_code status;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#569: FILE: drivers/net/i40e/i40e_ethdev.c:11236:
+        pkg_hdr = (struct i40e_package_header *)buff;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#569: FILE: drivers/net/i40e/i40e_ethdev.c:11236:
+        pkg_hdr = (struct i40e_package_header *)buff;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#571: FILE: drivers/net/i40e/i40e_ethdev.c:11238:
+        if (!pkg_hdr) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#571: FILE: drivers/net/i40e/i40e_ethdev.c:11238:
+        if (!pkg_hdr) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#572: FILE: drivers/net/i40e/i40e_ethdev.c:11239:
+                PMD_DRV_LOG(ERR, "Failed to fill the package structure");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#572: FILE: drivers/net/i40e/i40e_ethdev.c:11239:
+                PMD_DRV_LOG(ERR, "Failed to fill the package structure");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#573: FILE: drivers/net/i40e/i40e_ethdev.c:11240:
+                return -EINVAL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#573: FILE: drivers/net/i40e/i40e_ethdev.c:11240:
+                return -EINVAL;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#574: FILE: drivers/net/i40e/i40e_ethdev.c:11241:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#574: FILE: drivers/net/i40e/i40e_ethdev.c:11241:
+        }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#576: FILE: drivers/net/i40e/i40e_ethdev.c:11243:
+        /* Find metadata segment */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#577: FILE: drivers/net/i40e/i40e_ethdev.c:11244:
+        metadata_seg_hdr = i40e_find_segment_in_package(SEGMENT_TYPE_METADATA,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#577: FILE: drivers/net/i40e/i40e_ethdev.c:11244:
+        metadata_seg_hdr = i40e_find_segment_in_package(SEGMENT_TYPE_METADATA,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#578: FILE: drivers/net/i40e/i40e_ethdev.c:11245:
+                                                        pkg_hdr);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#578: FILE: drivers/net/i40e/i40e_ethdev.c:11245:
+                                                        pkg_hdr);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#579: FILE: drivers/net/i40e/i40e_ethdev.c:11246:
+        if (!metadata_seg_hdr) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#579: FILE: drivers/net/i40e/i40e_ethdev.c:11246:
+        if (!metadata_seg_hdr) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#580: FILE: drivers/net/i40e/i40e_ethdev.c:11247:
+                PMD_DRV_LOG(ERR, "Failed to find metadata segment header");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#580: FILE: drivers/net/i40e/i40e_ethdev.c:11247:
+                PMD_DRV_LOG(ERR, "Failed to find metadata segment header");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#581: FILE: drivers/net/i40e/i40e_ethdev.c:11248:
+                return -EINVAL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#581: FILE: drivers/net/i40e/i40e_ethdev.c:11248:
+                return -EINVAL;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#582: FILE: drivers/net/i40e/i40e_ethdev.c:11249:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#582: FILE: drivers/net/i40e/i40e_ethdev.c:11249:
+        }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#583: FILE: drivers/net/i40e/i40e_ethdev.c:11250:
+        track_id = ((struct i40e_metadata_segment *)metadata_seg_hdr)->track_id;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#583: FILE: drivers/net/i40e/i40e_ethdev.c:11250:
+        track_id = ((struct i40e_metadata_segment *)metadata_seg_hdr)->track_id;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#586: FILE: drivers/net/i40e/i40e_ethdev.c:11253:
+        profile_seg_hdr = i40e_find_segment_in_package(SEGMENT_TYPE_I40E,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#586: FILE: drivers/net/i40e/i40e_ethdev.c:11253:
+        profile_seg_hdr = i40e_find_segment_in_package(SEGMENT_TYPE_I40E,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#587: FILE: drivers/net/i40e/i40e_ethdev.c:11254:
+                                                       pkg_hdr);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#587: FILE: drivers/net/i40e/i40e_ethdev.c:11254:
+                                                       pkg_hdr);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#588: FILE: drivers/net/i40e/i40e_ethdev.c:11255:
+        if (!profile_seg_hdr) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#588: FILE: drivers/net/i40e/i40e_ethdev.c:11255:
+        if (!profile_seg_hdr) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#589: FILE: drivers/net/i40e/i40e_ethdev.c:11256:
+                PMD_DRV_LOG(ERR, "Failed to find profile segment header");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#589: FILE: drivers/net/i40e/i40e_ethdev.c:11256:
+                PMD_DRV_LOG(ERR, "Failed to find profile segment header");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#590: FILE: drivers/net/i40e/i40e_ethdev.c:11257:
+                return -EINVAL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#590: FILE: drivers/net/i40e/i40e_ethdev.c:11257:
+                return -EINVAL;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#591: FILE: drivers/net/i40e/i40e_ethdev.c:11258:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#591: FILE: drivers/net/i40e/i40e_ethdev.c:11258:
+        }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#593: FILE: drivers/net/i40e/i40e_ethdev.c:11260:
+        /* Write profile to HW */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#594: FILE: drivers/net/i40e/i40e_ethdev.c:11261:
+        status = i40e_write_profile(hw,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#594: FILE: drivers/net/i40e/i40e_ethdev.c:11261:
+        status = i40e_write_profile(hw,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#598: FILE: drivers/net/i40e/i40e_ethdev.c:11265:
+        if (!status)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#598: FILE: drivers/net/i40e/i40e_ethdev.c:11265:
+        if (!status)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#599: FILE: drivers/net/i40e/i40e_ethdev.c:11266:
+                printf("Write profile successfully.
");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#599: FILE: drivers/net/i40e/i40e_ethdev.c:11266:
+                printf("Write profile successfully.
");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#601: FILE: drivers/net/i40e/i40e_ethdev.c:11268:
+        return status;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#601: FILE: drivers/net/i40e/i40e_ethdev.c:11268:
+        return status;$

total: 45 errors, 43 warnings, 0 checks, 510 lines checked


More information about the test-report mailing list