[dpdk-test-report] |WARNING| pw21295 [PATCH 1/2] net/sfc/base: add MCDI agnostic wrapper for MAC stats clear

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Mar 3 13:49:47 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21295

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#88: FILE: drivers/net/sfc/base/efx.h:562:
+extern	__checkReturn			efx_rc_t

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#134: FILE: drivers/net/sfc/base/efx_mac.c:722:
+	efx_port_t *epp = &(enp->en_port);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#142: FILE: drivers/net/sfc/base/efx_mac.c:730:
+	if ((rc = emop->emo_stats_clear(enp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#145: FILE: drivers/net/sfc/base/efx_mac.c:733:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#150: FILE: drivers/net/sfc/base/efx_mac.c:738:
+	return (rc);

total: 3 errors, 0 warnings, 2 checks, 60 lines checked


More information about the test-report mailing list