[dpdk-test-report] |WARNING| pw21407 [v2 2/3] LPM config file read option

checkpatch at dpdk.org checkpatch at dpdk.org
Sat Mar 4 20:51:30 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21407

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#110: FILE: examples/l3fwd/l3fwd.h:104:
+#define GET_CB_FIELD(in, fd, base, lim, dlm)	do {            \
+	unsigned long val;                                      \
+	char *end;                                              \
+	errno = 0;                                              \
+	val = strtoul((in), &end, (base));                      \
+	if (errno != 0 || end[0] != (dlm) || val > (lim))       \
+		return -EINVAL;                               \
+	(fd) = (typeof(fd))val;                                 \
+	(in) = end + 1;                                         \
+} while (0)

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#496: FILE: examples/l3fwd/l3fwd_lpm.c:234:
+	if (0 == route_num)

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#504: FILE: examples/l3fwd/l3fwd_lpm.c:242:
+	if (NULL == route_rules)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#619: FILE: examples/l3fwd/l3fwd_lpm.c:431:
+			(unsigned)route_base_v4[i].ip,

total: 0 errors, 4 warnings, 594 lines checked


More information about the test-report mailing list