[dpdk-test-report] |WARNING| pw21411 [v3 1/3] Merge l3fwd-acl and l3fwd code.

checkpatch at dpdk.org checkpatch at dpdk.org
Sat Mar 4 21:45:53 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21411

_coding style issues_


WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#3110: FILE: examples/l3fwd/l3fwd_acl.c:727:
+	if (rte_acl_add_rules(context, route_base, route_num) < 0)
+			rte_exit(EXIT_FAILURE, "add rules failed
");

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#3511: FILE: examples/l3fwd/l3fwd_acl.h:58:
+#define GET_CB_FIELD(in, fd, base, lim, dlm)	do {            \
+	unsigned long val;                                      \
+	char *end;                                              \
+	errno = 0;                                              \
+	val = strtoul((in), &end, (base));                      \
+	if (errno != 0 || end[0] != (dlm) || val > (lim))       \
+		return -EINVAL;                               \
+	(fd) = (typeof(fd))val;                                 \
+	(in) = end + 1;                                         \
+} while (0)

WARNING:LONG_LINE: line over 90 characters
#3975: FILE: examples/l3fwd/l3fwd_lpm.c:230:
+				"Unable to add entry %u to v4 LPM table on socket %d
", i, socketid);

WARNING:LONG_LINE: line over 90 characters
#4000: FILE: examples/l3fwd/l3fwd_lpm.c:267:
+				"Unable to add entry %u to the l3fwd LPM table on socket %d
", i, socketid);

WARNING:LONG_LINE_STRING: line over 90 characters
#4121: FILE: examples/l3fwd/main.c:351:
+		"  --"OPTION_ETH_DEST"=X,MM:MM:MM:MM:MM:MM: Ethernet destination for port X
"

WARNING:LONG_LINE_STRING: line over 90 characters
#4131: FILE: examples/l3fwd/main.c:356:
+		"  --"OPTION_HASH_ENTRY_NUM": Specify the hash entry number in hexadecimal to be setup
"

WARNING:LONG_LINE: line over 90 characters
#4413: FILE: examples/l3fwd/main.c:1010:
+					rte_exit(EXIT_FAILURE, "Can't allocate tx buffer for port %u
", (unsigned int) portid);

total: 0 errors, 7 warnings, 2089 lines checked


More information about the test-report mailing list