[dpdk-test-report] |WARNING| pw21571 [PATCH] net/bonding: reduce slave starvation on rx poll

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Mar 7 21:23:06 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21571

_coding style issues_


ERROR:CODE_INDENT: code indent should use tabs where possible
#87: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:162:
+        idx = internals->active_slave;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#87: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:162:
+        idx = internals->active_slave;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#88: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:163:
+        if(idx >= slave_count)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#88: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:163:
+        if(idx >= slave_count)$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#88: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:163:
+        if(idx >= slave_count)
+            internals->active_slave = idx = 0;

ERROR:SPACING: space required before the open parenthesis '('
#88: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:163:
+        if(idx >= slave_count)

ERROR:CODE_INDENT: code indent should use tabs where possible
#89: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:164:
+            internals->active_slave = idx = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#89: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:164:
+            internals->active_slave = idx = 0;$

CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#89: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:164:
+            internals->active_slave = idx = 0;

WARNING:LONG_LINE: line over 90 characters
#106: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:193:
+					bond_mode_8023ad_handle_slow_pkt(internals, slaves[idx],

ERROR:CODE_INDENT: code indent should use tabs where possible
#114: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:207:
+            if(unlikely(++idx == slave_count))$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#114: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:207:
+            if(unlikely(++idx == slave_count))$

ERROR:SPACING: space required before the open parenthesis '('
#114: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:207:
+            if(unlikely(++idx == slave_count))

ERROR:TRAILING_WHITESPACE: trailing whitespace
#115: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:208:
+                idx = 0;  $

ERROR:CODE_INDENT: code indent should use tabs where possible
#115: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:208:
+                idx = 0;  $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#115: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:208:
+                idx = 0;  $

ERROR:CODE_INDENT: code indent should use tabs where possible
#118: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:211:
+        internals->active_slave = idx + 1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#118: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:211:
+        internals->active_slave = idx + 1;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#139: FILE: drivers/net/bonding/rte_eth_bond_private.h:147:
+        uint8_t active_slave;^I^I^I/**< Next active_slave to poll */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#139: FILE: drivers/net/bonding/rte_eth_bond_private.h:147:
+        uint8_t active_slave;^I^I^I/**< Next active_slave to poll */$

total: 10 errors, 9 warnings, 1 checks, 67 lines checked


More information about the test-report mailing list