[dpdk-test-report] |WARNING| pw21696 [PATCH v6 1/3] examples/l3fwd: merge l3fwd-acl code into l3fwd

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Mar 14 10:18:07 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21696

_coding style issues_


WARNING:EMBEDDED_FUNCTION_NAME: Prefer using "%s", __func__ to embedded function names
#3215: FILE: examples/l3fwd/l3fwd_acl.c:866:
+	RTE_LOG(INFO, L3FWD, "entering main loop on lcore %u
", lcore_id);

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#3477: FILE: examples/l3fwd/l3fwd_acl.h:58:
+#define GET_CB_FIELD(in, fd, base, lim, dlm)	do {            \
+	unsigned long val;                                      \
+	char *end;                                              \
+	errno = 0;                                              \
+	val = strtoul((in), &end, (base));                      \
+	if (errno != 0 || end[0] != (dlm) || val > (lim))       \
+		return -EINVAL;                               \
+	(fd) = (typeof(fd))val;                                 \
+	(in) = end + 1;                                         \
+} while (0)

WARNING:LONG_LINE: line over 90 characters
#3941: FILE: examples/l3fwd/l3fwd_lpm.c:230:
+				"Unable to add entry %u to v4 LPM table on socket %d
", i, socketid);

WARNING:LONG_LINE: line over 90 characters
#3966: FILE: examples/l3fwd/l3fwd_lpm.c:267:
+				"Unable to add entry %u to the l3fwd LPM table on socket %d
", i, socketid);

WARNING:LONG_LINE: line over 90 characters
#4380: FILE: examples/l3fwd/main.c:1013:
+					rte_exit(EXIT_FAILURE, "Can't allocate tx buffer for port %u
", (unsigned int) portid);

total: 0 errors, 5 warnings, 2090 lines checked


More information about the test-report mailing list