[dpdk-test-report] |WARNING| pw21826 [PATCH 1/2] net/sfc/base: add advanced function to extract FW version

checkpatch at dpdk.org checkpatch at dpdk.org
Sun Mar 19 11:02:32 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21826

_coding style issues_


ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#104: FILE: drivers/net/sfc/base/ef10_nic.c:962:
+	if ((rc = efx_mcdi_get_capabilities(enp, &flags, NULL, NULL,

CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#130: FILE: drivers/net/sfc/base/efx.h:1227:
+extern	__checkReturn		efx_rc_t

CHECK:SPACING: No space is necessary after a cast
#161: FILE: drivers/net/sfc/base/efx_mcdi.c:1042:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#161: FILE: drivers/net/sfc/base/efx_mcdi.c:1042:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#209: FILE: drivers/net/sfc/base/efx_mcdi.c:1090:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#216: FILE: drivers/net/sfc/base/efx_mcdi.c:1097:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#286: FILE: drivers/net/sfc/base/efx_nic.c:655:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#295: FILE: drivers/net/sfc/base/efx_nic.c:664:
+	return (rc);

total: 5 errors, 1 warnings, 2 checks, 241 lines checked


More information about the test-report mailing list