[dpdk-test-report] |WARNING| pw21976 [PATCH v2 60/61] net/qede: add ntuple and flow director filter support

checkpatch at dpdk.org checkpatch at dpdk.org
Sun Mar 19 11:10:44 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21976

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'flow_type' - possible side-effects?
#270: FILE: drivers/net/qede/qede_fdir.c:33:
+#define QEDE_VALID_FLOW(flow_type) \
+	((flow_type) == RTE_ETH_FLOW_FRAG_IPV4		|| \
+	(flow_type) == RTE_ETH_FLOW_NONFRAG_IPV4_TCP	|| \
+	(flow_type) == RTE_ETH_FLOW_NONFRAG_IPV4_UDP	|| \
+	(flow_type) == RTE_ETH_FLOW_FRAG_IPV6		|| \
+	(flow_type) == RTE_ETH_FLOW_NONFRAG_IPV6_TCP	|| \
+	(flow_type) == RTE_ETH_FLOW_NONFRAG_IPV6_UDP)

CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv4>
#545: FILE: drivers/net/qede/qede_fdir.c:308:
+		*ether_type = rte_cpu_to_be_16(ETHER_TYPE_IPv4);

CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv6>
#564: FILE: drivers/net/qede/qede_fdir.c:327:
+		*ether_type = rte_cpu_to_be_16(ETHER_TYPE_IPv6);

total: 0 errors, 0 warnings, 3 checks, 696 lines checked


More information about the test-report mailing list