[dpdk-test-report] |WARNING| pw24410 [PATCH RFC 2/4] eal: enable experimental dlopen()-based secondary process support

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/24410

_coding style issues_


WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#101: FILE: lib/librte_eal/linuxapp/eal/eal.c:767:
+	unsigned i;

ERROR:CODE_INDENT: code indent should use tabs where possible
#122: FILE: lib/librte_eal/linuxapp/eal/eal.c:788:
+^I^I             eal_thread_loop, NULL);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#130: FILE: lib/librte_eal/linuxapp/eal/eal.c:796:
+^I^I                thread_name);$

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#173: FILE: lib/librte_eal/linuxapp/eal/eal.c:840:
+				return -1;
+			} else {

ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files
#225: FILE: lib/librte_eal/linuxapp/eal/eal_mp.h

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#268: FILE: lib/librte_eal/linuxapp/eal/eal_mp.h:39:
+#define SOCKET_REQ_FORK SOCKET_REQ_USER + 0

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#269: FILE: lib/librte_eal/linuxapp/eal/eal_mp.h:40:
+#define SOCKET_REQ_STDIN SOCKET_REQ_USER + 1

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#270: FILE: lib/librte_eal/linuxapp/eal/eal_mp.h:41:
+#define SOCKET_REQ_STDOUT SOCKET_REQ_USER + 2

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#271: FILE: lib/librte_eal/linuxapp/eal/eal_mp.h:42:
+#define SOCKET_REQ_STDERR SOCKET_REQ_USER + 3

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#272: FILE: lib/librte_eal/linuxapp/eal/eal_mp.h:43:
+#define SOCKET_REQ_LOGFILE SOCKET_REQ_USER + 4

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#273: FILE: lib/librte_eal/linuxapp/eal/eal_mp.h:44:
+#define SOCKET_REQ_PATH SOCKET_REQ_USER + 5

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#274: FILE: lib/librte_eal/linuxapp/eal/eal_mp.h:45:
+#define SOCKET_REQ_ARGC SOCKET_REQ_USER + 6

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#275: FILE: lib/librte_eal/linuxapp/eal/eal_mp.h:46:
+#define SOCKET_REQ_ARGV SOCKET_REQ_USER + 7

ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files
#285: FILE: lib/librte_eal/linuxapp/eal/eal_mp_primary.c

ERROR:OPEN_BRACE: open brace '{' following function declarations go on the next line
#368: FILE: lib/librte_eal/linuxapp/eal/eal_mp_primary.c:79:
+const char *get_run_dir(void) {

ERROR:OPEN_BRACE: open brace '{' following function declarations go on the next line
#378: FILE: lib/librte_eal/linuxapp/eal/eal_mp_primary.c:89:
+void get_rand_str(char *str, int sz) {

ERROR:OPEN_BRACE: open brace '{' following function declarations go on the next line
#390: FILE: lib/librte_eal/linuxapp/eal/eal_mp_primary.c:101:
+int get_lock_file_path(char *str, int sz) {

ERROR:CODE_INDENT: code indent should use tabs where possible
#396: FILE: lib/librte_eal/linuxapp/eal/eal_mp_primary.c:107:
+^I                internal_config.hugefile_prefix, rand_str);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#407: FILE: lib/librte_eal/linuxapp/eal/eal_mp_primary.c:118:
+^I        internal_config.hugefile_prefix);$

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#411: FILE: lib/librte_eal/linuxapp/eal/eal_mp_primary.c:122:
+secondary_wait_thread(void * arg)

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#414: FILE: lib/librte_eal/linuxapp/eal/eal_mp_primary.c:125:
+	pid_t pid = *(pid_t*) arg;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#485: FILE: lib/librte_eal/linuxapp/eal/eal_mp_primary.c:196:
+	srand((unsigned) rte_rdtsc());

ERROR:CODE_INDENT: code indent should use tabs where possible
#500: FILE: lib/librte_eal/linuxapp/eal/eal_mp_primary.c:211:
+^I^I        &sockaddr_len);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#513: FILE: lib/librte_eal/linuxapp/eal/eal_mp_primary.c:224:
+^I^I^I        "on listen socket (%s)
", strerror(errno));$

WARNING:LONG_LINE: line over 90 characters
#593: FILE: lib/librte_eal/linuxapp/eal/eal_mp_primary.c:304:
+				if (eal_mp_sync_receive_data(conn_sock, &argc, sizeof(argc))) {

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#604: FILE: lib/librte_eal/linuxapp/eal/eal_mp_primary.c:315:
+				str = (char*) calloc(1024, 4);

WARNING:LONG_LINE_COMMENT: line over 90 characters
#618: FILE: lib/librte_eal/linuxapp/eal/eal_mp_primary.c:329:
+				 * before we can fork, we need to make sure that argc matches

WARNING:LONG_LINE: line over 90 characters
#630: FILE: lib/librte_eal/linuxapp/eal/eal_mp_primary.c:341:
+				int len = get_lock_file_path(lockfile, sizeof(lockfile)) + 1;

ERROR:POINTER_LOCATION: "foo** bar" should be "foo **bar"
#645: FILE: lib/librte_eal/linuxapp/eal/eal_mp_primary.c:356:
+					void (*exported)(int argc, char** argv);

WARNING:LONG_LINE: line over 90 characters
#668: FILE: lib/librte_eal/linuxapp/eal/eal_mp_primary.c:379:
+						RTE_LOG(ERR, EAL, "Couldn't dlopen: %s
", dlerror());

WARNING:LONG_LINE: line over 90 characters
#676: FILE: lib/librte_eal/linuxapp/eal/eal_mp_primary.c:387:
+						RTE_LOG(ERR, EAL, "Couldn't dlsym: %s
", err);

WARNING:LONG_LINE: line over 90 characters
#681: FILE: lib/librte_eal/linuxapp/eal/eal_mp_primary.c:392:
+					rte_eal_get_configuration()->process_type = RTE_PROC_SECONDARY;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#694: FILE: lib/librte_eal/linuxapp/eal/eal_mp_primary.c:405:
+					for (int i = 0; i < argc; i++) {
+						free(argv[i]);
+					}

WARNING:LONG_LINE_COMMENT: line over 90 characters
#699: FILE: lib/librte_eal/linuxapp/eal/eal_mp_primary.c:410:
+					/* run a new thread waiting for child's termination */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#701: FILE: lib/librte_eal/linuxapp/eal/eal_mp_primary.c:412:
+					/* TODO: store id somewhere, as this is dangerous */

ERROR:CODE_INDENT: code indent should use tabs where possible
#703: FILE: lib/librte_eal/linuxapp/eal/eal_mp_primary.c:414:
+^I^I^I^I^I        secondary_wait_thread, &id);$

WARNING:LONG_LINE: line over 90 characters
#710: FILE: lib/librte_eal/linuxapp/eal/eal_mp_primary.c:421:
+					snprintf(thread_name, RTE_MAX_THREAD_NAME_LEN, "secondary_%u", id);

WARNING:LONG_LINE: line over 90 characters
#711: FILE: lib/librte_eal/linuxapp/eal/eal_mp_primary.c:422:
+					RTE_LOG(DEBUG, EAL, "Attempting to create thread %s
", thread_name);

ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#752: FILE: lib/librte_eal/linuxapp/eal/eal_mp_primary.c:463:
+			memset(&act, 0 , sizeof(act));
 			               ^

ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files
#768: FILE: lib/librte_eal/linuxapp/eal/eal_mp_secondary.c

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#959: FILE: lib/librte_eal/linuxapp/eal/eal_mp_secondary.c:187:
+	switch (t) {
+		case STDIN:
[...]
+		case STDOUT:
[...]
+		case STDERR:
[...]
+		case LOGFILE:

WARNING:LONG_LINE: line over 90 characters
#973: FILE: lib/librte_eal/linuxapp/eal/eal_mp_secondary.c:201:
+			fd = rte_logs.file == NULL ? STDERR_FILENO : fileno(rte_logs.file);

ERROR:OPEN_BRACE: open brace '{' following function declarations go on the next line
#1013: FILE: lib/librte_eal/linuxapp/eal/eal_mp_secondary.c:241:
+int eal_secondary_init(int argc, char **argv) {

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1066: FILE: lib/librte_eal/linuxapp/eal/eal_mp_secondary.c:294:
+		return -1;
+	} else {

total: 28 errors, 16 warnings, 1000 lines checked