[dpdk-test-report] |WARNING| pw24412 [PATCH v4 2/2] ethdev: add traffic management API

checkpatch at dpdk.org checkpatch at dpdk.org
Fri May 19 19:13:49 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/24412

_coding style issues_


WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#315: FILE: lib/librte_ether/rte_tm.c:61:
+			ENOSYS,

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#318: FILE: lib/librte_ether/rte_tm.c:64:
+			rte_strerror(ENOSYS));

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#325: FILE: lib/librte_ether/rte_tm.c:71:
+#define RTE_TM_FUNC(port_id, func)				\
+({							\
+	const struct rte_tm_ops *ops =			\
+		rte_tm_ops_get(port_id, error);		\
+	if (ops == NULL)					\
+		return -rte_errno;			\
+							\
+	if (ops->func == NULL)				\
+		return -rte_tm_error_set(error,		\
+			ENOSYS,				\
+			RTE_TM_ERROR_TYPE_UNSPECIFIED,	\
+			NULL,				\
+			rte_strerror(ENOSYS));		\
+							\
+	ops->func;					\
+})

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#334: FILE: lib/librte_ether/rte_tm.c:80:
+			ENOSYS,				\

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#337: FILE: lib/librte_ether/rte_tm.c:83:
+			rte_strerror(ENOSYS));		\

ERROR:TRAILING_WHITESPACE: trailing whitespace
#957: FILE: lib/librte_ether/rte_tm.h:249:
+^I$

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#1316: FILE: lib/librte_ether/rte_tm.h:608:
+			 * true for all the leaf nodes on this level. */

ERROR:SPACING: space required before the open brace '{'
#2118: FILE: lib/librte_ether/rte_tm.h:1410:
+	if (lid != level_id){

ERROR:SPACING: space required before the open brace '{'
#2119: FILE: lib/librte_ether/rte_tm.h:1411:
+		if (error){

total: 3 errors, 6 warnings, 2809 lines checked


More information about the test-report mailing list