[dpdk-test-report] |WARNING| pw24486 [PATCH] i40e igb_uio: reset pci on process exit

checkpatch at dpdk.org checkpatch at dpdk.org
Wed May 24 13:22:52 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/24486

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#21: 
I came up with the following patch to ensure igb_uio will always reset PCI on process exit.

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#40: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:176:
+       int ret;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#41: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:177:
+       struct rte_uio_pci_dev *udev = info->priv;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#42: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:178:
+       struct pci_dev *dev = udev->pdev;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#43: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:179:
+       ret = __pci_reset_function(dev);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#44: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:180:
+       dev_info(&dev->dev, "pci_reset_function %s 
",$

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#44: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:180:
+       dev_info(&dev->dev, "pci_reset_function %s 
",

ERROR:CODE_INDENT: code indent should use tabs where possible
#45: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:181:
+                 ret == 0 ? "succeded" : "failed");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#45: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:181:
+                 ret == 0 ? "succeded" : "failed");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#46: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:182:
+       return 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#57: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:388:
+       udev->info.release = igbuio_pci_release;$

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 2 errors, 10 warnings, 26 lines checked


More information about the test-report mailing list