[dpdk-test-report] |WARNING| pw24684 [PATCH RFC] Add Membership Library

checkpatch at dpdk.org checkpatch at dpdk.org
Sat May 27 03:37:27 CEST 2017
Previous message: [dpdk-test-report] |FAILURE| pw24660 [PATCH v2 04/25] bnxt: support lack of huge pages
Next message: [dpdk-test-report] |FAILURE| pw24662 [PATCH v2 06/25] bnxt: add tunneling support
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/24684

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#15: 
A proposal for a new DPDK library that is called â€œMembership Libraryâ€. It

WARNING:TYPO_SPELLING: 'arguements' may be misspelled - perhaps 'arguments'?
#3061: FILE: doc/guides/prog_guide/membership_lib.rst:342:
+The input arguements for the function are *setsum* which is the pointer to the

WARNING:TYPO_SPELLING: 'arguements' may be misspelled - perhaps 'arguments'?
#3126: FILE: doc/guides/prog_guide/membership_lib.rst:407:
+an error is returned. The input arguements for the function are *setsum* which

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#3310: FILE: lib/librte_membership/rte_membership.c:61:
+	switch (setsum->type) {
+		case SETSUM_TYPE_HT:
[...]
+		case SETSUM_TYPE_CACHE:
[...]
+		case SETSUM_TYPE_BF:
[...]
+		case SETSUM_TYPE_VBF:
[...]
+		default:

WARNING:BRACES: braces {} are not necessary for single statement blocks
#3338: FILE: lib/librte_membership/rte_membership.c:89:
+	if (params == NULL) {
+		return NULL;
+	}

WARNING:LONG_LINE: line over 90 characters
#3343: FILE: lib/librte_membership/rte_membership.c:94:
+													rte_membership_list);

ERROR:SPACING: space required before the open brace '{'
#3360: FILE: lib/librte_membership/rte_membership.c:111:
+	if (te == NULL){

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#3388: FILE: lib/librte_membership/rte_membership.c:139:
+	switch (setsum->type) {
+		case SETSUM_TYPE_HT:
[...]
+		case SETSUM_TYPE_CACHE:
[...]
+		case SETSUM_TYPE_BF:
[...]
+		case SETSUM_TYPE_VBF:
[...]
+		default:

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#3432: FILE: lib/librte_membership/rte_membership.c:183:
+	switch (setsum->type) {
+		case SETSUM_TYPE_HT:
[...]
+		case SETSUM_TYPE_CACHE:
[...]
+		case SETSUM_TYPE_BF:
[...]
+		case SETSUM_TYPE_VBF:
[...]
+		default:

WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return
#3447: FILE: lib/librte_membership/rte_membership.c:198:
+			return -EINVAL;
+			break;

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#3462: FILE: lib/librte_membership/rte_membership.c:213:
+	switch (setsum->type) {
+		case SETSUM_TYPE_HT:
[...]
+		case SETSUM_TYPE_CACHE:
[...]
+		case SETSUM_TYPE_BF:
[...]
+		case SETSUM_TYPE_VBF:
[...]
+		default:

WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return
#3477: FILE: lib/librte_membership/rte_membership.c:228:
+			return -EINVAL;
+			break;

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#3492: FILE: lib/librte_membership/rte_membership.c:243:
+	switch (setsum->type) {
+		case SETSUM_TYPE_HT:
[...]
+		case SETSUM_TYPE_CACHE:
[...]
+		case SETSUM_TYPE_BF:
[...]
+		case SETSUM_TYPE_VBF:
[...]
+		default:

WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return
#3511: FILE: lib/librte_membership/rte_membership.c:262:
+			return -EINVAL;
+			break;

ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#3523: FILE: lib/librte_membership/rte_membership.c:274:
+	int ret=0;
 	       ^

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#3524: FILE: lib/librte_membership/rte_membership.c:275:
+	switch (setsum->type) {
+		case SETSUM_TYPE_HT:
[...]
+		case SETSUM_TYPE_CACHE:
[...]
+		case SETSUM_TYPE_BF:
[...]
+		case SETSUM_TYPE_VBF:
[...]
+		default:

WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return
#3539: FILE: lib/librte_membership/rte_membership.c:290:
+			return -EINVAL;
+			break;

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#3555: FILE: lib/librte_membership/rte_membership.c:306:
+	switch (setsum->type) {
+		case SETSUM_TYPE_HT:
[...]
+		case SETSUM_TYPE_CACHE:
[...]
+		case SETSUM_TYPE_BF:
[...]
+		case SETSUM_TYPE_VBF:
[...]
+		default:

WARNING:LONG_LINE: line over 90 characters
#3561: FILE: lib/librte_membership/rte_membership.c:312:
+			ret = rte_membership_lookup_multi_bulk_cache(setsum, keys, num_keys,

WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return
#3574: FILE: lib/librte_membership/rte_membership.c:325:
+			return -EINVAL;
+			break;

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#3588: FILE: lib/librte_membership/rte_membership.c:339:
+	switch (setsum->type) {
+		case SETSUM_TYPE_HT:
[...]
+		case SETSUM_TYPE_CACHE:
[...]
+		case SETSUM_TYPE_BF:
+		case SETSUM_TYPE_VBF:
+		default:

WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return
#3599: FILE: lib/librte_membership/rte_membership.c:350:
+			return -EINVAL;
+			break;

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#3611: FILE: lib/librte_membership/rte_membership.c:362:
+	switch (setsum->type) {
+		case SETSUM_TYPE_HT:
[...]
+		case SETSUM_TYPE_CACHE:
[...]
+		case SETSUM_TYPE_BF:
[...]
+		case SETSUM_TYPE_VBF:
[...]
+		default:

WARNING:MISSING_EOF_NEWLINE: adding a line without newline at end of file
#3627: FILE: lib/librte_membership/rte_membership.c:378:
+}

WARNING:MISSING_EOF_NEWLINE: adding a line without newline at end of file
#3955: FILE: lib/librte_membership/rte_membership.h:321:
+#endif /* _RTE_MEMBERSHIP_H_ */

WARNING:LONG_LINE: line over 90 characters
#4023: FILE: lib/librte_membership/rte_membership_bf.c:61:
+	double denom = 0.480453013918201;							/* ln(2)^2 */

WARNING:BRACES: braces {} are not necessary for single statement blocks
#4028: FILE: lib/librte_membership/rte_membership_bf.c:66:
+	if (ss->num_keys < 1 || ss->false_postive_rate == 0) {
+		return NULL;
+	}

ERROR:SPACING: space required before the open parenthesis '('
#4075: FILE: lib/librte_membership/rte_membership_bf.c:113:
+	if(bloom != NULL)

WARNING:BRACES: braces {} are not necessary for single statement blocks
#4100: FILE: lib/librte_membership/rte_membership_bf.c:138:
+		if (rte_bitmap_get(bmp, x) == 0) {
+			return 0;
+		}

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4119: FILE: lib/librte_membership/rte_membership_bf.c:157:
+rte_membership_lookup_bulk_bf(const struct rte_membership_setsum* setsum,

ERROR:POINTER_LOCATION: "foo** bar" should be "foo **bar"
#4120: FILE: lib/librte_membership/rte_membership_bf.c:158:
+		const void** keys, uint32_t num_keys, MEMBERSHIP_TARGET_TYPE* target_id)

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4120: FILE: lib/librte_membership/rte_membership_bf.c:158:
+		const void** keys, uint32_t num_keys, MEMBERSHIP_TARGET_TYPE* target_id)

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4122: FILE: lib/librte_membership/rte_membership_bf.c:160:
+	struct rte_membership_bf* bloom = setsum->ss;

ERROR:SPACING: spaces required around that '=' (ctx:VxW)
#4162: FILE: lib/librte_membership/rte_membership_bf.c:200:
+			target_ids[i*match_per_key]= target_id[i];
 			                           ^

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#4164: FILE: lib/librte_membership/rte_membership_bf.c:202:
+		}
+		else {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#4212: FILE: lib/librte_membership/rte_membership_bf.c:250:
+	if (bloom != NULL) {
+		rte_bitmap_reset(bloom->bmp_array);
+	}

WARNING:MISSING_EOF_NEWLINE: adding a line without newline at end of file
#4216: FILE: lib/librte_membership/rte_membership_bf.c:254:
+}

ERROR:OPEN_BRACE: open brace '{' following struct go on the same line
#4267: FILE: lib/librte_membership/rte_membership_bf.h:44:
+struct rte_membership_bf
+{

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#4271: FILE: lib/librte_membership/rte_membership_bf.h:48:
+	unsigned bits;		/* actual number of bits allocated (rounded to 2pow) */

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#4272: FILE: lib/librte_membership/rte_membership_bf.h:49:
+	unsigned num_hashes;	/* number of hash functions needed (optimal) */

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#4274: FILE: lib/librte_membership/rte_membership_bf.h:51:
+	unsigned bucket_bitmask;

WARNING:LONG_LINE: line over 90 characters
#4289: FILE: lib/librte_membership/rte_membership_bf.h:66:
+						const void *key, MEMBERSHIP_TARGET_TYPE* target_id);

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4289: FILE: lib/librte_membership/rte_membership_bf.h:66:
+						const void *key, MEMBERSHIP_TARGET_TYPE* target_id);

WARNING:LONG_LINE: line over 90 characters
#4293: FILE: lib/librte_membership/rte_membership_bf.h:70:
+						const void *key, MEMBERSHIP_TARGET_TYPE *target_id);

WARNING:LONG_LINE_COMMENT: line over 90 characters
#4373: FILE: lib/librte_membership/rte_membership_cache.c:45:
+	SIG_TYPE sigs[MEMBERSHIP_BUCKET_ENTRIES]; 			 	/*2-byte signature*/

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#4373: FILE: lib/librte_membership/rte_membership_cache.c:45:
+^ISIG_TYPE sigs[MEMBERSHIP_BUCKET_ENTRIES]; ^I^I^I ^I/*2-byte signature*/$

WARNING:LONG_LINE_COMMENT: line over 90 characters
#4379: FILE: lib/librte_membership/rte_membership_cache.c:51:
+	struct membership_cache_bucket* buckets; 				/*buckets array*/

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#4379: FILE: lib/librte_membership/rte_membership_cache.c:51:
+^Istruct membership_cache_bucket* buckets; ^I^I^I^I/*buckets array*/$

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4379: FILE: lib/librte_membership/rte_membership_cache.c:51:
+	struct membership_cache_bucket* buckets; 				/*buckets array*/

ERROR:SPACING: space required before the open brace '{'
#4387: FILE: lib/librte_membership/rte_membership_cache.c:59:
+rte_membership_create_cache(struct rte_membership_setsum *ss){

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4391: FILE: lib/librte_membership/rte_membership_cache.c:63:
+	struct membership_cache_ss* t;

WARNING:LONG_LINE: line over 90 characters
#4395: FILE: lib/librte_membership/rte_membership_cache.c:67:
+									RTE_CACHE_LINE_SIZE, ss->socket_id);

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4398: FILE: lib/librte_membership/rte_membership_cache.c:70:
+	struct membership_cache_bucket* buckets = rte_zmalloc_socket(NULL,

ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#4403: FILE: lib/librte_membership/rte_membership_cache.c:75:
+	t->bucket_cnt=num_buckets;
 	             ^

ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#4407: FILE: lib/librte_membership/rte_membership_cache.c:79:
+	for( i=0; i<num_buckets; i++){
 	      ^

ERROR:SPACING: spaces required around that '<' (ctx:VxV)
#4407: FILE: lib/librte_membership/rte_membership_cache.c:79:
+	for( i=0; i<num_buckets; i++){
 	           ^

ERROR:SPACING: space required before the open brace '{'
#4407: FILE: lib/librte_membership/rte_membership_cache.c:79:
+	for( i=0; i<num_buckets; i++){

ERROR:SPACING: space prohibited after that open parenthesis '('
#4407: FILE: lib/librte_membership/rte_membership_cache.c:79:
+	for( i=0; i<num_buckets; i++){

ERROR:SPACING: space required before the open parenthesis '('
#4407: FILE: lib/librte_membership/rte_membership_cache.c:79:
+	for( i=0; i<num_buckets; i++){

ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#4408: FILE: lib/librte_membership/rte_membership_cache.c:80:
+		for( j=0; j<MEMBERSHIP_BUCKET_ENTRIES; j++){
 		      ^

ERROR:SPACING: spaces required around that '<' (ctx:VxV)
#4408: FILE: lib/librte_membership/rte_membership_cache.c:80:
+		for( j=0; j<MEMBERSHIP_BUCKET_ENTRIES; j++){
 		           ^

ERROR:SPACING: space required before the open brace '{'
#4408: FILE: lib/librte_membership/rte_membership_cache.c:80:
+		for( j=0; j<MEMBERSHIP_BUCKET_ENTRIES; j++){

ERROR:SPACING: space prohibited after that open parenthesis '('
#4408: FILE: lib/librte_membership/rte_membership_cache.c:80:
+		for( j=0; j<MEMBERSHIP_BUCKET_ENTRIES; j++){

ERROR:SPACING: space required before the open parenthesis '('
#4408: FILE: lib/librte_membership/rte_membership_cache.c:80:
+		for( j=0; j<MEMBERSHIP_BUCKET_ENTRIES; j++){

WARNING:BRACES: braces {} are not necessary for single statement blocks
#4408: FILE: lib/librte_membership/rte_membership_cache.c:80:
+		for( j=0; j<MEMBERSHIP_BUCKET_ENTRIES; j++){
+			buckets[i].targets[j]=RTE_MEMBERSHIP_NO_MATCH;
+		}

ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#4409: FILE: lib/librte_membership/rte_membership_cache.c:81:
+			buckets[i].targets[j]=RTE_MEMBERSHIP_NO_MATCH;
 			                     ^

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4422: FILE: lib/librte_membership/rte_membership_cache.c:94:
+	struct membership_cache_ss* ht = setsum->ss;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4426: FILE: lib/librte_membership/rte_membership_cache.c:98:
+	struct membership_cache_bucket* buckets = ht->buckets;

ERROR:SPACING: space required before the open parenthesis '('
#4439: FILE: lib/librte_membership/rte_membership_cache.c:111:
+		if(tmp_sig == buckets[prim_bucket].sigs[i] &&

WARNING:LONG_LINE: line over 90 characters
#4440: FILE: lib/librte_membership/rte_membership_cache.c:112:
+				buckets[prim_bucket].targets[i] != RTE_MEMBERSHIP_NO_MATCH) {

ERROR:SPACING: space required before the open parenthesis '('
#4446: FILE: lib/librte_membership/rte_membership_cache.c:118:
+		if(tmp_sig == buckets[sec_bucket].sigs[i] &&

WARNING:LONG_LINE: line over 90 characters
#4447: FILE: lib/librte_membership/rte_membership_cache.c:119:
+				buckets[sec_bucket].targets[i] != RTE_MEMBERSHIP_NO_MATCH) {

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4456: FILE: lib/librte_membership/rte_membership_cache.c:128:
+rte_membership_lookup_multi_cache(const struct rte_membership_setsum* setsum,

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4457: FILE: lib/librte_membership/rte_membership_cache.c:129:
+		const void* key, MEMBERSHIP_TARGET_TYPE* target_id)

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4457: FILE: lib/librte_membership/rte_membership_cache.c:129:
+		const void* key, MEMBERSHIP_TARGET_TYPE* target_id)

ERROR:SPACING: space required after that ',' (ctx:VxV)
#4471: FILE: lib/librte_membership/rte_membership_cache.c:143:
+	uint32_t i,j;
 	          ^

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4473: FILE: lib/librte_membership/rte_membership_cache.c:145:
+	struct membership_cache_ss* ht = setsum->ss;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4477: FILE: lib/librte_membership/rte_membership_cache.c:149:
+	struct membership_cache_bucket* buckets = ht->buckets;

ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#4486: FILE: lib/librte_membership/rte_membership_cache.c:158:
+	for( i=0; i<num_keys; i++){
 	      ^

ERROR:SPACING: spaces required around that '<' (ctx:VxV)
#4486: FILE: lib/librte_membership/rte_membership_cache.c:158:
+	for( i=0; i<num_keys; i++){
 	           ^

ERROR:SPACING: space required before the open brace '{'
#4486: FILE: lib/librte_membership/rte_membership_cache.c:158:
+	for( i=0; i<num_keys; i++){

ERROR:SPACING: space prohibited after that open parenthesis '('
#4486: FILE: lib/librte_membership/rte_membership_cache.c:158:
+	for( i=0; i<num_keys; i++){

ERROR:SPACING: space required before the open parenthesis '('
#4486: FILE: lib/librte_membership/rte_membership_cache.c:158:
+	for( i=0; i<num_keys; i++){

ERROR:SPACING: space prohibited before that close parenthesis ')'
#4499: FILE: lib/librte_membership/rte_membership_cache.c:171:
+	for (i = 0; i < num_keys; i++ ) {

ERROR:SPACING: space required before the open parenthesis '('
#4501: FILE: lib/librte_membership/rte_membership_cache.c:173:
+			if(tmp_sig[i] == prim_buckets[i]->sigs[j] &&

WARNING:LONG_LINE: line over 90 characters
#4502: FILE: lib/librte_membership/rte_membership_cache.c:174:
+					prim_buckets[i]->targets[j] != RTE_MEMBERSHIP_NO_MATCH) {

ERROR:SPACING: space required before the open parenthesis '('
#4511: FILE: lib/librte_membership/rte_membership_cache.c:183:
+				if(tmp_sig[i] == sec_buckets[i]->sigs[j] &&

WARNING:LONG_LINE: line over 90 characters
#4512: FILE: lib/librte_membership/rte_membership_cache.c:184:
+						sec_buckets[i]->targets[j] != RTE_MEMBERSHIP_NO_MATCH) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#4519: FILE: lib/librte_membership/rte_membership_cache.c:191:
+		if (j == MEMBERSHIP_BUCKET_ENTRIES) {
+			target_id[i] = RTE_MEMBERSHIP_NO_MATCH;
+		}

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#4541: FILE: lib/librte_membership/rte_membership_cache.c:213:
+		}
+		else {

WARNING:LONG_LINE: line over 90 characters
#4552: FILE: lib/librte_membership/rte_membership_cache.c:224:
+							const void *key, MEMBERSHIP_TARGET_TYPE target_id)

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4555: FILE: lib/librte_membership/rte_membership_cache.c:227:
+	struct membership_cache_ss* ht = setsum->ss;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4559: FILE: lib/librte_membership/rte_membership_cache.c:231:
+	struct membership_cache_bucket* buckets = ht->buckets;

ERROR:SPACING: space required before the open brace '{'
#4585: FILE: lib/librte_membership/rte_membership_cache.c:257:
+		if(buckets[prim_bucket].targets[i] == RTE_MEMBERSHIP_NO_MATCH){

ERROR:SPACING: space required before the open parenthesis '('
#4585: FILE: lib/librte_membership/rte_membership_cache.c:257:
+		if(buckets[prim_bucket].targets[i] == RTE_MEMBERSHIP_NO_MATCH){

ERROR:SPACING: space required before the open brace '{'
#4595: FILE: lib/librte_membership/rte_membership_cache.c:267:
+		if(buckets[sec_bucket].targets[i] == RTE_MEMBERSHIP_NO_MATCH){

ERROR:SPACING: space required before the open parenthesis '('
#4595: FILE: lib/librte_membership/rte_membership_cache.c:267:
+		if(buckets[sec_bucket].targets[i] == RTE_MEMBERSHIP_NO_MATCH){

WARNING:BRACES: braces {} are not necessary for single statement blocks
#4609: FILE: lib/librte_membership/rte_membership_cache.c:281:
+	if (random & MEMBERSHIP_EVICT_CHOOSE) {
+		bucket_choose = sec_bucket;
+	}

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4620: FILE: lib/librte_membership/rte_membership_cache.c:292:
+rte_membership_free_cache(struct rte_membership_setsum* setsum){

ERROR:SPACING: space required before the open brace '{'
#4620: FILE: lib/librte_membership/rte_membership_cache.c:292:
+rte_membership_free_cache(struct rte_membership_setsum* setsum){

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4626: FILE: lib/librte_membership/rte_membership_cache.c:298:
+rte_membership_delete_cache(struct rte_membership_setsum* setsum,

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4627: FILE: lib/librte_membership/rte_membership_cache.c:299:
+		const void* key, MEMBERSHIP_TARGET_TYPE target_id)

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4631: FILE: lib/librte_membership/rte_membership_cache.c:303:
+	struct membership_cache_ss* ht = setsum->ss;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4635: FILE: lib/librte_membership/rte_membership_cache.c:307:
+	struct membership_cache_bucket* buckets = ht->buckets;

ERROR:SPACING: space required before the open parenthesis '('
#4647: FILE: lib/librte_membership/rte_membership_cache.c:319:
+		if(tmp_sig == buckets[prim_bucket].sigs[i]) {

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4666: FILE: lib/librte_membership/rte_membership_cache.c:338:
+	struct membership_cache_ss* ht = setsum->ss;

ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#4668: FILE: lib/librte_membership/rte_membership_cache.c:340:
+	for (i=0; i<ht->bucket_cnt; i++) {
 	      ^

ERROR:SPACING: spaces required around that '<' (ctx:VxV)
#4668: FILE: lib/librte_membership/rte_membership_cache.c:340:
+	for (i=0; i<ht->bucket_cnt; i++) {
 	           ^

ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#4669: FILE: lib/librte_membership/rte_membership_cache.c:341:
+		for (j=0; j<MEMBERSHIP_BUCKET_ENTRIES; j++) {
 		      ^

ERROR:SPACING: spaces required around that '<' (ctx:VxV)
#4669: FILE: lib/librte_membership/rte_membership_cache.c:341:
+		for (j=0; j<MEMBERSHIP_BUCKET_ENTRIES; j++) {
 		           ^

WARNING:BRACES: braces {} are not necessary for single statement blocks
#4669: FILE: lib/librte_membership/rte_membership_cache.c:341:
+		for (j=0; j<MEMBERSHIP_BUCKET_ENTRIES; j++) {
+			ht->buckets[i].targets[j]=RTE_MEMBERSHIP_NO_MATCH;
+		}

ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#4670: FILE: lib/librte_membership/rte_membership_cache.c:342:
+			ht->buckets[i].targets[j]=RTE_MEMBERSHIP_NO_MATCH;
 			                         ^

WARNING:MISSING_EOF_NEWLINE: adding a line without newline at end of file
#4673: FILE: lib/librte_membership/rte_membership_cache.c:345:
+}

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4722: FILE: lib/librte_membership/rte_membership_cache.h:42:
+rte_membership_create_cache(struct rte_membership_setsum* ss);

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4726: FILE: lib/librte_membership/rte_membership_cache.h:46:
+rte_membership_lookup_cache(const struct rte_membership_setsum* setsum,

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4727: FILE: lib/librte_membership/rte_membership_cache.h:47:
+		const void* key, MEMBERSHIP_TARGET_TYPE* target_id);

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4727: FILE: lib/librte_membership/rte_membership_cache.h:47:
+		const void* key, MEMBERSHIP_TARGET_TYPE* target_id);

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4731: FILE: lib/librte_membership/rte_membership_cache.h:51:
+rte_membership_lookup_multi_cache(const struct rte_membership_setsum* setsum,

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4732: FILE: lib/librte_membership/rte_membership_cache.h:52:
+		const void* key, MEMBERSHIP_TARGET_TYPE* target_id);

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4732: FILE: lib/librte_membership/rte_membership_cache.h:52:
+		const void* key, MEMBERSHIP_TARGET_TYPE* target_id);

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4738: FILE: lib/librte_membership/rte_membership_cache.h:58:
+		MEMBERSHIP_TARGET_TYPE* target_ids);

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4743: FILE: lib/librte_membership/rte_membership_cache.h:63:
+rte_membership_lookup_multi_bulk_cache(const struct rte_membership_setsum* setsum,

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4750: FILE: lib/librte_membership/rte_membership_cache.h:70:
+rte_membership_add_cache(const struct rte_membership_setsum* setsum,

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4751: FILE: lib/librte_membership/rte_membership_cache.h:71:
+		const void* key, MEMBERSHIP_TARGET_TYPE target_id);

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4754: FILE: lib/librte_membership/rte_membership_cache.h:74:
+rte_membership_free_cache(struct rte_membership_setsum* setsum);

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4760: FILE: lib/librte_membership/rte_membership_cache.h:80:
+rte_membership_delete_cache(struct rte_membership_setsum* ss, const void* key,

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4760: FILE: lib/librte_membership/rte_membership_cache.h:80:
+rte_membership_delete_cache(struct rte_membership_setsum* ss, const void* key,

WARNING:LONG_LINE_COMMENT: line over 90 characters
#4825: FILE: lib/librte_membership/rte_membership_ht.c:44:
+	SIG_TYPE sigs[MEMBERSHIP_BUCKET_ENTRIES]; 			 /* 2-byte signature */

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#4825: FILE: lib/librte_membership/rte_membership_ht.c:44:
+^ISIG_TYPE sigs[MEMBERSHIP_BUCKET_ENTRIES]; ^I^I^I /* 2-byte signature */$

WARNING:LONG_LINE_COMMENT: line over 90 characters
#4832: FILE: lib/librte_membership/rte_membership_ht.c:51:
+	struct membership_ht_bucket* buckets; 					/* buckets array */

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#4832: FILE: lib/librte_membership/rte_membership_ht.c:51:
+^Istruct membership_ht_bucket* buckets; ^I^I^I^I^I/* buckets array */$

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4832: FILE: lib/librte_membership/rte_membership_ht.c:51:
+	struct membership_ht_bucket* buckets; 					/* buckets array */

ERROR:SPACING: space required before the open brace '{'
#4840: FILE: lib/librte_membership/rte_membership_ht.c:59:
+rte_membership_create_ht(struct rte_membership_setsum *ss){

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4851: FILE: lib/librte_membership/rte_membership_ht.c:70:
+	struct membership_ht_bucket* buckets = rte_zmalloc_socket(NULL,

ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#4861: FILE: lib/librte_membership/rte_membership_ht.c:80:
+	for (i=0; i<num_buckets; i++) {
 	      ^

ERROR:SPACING: spaces required around that '<' (ctx:VxV)
#4861: FILE: lib/librte_membership/rte_membership_ht.c:80:
+	for (i=0; i<num_buckets; i++) {
 	           ^

ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#4862: FILE: lib/librte_membership/rte_membership_ht.c:81:
+		for (j=0; j<MEMBERSHIP_BUCKET_ENTRIES; j++) {
 		      ^

ERROR:SPACING: spaces required around that '<' (ctx:VxV)
#4862: FILE: lib/librte_membership/rte_membership_ht.c:81:
+		for (j=0; j<MEMBERSHIP_BUCKET_ENTRIES; j++) {
 		           ^

WARNING:BRACES: braces {} are not necessary for single statement blocks
#4862: FILE: lib/librte_membership/rte_membership_ht.c:81:
+		for (j=0; j<MEMBERSHIP_BUCKET_ENTRIES; j++) {
+			buckets[i].targets[j]=RTE_MEMBERSHIP_NO_MATCH;
+		}

ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#4863: FILE: lib/librte_membership/rte_membership_ht.c:82:
+			buckets[i].targets[j]=RTE_MEMBERSHIP_NO_MATCH;
 			                     ^

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4871: FILE: lib/librte_membership/rte_membership_ht.c:90:
+rte_membership_lookup_multi_ht(const struct rte_membership_setsum* setsum,

WARNING:LONG_LINE: line over 90 characters
#4872: FILE: lib/librte_membership/rte_membership_ht.c:91:
+							const void* key, MEMBERSHIP_TARGET_TYPE* target_id)

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4872: FILE: lib/librte_membership/rte_membership_ht.c:91:
+							const void* key, MEMBERSHIP_TARGET_TYPE* target_id)

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4872: FILE: lib/librte_membership/rte_membership_ht.c:91:
+							const void* key, MEMBERSHIP_TARGET_TYPE* target_id)

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4877: FILE: lib/librte_membership/rte_membership_ht.c:96:
+	struct membership_ht_ss* ht = setsum->ss;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4881: FILE: lib/librte_membership/rte_membership_ht.c:100:
+	struct membership_ht_bucket* buckets = ht->buckets;

WARNING:LONG_LINE: line over 90 characters
#4894: FILE: lib/librte_membership/rte_membership_ht.c:113:
+				buckets[prim_bucket].targets[i] != RTE_MEMBERSHIP_NO_MATCH) {

WARNING:LONG_LINE: line over 90 characters
#4902: FILE: lib/librte_membership/rte_membership_ht.c:121:
+				buckets[sec_bucket].targets[i] != RTE_MEMBERSHIP_NO_MATCH) {

ERROR:SPACING: space required after that ',' (ctx:VxV)
#4916: FILE: lib/librte_membership/rte_membership_ht.c:135:
+	uint32_t i,j;
 	          ^

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4922: FILE: lib/librte_membership/rte_membership_ht.c:141:
+	struct membership_ht_bucket* buckets = ht->buckets;

WARNING:LONG_LINE: line over 90 characters
#4927: FILE: lib/librte_membership/rte_membership_ht.c:146:
+						prim_buckets[RTE_MEMBERSHIP_LOOKUP_BULK_MAX] = {0};

WARNING:LONG_LINE: line over 90 characters
#4929: FILE: lib/librte_membership/rte_membership_ht.c:148:
+						sec_buckets[RTE_MEMBERSHIP_LOOKUP_BULK_MAX] = {0};

ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#4931: FILE: lib/librte_membership/rte_membership_ht.c:150:
+	for (i=0; i<num_keys; i++) {
 	      ^

ERROR:SPACING: spaces required around that '<' (ctx:VxV)
#4931: FILE: lib/librte_membership/rte_membership_ht.c:150:
+	for (i=0; i<num_keys; i++) {
 	           ^

ERROR:SPACING: space required before the open brace '{'
#4945: FILE: lib/librte_membership/rte_membership_ht.c:164:
+		for (i = 0; i < MEMBERSHIP_BUCKET_ENTRIES; i++){

ERROR:SPACING: space required before the open parenthesis '('
#4946: FILE: lib/librte_membership/rte_membership_ht.c:165:
+			if(tmp_sig[j] == prim_buckets[j]->sigs[i] &&

WARNING:LONG_LINE: line over 90 characters
#4947: FILE: lib/librte_membership/rte_membership_ht.c:166:
+					prim_buckets[j]->targets[i] != RTE_MEMBERSHIP_NO_MATCH){

WARNING:LONG_LINE: line over 90 characters
#4950: FILE: lib/librte_membership/rte_membership_ht.c:169:
+				target_ids[j*match_per_key+match_cnt] = prim_buckets[j]->targets[i];

WARNING:LONG_LINE: line over 90 characters
#4956: FILE: lib/librte_membership/rte_membership_ht.c:175:
+					sec_buckets[j]->targets[i] != RTE_MEMBERSHIP_NO_MATCH) {

WARNING:LONG_LINE: line over 90 characters
#4959: FILE: lib/librte_membership/rte_membership_ht.c:178:
+				target_ids[j*match_per_key+match_cnt] = sec_buckets[j]->targets[i];

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4976: FILE: lib/librte_membership/rte_membership_ht.c:195:
+	struct membership_ht_ss* ht = setsum->ss;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#4980: FILE: lib/librte_membership/rte_membership_ht.c:199:
+	struct membership_ht_bucket* buckets = ht->buckets;

WARNING:LONG_LINE: line over 90 characters
#4993: FILE: lib/librte_membership/rte_membership_ht.c:212:
+				buckets[prim_bucket].targets[i] != RTE_MEMBERSHIP_NO_MATCH) {

WARNING:LONG_LINE: line over 90 characters
#5000: FILE: lib/librte_membership/rte_membership_ht.c:219:
+					buckets[sec_bucket].targets[i] != RTE_MEMBERSHIP_NO_MATCH) {

ERROR:SPACING: space required after that ',' (ctx:VxV)
#5012: FILE: lib/librte_membership/rte_membership_ht.c:231:
+	uint32_t i,j;
 	          ^

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#5014: FILE: lib/librte_membership/rte_membership_ht.c:233:
+	struct membership_ht_ss* ht = setsum->ss;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#5018: FILE: lib/librte_membership/rte_membership_ht.c:237:
+	struct membership_ht_bucket* buckets = ht->buckets;

ERROR:SPACING: space required before the open parenthesis '('
#5041: FILE: lib/librte_membership/rte_membership_ht.c:260:
+			if(tmp_sig[i] == prim_buckets[i]->sigs[j] &&

WARNING:LONG_LINE: line over 90 characters
#5042: FILE: lib/librte_membership/rte_membership_ht.c:261:
+					prim_buckets[i]->targets[j] != RTE_MEMBERSHIP_NO_MATCH) {

ERROR:SPACING: space required before the open parenthesis '('
#5051: FILE: lib/librte_membership/rte_membership_ht.c:270:
+				if(tmp_sig[i] == sec_buckets[i]->sigs[j] &&

WARNING:LONG_LINE: line over 90 characters
#5052: FILE: lib/librte_membership/rte_membership_ht.c:271:
+						sec_buckets[i]->targets[j] != RTE_MEMBERSHIP_NO_MATCH) {

ERROR:SPACING: spaces required around that '=' (ctx:VxW)
#5053: FILE: lib/librte_membership/rte_membership_ht.c:272:
+					target_id[i]= sec_buckets[i]->targets[j];
 					            ^

WARNING:BRACES: braces {} are not necessary for single statement blocks
#5060: FILE: lib/librte_membership/rte_membership_ht.c:279:
+		if (j == MEMBERSHIP_BUCKET_ENTRIES) {
+			target_id[i] = RTE_MEMBERSHIP_NO_MATCH;
+		}

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5074: FILE: lib/librte_membership/rte_membership_ht.c:293:
+	unsigned i, j;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#5077: FILE: lib/librte_membership/rte_membership_ht.c:296:
+	struct membership_ht_ss* ht = setsum->ss;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#5139: FILE: lib/librte_membership/rte_membership_ht.c:358:
+rte_membership_add_ht(const struct rte_membership_setsum* setsum,

WARNING:LONG_LINE: line over 90 characters
#5140: FILE: lib/librte_membership/rte_membership_ht.c:359:
+							const void* key, MEMBERSHIP_TARGET_TYPE target_id)

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#5140: FILE: lib/librte_membership/rte_membership_ht.c:359:
+							const void* key, MEMBERSHIP_TARGET_TYPE target_id)

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#5144: FILE: lib/librte_membership/rte_membership_ht.c:363:
+	struct membership_ht_ss* ht = setsum->ss;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#5148: FILE: lib/librte_membership/rte_membership_ht.c:367:
+	struct membership_ht_bucket* buckets = ht->buckets;

ERROR:SPACING: space required before the open brace '{'
#5171: FILE: lib/librte_membership/rte_membership_ht.c:390:
+		if(buckets[sec_bucket].targets[i] == RTE_MEMBERSHIP_NO_MATCH){

ERROR:SPACING: space required before the open parenthesis '('
#5171: FILE: lib/librte_membership/rte_membership_ht.c:390:
+		if(buckets[sec_bucket].targets[i] == RTE_MEMBERSHIP_NO_MATCH){

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#5183: FILE: lib/librte_membership/rte_membership_ht.c:402:
+	ret = make_space_bucket (setsum, select_bucket);

WARNING:LONG_LINE: line over 90 characters
#5203: FILE: lib/librte_membership/rte_membership_ht.c:422:
+									 MEMBERSHIP_TARGET_TYPE target_id)

ERROR:SPACING: space required before the open brace '{'
#5229: FILE: lib/librte_membership/rte_membership_ht.c:448:
+	for (i = 0; i < MEMBERSHIP_BUCKET_ENTRIES; i++){

ERROR:SPACING: space required before the open parenthesis '('
#5230: FILE: lib/librte_membership/rte_membership_ht.c:449:
+		if(tmp_sig == buckets[sec_bucket].sigs[i] &&

WARNING:LONG_LINE: line over 90 characters
#5231: FILE: lib/librte_membership/rte_membership_ht.c:450:
+						target_id == buckets[sec_bucket].targets[i]){

ERROR:SPACING: space required before the open brace '{'
#5247: FILE: lib/librte_membership/rte_membership_ht.c:466:
+		for (j = 0; j < MEMBERSHIP_BUCKET_ENTRIES; j++){

WARNING:BRACES: braces {} are not necessary for single statement blocks
#5247: FILE: lib/librte_membership/rte_membership_ht.c:466:
+		for (j = 0; j < MEMBERSHIP_BUCKET_ENTRIES; j++){
+			ht->buckets[i].targets[j] = RTE_MEMBERSHIP_NO_MATCH;
+		}

ERROR:OPEN_BRACE: open brace '{' following struct go on the same line
#5417: FILE: lib/librte_membership/rte_membership_vbf.c:55:
+struct rte_membership_vbf_node
+{

ERROR:OPEN_BRACE: open brace '{' following struct go on the same line
#5424: FILE: lib/librte_membership/rte_membership_vbf.c:62:
+struct rte_membership_vbf
+{

WARNING:LONG_LINE: line over 90 characters
#5438: FILE: lib/librte_membership/rte_membership_vbf.c:76:
+									RTE_CACHE_LINE_SIZE, setsum->socket_id);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#5439: FILE: lib/librte_membership/rte_membership_vbf.c:77:
+	if (new_node == NULL) {
+		return -ENOMEM;
+	}

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 32)
#5449: FILE: lib/librte_membership/rte_membership_vbf.c:87:
+		while(current->next != NULL){
+				current = current->next;

ERROR:SPACING: space required before the open brace '{'
#5449: FILE: lib/librte_membership/rte_membership_vbf.c:87:
+		while(current->next != NULL){

ERROR:SPACING: space required before the open parenthesis '('
#5449: FILE: lib/librte_membership/rte_membership_vbf.c:87:
+		while(current->next != NULL){

WARNING:BRACES: braces {} are not necessary for single statement blocks
#5449: FILE: lib/librte_membership/rte_membership_vbf.c:87:
+		while(current->next != NULL){
+				current = current->next;
+		}

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#5454: FILE: lib/librte_membership/rte_membership_vbf.c:92:
+	}
+	else {

ERROR:SPACING: space required before the open parenthesis '('
#5471: FILE: lib/librte_membership/rte_membership_vbf.c:109:
+	if(vbf == NULL)

WARNING:LONG_LINE: line over 90 characters
#5478: FILE: lib/librte_membership/rte_membership_vbf.c:116:
+			__membership_create_bf((const struct rte_membership_setsum *)setsum);

ERROR:CODE_INDENT: code indent should use tabs where possible
#5481: FILE: lib/librte_membership/rte_membership_vbf.c:119:
+^I^I ^Irte_membership_free_vbf(setsum);$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#5481: FILE: lib/librte_membership/rte_membership_vbf.c:119:
+^I^I ^Irte_membership_free_vbf(setsum);$

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#5504: FILE: lib/librte_membership/rte_membership_vbf.c:142:
+	struct rte_membership_vbf* vbf = setsum->ss;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#5505: FILE: lib/librte_membership/rte_membership_vbf.c:143:
+	struct rte_membership_vbf_node* current = vbf->root;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#5508: FILE: lib/librte_membership/rte_membership_vbf.c:146:
+		struct rte_membership_bf* bloom = current->bf;

ERROR:SPACING: space required before the open brace '{'
#5521: FILE: lib/librte_membership/rte_membership_vbf.c:159:
+		if(i == bloom->num_hashes){

ERROR:SPACING: space required before the open parenthesis '('
#5521: FILE: lib/librte_membership/rte_membership_vbf.c:159:
+		if(i == bloom->num_hashes){

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#5540: FILE: lib/librte_membership/rte_membership_vbf.c:178:
+	struct rte_membership_vbf* vbf = setsum->ss;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#5545: FILE: lib/librte_membership/rte_membership_vbf.c:183:
+		struct rte_membership_vbf_node* current = vbf->root;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#5547: FILE: lib/librte_membership/rte_membership_vbf.c:185:
+			struct rte_membership_bf* bloom = current->bf;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#5586: FILE: lib/librte_membership/rte_membership_vbf.c:224:
+	struct rte_membership_vbf* vbf = setsum->ss;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#5587: FILE: lib/librte_membership/rte_membership_vbf.c:225:
+	struct rte_membership_vbf_node* current = vbf->root;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#5590: FILE: lib/librte_membership/rte_membership_vbf.c:228:
+		struct rte_membership_bf* bloom = current->bf;

ERROR:SPACING: space required before the open brace '{'
#5603: FILE: lib/librte_membership/rte_membership_vbf.c:241:
+		if(i == bloom->num_hashes){

ERROR:SPACING: space required before the open parenthesis '('
#5603: FILE: lib/librte_membership/rte_membership_vbf.c:241:
+		if(i == bloom->num_hashes){

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#5625: FILE: lib/librte_membership/rte_membership_vbf.c:263:
+	struct rte_membership_vbf* vbf = setsum->ss;

ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#5628: FILE: lib/librte_membership/rte_membership_vbf.c:266:
+		uint32_t match_cnt=0;
 		                  ^

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#5631: FILE: lib/librte_membership/rte_membership_vbf.c:269:
+		struct rte_membership_vbf_node* current = vbf->root;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#5633: FILE: lib/librte_membership/rte_membership_vbf.c:271:
+			struct rte_membership_bf* bloom = current->bf;

WARNING:LONG_LINE: line over 90 characters
#5649: FILE: lib/librte_membership/rte_membership_vbf.c:287:
+				target_ids[j*match_per_key+match_cnt] = current->target_id;

WARNING:LONG_LINE: line over 90 characters
#5665: FILE: lib/librte_membership/rte_membership_vbf.c:303:
+							const void *key, MEMBERSHIP_TARGET_TYPE target_id)

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#5673: FILE: lib/librte_membership/rte_membership_vbf.c:311:
+	struct rte_membership_vbf* vbf = setsum->ss;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#5674: FILE: lib/librte_membership/rte_membership_vbf.c:312:
+	struct rte_membership_vbf_node* current = vbf->root;

ERROR:SPACING: space required before the open parenthesis '('
#5699: FILE: lib/librte_membership/rte_membership_vbf.c:337:
+	if(bloom == NULL) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#5699: FILE: lib/librte_membership/rte_membership_vbf.c:337:
+	if(bloom == NULL) {
+		return -ENOMEM;
+	}

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#5722: FILE: lib/librte_membership/rte_membership_vbf.c:360:
+	struct rte_membership_vbf* vbf = setsum->ss;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#5724: FILE: lib/librte_membership/rte_membership_vbf.c:362:
+		struct rte_membership_vbf_node* current = vbf->root;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#5725: FILE: lib/librte_membership/rte_membership_vbf.c:363:
+		struct rte_membership_vbf_node* next;

ERROR:SPACING: space required before the open brace '{'
#5728: FILE: lib/librte_membership/rte_membership_vbf.c:366:
+			if(current->bf != NULL){

ERROR:SPACING: space required before the open parenthesis '('
#5728: FILE: lib/librte_membership/rte_membership_vbf.c:366:
+			if(current->bf != NULL){

WARNING:MISSING_EOF_NEWLINE: adding a line without newline at end of file
#5753: FILE: lib/librte_membership/rte_membership_vbf.c:391:
+}

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#5955: FILE: test/test/test_membership.c:58:
+static ^Istruct rte_membership_parameters params = {$

WARNING:TYPO_SPELLING: 'relevent' may be misspelled - perhaps 'relevant'?
#5961: FILE: test/test/test_membership.c:64:
+	    /*num_target and false_postive_rate only relevent with BF based set summary*/

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#5970: FILE: test/test/test_membership.c:73:
+#define RETURN_IF_ERROR(cond, str, ...) do {				\
+	if (cond) {							\
+		printf("ERROR line %d: " str "
", __LINE__, ##__VA_ARGS__); \
+		return -1;						\
+	}								\
+} while(0)

ERROR:SPACING: space required before the open parenthesis '('
#5975: FILE: test/test/test_membership.c:78:
+} while(0)

ERROR:SPACING: spaces required around that '==' (ctx:VxV)
#5998: FILE: test/test/test_membership.c:101:
+	if(setsum_ht==NULL || setsum_cache == NULL || setsum_bf == NULL ||
 	            ^

ERROR:SPACING: space required before the open parenthesis '('
#5998: FILE: test/test/test_membership.c:101:
+	if(setsum_ht==NULL || setsum_cache == NULL || setsum_bf == NULL ||

ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#6010: FILE: test/test/test_membership.c:113:
+	uint32_t key=KEY;
 	            ^

ERROR:SPACING: space required before the open brace '{'
#6044: FILE: test/test/test_membership.c:147:
+	if(ret_ht < 0 || ret_cache < 0 || ret_bf < 0 || ret_vbf < 0){

ERROR:SPACING: space required before the open parenthesis '('
#6044: FILE: test/test/test_membership.c:147:
+	if(ret_ht < 0 || ret_cache < 0 || ret_bf < 0 || ret_vbf < 0){

ERROR:POINTER_LOCATION: "(foo**)" should be "(foo **)"
#6056: FILE: test/test/test_membership.c:159:
+	ret_ht = rte_membership_lookup_bulk(setsum_ht, (const void**)(key_array),

ERROR:POINTER_LOCATION: "(foo**)" should be "(foo **)"
#6059: FILE: test/test/test_membership.c:162:
+	ret_cache = rte_membership_lookup_bulk(setsum_cache, (const void**)(key_array),

ERROR:SPACING: space required after that ',' (ctx:VxV)
#6060: FILE: test/test/test_membership.c:163:
+			num_key_cache,target_ids_cache);
 			             ^

ERROR:POINTER_LOCATION: "(foo**)" should be "(foo **)"
#6062: FILE: test/test/test_membership.c:165:
+	ret_bf = rte_membership_lookup_bulk(setsum_bf, (const void**)(key_array),

ERROR:POINTER_LOCATION: "(foo**)" should be "(foo **)"
#6065: FILE: test/test/test_membership.c:168:
+	ret_vbf = rte_membership_lookup_bulk(setsum_vbf, (const void**)(key_array),

ERROR:SPACING: space required after that close brace '}'
#6115: FILE: test/test/test_membership.c:218:
+	MEMBERSHIP_TARGET_TYPE target_ids_ht_m[2][32] = {{0}};

ERROR:SPACING: space required after that close brace '}'
#6116: FILE: test/test/test_membership.c:219:
+	MEMBERSHIP_TARGET_TYPE target_ids_vbf_m[2][32] = {{0}};

ERROR:SPACING: space required after that close brace '}'
#6117: FILE: test/test/test_membership.c:220:
+	MEMBERSHIP_TARGET_TYPE target_ids_bf_m[2][32] = {{0}};

ERROR:SPACING: space required after that close brace '}'
#6118: FILE: test/test/test_membership.c:221:
+	MEMBERSHIP_TARGET_TYPE target_ids_cache_m[2][32] = {{0}};

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#6121: FILE: test/test/test_membership.c:224:
+	uint32_t* key_array[8];

ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#6160: FILE: test/test/test_membership.c:263:
+	for (i=0; i < (uint32_t)ret_ht; i++) {
 	      ^

WARNING:LONG_LINE: line over 90 characters
#6190: FILE: test/test/test_membership.c:293:
+		printf("cache match count %d %d
", match_count_cache[0], match_count_cache[1]);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#6198: FILE: test/test/test_membership.c:301:
+		for (j = 0; j < match_count_ht[i]; j++) {
+			printf("%d,", target_ids_ht_m[i][j]);
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#6202: FILE: test/test/test_membership.c:305:
+		for (j = 0; j < match_count_vbf[i]; j++) {
+			printf("%d,", target_ids_vbf_m[i][j]);
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#6206: FILE: test/test/test_membership.c:309:
+		for (j = 0; j < match_count_cache[i]; j++) {
+			printf("%d,", target_ids_cache_m[i][j]);
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#6210: FILE: test/test/test_membership.c:313:
+		for (j = 0; j < match_count_bf[i]; j++) {
+			printf("%d,", target_ids_bf_m[i][j]);
+		}

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#6224: FILE: test/test/test_membership.c:327:
+	unsigned i, j;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#6225: FILE: test/test/test_membership.c:328:
+	unsigned added_keys, average_keys_added = 0;

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 175 errors, 84 warnings, 6086 lines checked
Previous message: [dpdk-test-report] |FAILURE| pw24660 [PATCH v2 04/25] bnxt: support lack of huge pages
Next message: [dpdk-test-report] |FAILURE| pw24662 [PATCH v2 06/25] bnxt: add tunneling support
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list