[dpdk-test-report] |WARNING| pw24854 [PATCH 13/13] cryptodev: add AEAD parameters in crypto operation

checkpatch at dpdk.org checkpatch at dpdk.org
Sun May 28 23:06:57 CEST 2017
Previous message: [dpdk-test-report] |SUCCESS| pw24853 [PATCH 12/13] cryptodev: aad AEAD specific data
Next message: [dpdk-test-report] |SUCCESS| pw24796 [PATCH 2/7] net/qede: refactoring multi-queue implementation
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/24854

_coding style issues_


WARNING:TYPO_SPELLING: 'an union' may be misspelled - perhaps 'a union'?
#18: 
This structure is within an union with the cipher

WARNING:LONG_LINE_COMMENT: line over 90 characters
#291: FILE: lib/librte_cryptodev/rte_crypto_sym.h:568:
+					 /**< Starting point for cipher processing, specified

WARNING:LONG_LINE_COMMENT: line over 90 characters
#292: FILE: lib/librte_cryptodev/rte_crypto_sym.h:569:
+					  * as number of bytes from start of data in the source

WARNING:LONG_LINE_COMMENT: line over 90 characters
#293: FILE: lib/librte_cryptodev/rte_crypto_sym.h:570:
+					  * buffer. The result of the cipher operation will be

WARNING:LONG_LINE_COMMENT: line over 90 characters
#294: FILE: lib/librte_cryptodev/rte_crypto_sym.h:571:
+					  * written back into the output buffer starting at

WARNING:LONG_LINE_COMMENT: line over 90 characters
#304: FILE: lib/librte_cryptodev/rte_crypto_sym.h:581:
+					 /**< The message length, in bytes, of the source buffer

WARNING:LONG_LINE_COMMENT: line over 90 characters
#306: FILE: lib/librte_cryptodev/rte_crypto_sym.h:583:
+					  * computed. This must be a multiple of the block size

WARNING:LONG_LINE_COMMENT: line over 90 characters
#307: FILE: lib/librte_cryptodev/rte_crypto_sym.h:584:
+					  * if a block cipher is being used. This is also the

WARNING:LONG_LINE_COMMENT: line over 90 characters
#311: FILE: lib/librte_cryptodev/rte_crypto_sym.h:588:
+					  * In the case of CCM @ref RTE_CRYPTO_AUTH_AES_CCM,

WARNING:LONG_LINE_COMMENT: line over 90 characters
#312: FILE: lib/librte_cryptodev/rte_crypto_sym.h:589:
+					  * this value should not include the length of the

WARNING:LONG_LINE_COMMENT: line over 90 characters
#313: FILE: lib/librte_cryptodev/rte_crypto_sym.h:590:
+					  * padding or the length of the MAC; the driver will

WARNING:LONG_LINE_COMMENT: line over 90 characters
#314: FILE: lib/librte_cryptodev/rte_crypto_sym.h:591:
+					  * compute the actual number of bytes over which the

WARNING:LONG_LINE_COMMENT: line over 90 characters
#315: FILE: lib/librte_cryptodev/rte_crypto_sym.h:592:
+					  * encryption will occur, which will include these

WARNING:LONG_LINE_COMMENT: line over 90 characters
#319: FILE: lib/librte_cryptodev/rte_crypto_sym.h:596:
+					  * For AES-GMAC @ref RTE_CRYPTO_AUTH_AES_GMAC, this

WARNING:LONG_LINE_COMMENT: line over 90 characters
#334: FILE: lib/librte_cryptodev/rte_crypto_sym.h:611:
+					 /**< Starting point for hash processing, specified as

WARNING:LONG_LINE_COMMENT: line over 90 characters
#339: FILE: lib/librte_cryptodev/rte_crypto_sym.h:616:
+					  * For CCM and GCM modes of operation, this field is

WARNING:LONG_LINE_COMMENT: line over 90 characters
#343: FILE: lib/librte_cryptodev/rte_crypto_sym.h:620:
+					  * @note For AES-GMAC (@ref RTE_CRYPTO_AUTH_AES_GMAC)

WARNING:LONG_LINE_COMMENT: line over 90 characters
#344: FILE: lib/librte_cryptodev/rte_crypto_sym.h:621:
+					  * mode of operation, this field is set to 0. aad data

WARNING:LONG_LINE_COMMENT: line over 90 characters
#359: FILE: lib/librte_cryptodev/rte_crypto_sym.h:636:
+					  * For CCM and GCM modes of operation, this field is

WARNING:LONG_LINE_COMMENT: line over 90 characters
#360: FILE: lib/librte_cryptodev/rte_crypto_sym.h:637:
+					  * ignored. The field @ref aad field should be set

WARNING:LONG_LINE_COMMENT: line over 90 characters
#364: FILE: lib/librte_cryptodev/rte_crypto_sym.h:641:
+					  * For AES-GMAC @ref RTE_CRYPTO_AUTH_AES_GMAC mode

WARNING:LONG_LINE_COMMENT: line over 90 characters
#378: FILE: lib/librte_cryptodev/rte_crypto_sym.h:655:
+					/**< This points to the location where the digest result

WARNING:LONG_LINE_COMMENT: line over 90 characters
#379: FILE: lib/librte_cryptodev/rte_crypto_sym.h:656:
+					 * should be inserted (in the case of digest generation)

WARNING:LONG_LINE_COMMENT: line over 90 characters
#380: FILE: lib/librte_cryptodev/rte_crypto_sym.h:657:
+					 * or where the purported digest exists (in the case of

WARNING:LONG_LINE_COMMENT: line over 90 characters
#383: FILE: lib/librte_cryptodev/rte_crypto_sym.h:660:
+					 * At session creation time, the client specified the

WARNING:LONG_LINE_COMMENT: line over 90 characters
#384: FILE: lib/librte_cryptodev/rte_crypto_sym.h:661:
+					 * digest result length with the digest_length member

WARNING:LONG_LINE_COMMENT: line over 90 characters
#385: FILE: lib/librte_cryptodev/rte_crypto_sym.h:662:
+					 * of the @ref rte_crypto_auth_xform structure. For

WARNING:LONG_LINE_COMMENT: line over 90 characters
#386: FILE: lib/librte_cryptodev/rte_crypto_sym.h:663:
+					 * physical crypto devices the caller must allocate at

WARNING:LONG_LINE_COMMENT: line over 90 characters
#387: FILE: lib/librte_cryptodev/rte_crypto_sym.h:664:
+					 * least digest_length of physically contiguous memory

WARNING:LONG_LINE_COMMENT: line over 90 characters
#403: FILE: lib/librte_cryptodev/rte_crypto_sym.h:680:
+					/**< Pointer to Additional Authenticated Data (AAD)

WARNING:LONG_LINE_COMMENT: line over 90 characters
#404: FILE: lib/librte_cryptodev/rte_crypto_sym.h:681:
+					 * needed for authenticated cipher mechanisms (CCM and

WARNING:LONG_LINE_COMMENT: line over 90 characters
#407: FILE: lib/librte_cryptodev/rte_crypto_sym.h:684:
+					 * The length of the data pointed to by this field is

WARNING:LONG_LINE_COMMENT: line over 90 characters
#409: FILE: lib/librte_cryptodev/rte_crypto_sym.h:686:
+					 * rte_crypto_auth_xform structure as part of the @ref

WARNING:LONG_LINE_COMMENT: line over 90 characters
#411: FILE: lib/librte_cryptodev/rte_crypto_sym.h:688:
+					 * This length must not exceed 65535 (2^16-1) bytes.

WARNING:LONG_LINE_COMMENT: line over 90 characters
#413: FILE: lib/librte_cryptodev/rte_crypto_sym.h:690:
+					 * Specifically for CCM (@ref RTE_CRYPTO_AUTH_AES_CCM),

WARNING:LONG_LINE_COMMENT: line over 90 characters
#416: FILE: lib/librte_cryptodev/rte_crypto_sym.h:693:
+					 * - the nonce should be written starting at an offset

WARNING:LONG_LINE_COMMENT: line over 90 characters
#417: FILE: lib/librte_cryptodev/rte_crypto_sym.h:694:
+					 * of one byte into the array, leaving room for the

WARNING:LONG_LINE_COMMENT: line over 90 characters
#418: FILE: lib/librte_cryptodev/rte_crypto_sym.h:695:
+					 * implementation to write in the flags to the first

WARNING:LONG_LINE_COMMENT: line over 90 characters
#421: FILE: lib/librte_cryptodev/rte_crypto_sym.h:698:
+					 * - the additional  authentication data itself should

WARNING:LONG_LINE_COMMENT: line over 90 characters
#422: FILE: lib/librte_cryptodev/rte_crypto_sym.h:699:
+					 * be written starting at an offset of 18 bytes into

WARNING:LONG_LINE_COMMENT: line over 90 characters
#423: FILE: lib/librte_cryptodev/rte_crypto_sym.h:700:
+					 * the array, leaving room for the length encoding in

WARNING:LONG_LINE_COMMENT: line over 90 characters
#426: FILE: lib/librte_cryptodev/rte_crypto_sym.h:703:
+					 * - the array should be big enough to hold the above

WARNING:LONG_LINE_COMMENT: line over 90 characters
#427: FILE: lib/librte_cryptodev/rte_crypto_sym.h:704:
+					 *  fields, plus any padding to round this up to the

WARNING:LONG_LINE_COMMENT: line over 90 characters
#431: FILE: lib/librte_cryptodev/rte_crypto_sym.h:708:
+					 * Finally, for GCM (@ref RTE_CRYPTO_AUTH_AES_GCM), the

WARNING:LONG_LINE_COMMENT: line over 90 characters
#435: FILE: lib/librte_cryptodev/rte_crypto_sym.h:712:
+					 * - the array must be big enough to hold the AAD, plus

WARNING:LONG_LINE_COMMENT: line over 90 characters
#436: FILE: lib/librte_cryptodev/rte_crypto_sym.h:713:
+					 * any space to round this up to the nearest multiple

WARNING:LONG_LINE_COMMENT: line over 90 characters
#440: FILE: lib/librte_cryptodev/rte_crypto_sym.h:717:
+					 * For AES-GMAC (@ref RTE_CRYPTO_AUTH_AES_GMAC) mode of

WARNING:LONG_LINE_COMMENT: line over 90 characters
#441: FILE: lib/librte_cryptodev/rte_crypto_sym.h:718:
+					 * operation, this field is used to pass plaintext.

total: 0 errors, 48 warnings, 415 lines checked
Previous message: [dpdk-test-report] |SUCCESS| pw24853 [PATCH 12/13] cryptodev: aad AEAD specific data
Next message: [dpdk-test-report] |SUCCESS| pw24796 [PATCH 2/7] net/qede: refactoring multi-queue implementation
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list