[dpdk-test-report] |WARNING| pw31093 [PATCH] eal: force IOVA PA mode if KNI module inserted
checkpatch at dpdk.org
checkpatch at dpdk.org
Thu Nov 2 05:00:34 CET 2017
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31093
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#46:
> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#82: FILE: drivers/bus/pci/linux/pci.c:589:
+ bool has_kni;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#88: FILE: drivers/bus/pci/linux/pci.c:595:
+ has_kni = rte_eal_check_module("rte_kni");$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#97: FILE: drivers/bus/pci/linux/pci.c:603:
+ if (has_iova_va && !is_bound_uio && !has_kni && !is_vfio_noiommu_enabled)$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#97: FILE: drivers/bus/pci/linux/pci.c:603:
+ if (has_iova_va && !is_bound_uio && !has_kni && !is_vfio_noiommu_enabled)
return RTE_IOVA_VA;
ERROR:CODE_INDENT: code indent should use tabs where possible
#105: FILE: drivers/bus/pci/linux/pci.c:612:
+ if (has_kni)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#105: FILE: drivers/bus/pci/linux/pci.c:612:
+ if (has_kni)$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23)
#105: FILE: drivers/bus/pci/linux/pci.c:612:
+ if (has_kni)
+ RTE_LOG(WARNING, EAL, "Some devices want iova as va but pa will be used because.."
ERROR:CODE_INDENT: code indent should use tabs where possible
#106: FILE: drivers/bus/pci/linux/pci.c:613:
+ RTE_LOG(WARNING, EAL, "Some devices want iova as va but pa will be used because.."$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#106: FILE: drivers/bus/pci/linux/pci.c:613:
+ RTE_LOG(WARNING, EAL, "Some devices want iova as va but pa will be used because.."$
ERROR:CODE_INDENT: code indent should use tabs where possible
#107: FILE: drivers/bus/pci/linux/pci.c:614:
+ "KNI module inserted
");$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#107: FILE: drivers/bus/pci/linux/pci.c:614:
+ "KNI module inserted
");$
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 4 errors, 9 warnings, 30 lines checked
More information about the test-report
mailing list