[dpdk-test-report] |WARNING| pw31172 [PATCH v2] igb_uio: add config option to control reset

checkpatch at dpdk.org checkpatch at dpdk.org
Sat Nov 4 11:08:35 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31172

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#142: 
> different versions of the kernel igb_uio module to support different NICs.

ERROR:DIFF_IN_COMMIT_MSG: Avoid using diff content in the commit message - patch(1) might not work
#202: 
@@ -360,7 +368,8 @@ igbuio_pci_release(struct uio_info *info, struct inode

ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?)
#234: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:133:
*pdev)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#240: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:139:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x168a) }, /* 57800 */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#241: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:140:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x164f) }, /* 57711 */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#242: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:141:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x168e) }, /* 57810 */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#243: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:142:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x163d) }, /* 57811 */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#244: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:143:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x168d) }, /* 57840_OBS */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#245: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:144:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16a1) }, /* 57840_4_10 */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#246: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:145:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16a2) }, /* 57840_2_20 */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#247: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:146:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16ae) }, /* 57810_MF */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#248: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:147:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x163e) }, /* 57811_MF */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#249: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:148:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16a4) }, /* 57840_MF */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#250: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:149:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16a9) }, /* 57800_VF */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#251: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:150:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16af) }, /* 57810_VF */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#252: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:151:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x163f) }, /* 57811_VF */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#253: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:152:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16ad) }, /* 57840_VF */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#254: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:153:
+       { 0 },$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#268: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:353:
+       if (pci_match_id(no_reset_pci_tbl, pdev))$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#268: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:353:
+       if (pci_match_id(no_reset_pci_tbl, pdev))
+               return 1;

ERROR:CODE_INDENT: code indent should use tabs where possible
#269: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:354:
+               return 1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#269: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:354:
+               return 1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#271: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:356:
+       return 0;$

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 4 errors, 20 warnings, 36 lines checked


More information about the test-report mailing list