[dpdk-test-report] |WARNING| pw31400 [PATCH 12/53] net/sfc/base: precheck and verify flash writes

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Nov 16 09:05:29 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31400

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#51: FILE: drivers/net/sfc/base/ef10_impl.h:453:
+extern	__checkReturn		efx_rc_t

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#178: FILE: drivers/net/sfc/base/efx_nvram.c:313:
+	if ((rc = envop->envo_type_to_partn(enp, type, &partn)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#183: FILE: drivers/net/sfc/base/efx_nvram.c:318:
+	if ((rc = envop->envo_partn_read_backup(enp, partn, offset,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#187: FILE: drivers/net/sfc/base/efx_nvram.c:322:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#194: FILE: drivers/net/sfc/base/efx_nvram.c:329:
+	return (rc);

total: 4 errors, 0 warnings, 1 checks, 137 lines checked


More information about the test-report mailing list