[dpdk-test-report] |WARNING| pw31414 [PATCH 32/53] net/sfc/base: improve names for RXQ descriptor counts

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Nov 16 09:10:41 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31414

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ndescs < EFX_RXQ_MINNDESCS'
#151: FILE: drivers/net/sfc/base/ef10_rx.c:963:
+	if (!ISP2(ndescs) ||
+	    (ndescs < EFX_RXQ_MINNDESCS) || (ndescs > EFX_RXQ_MAXNDESCS)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ndescs > EFX_RXQ_MAXNDESCS'
#151: FILE: drivers/net/sfc/base/ef10_rx.c:963:
+	if (!ISP2(ndescs) ||
+	    (ndescs < EFX_RXQ_MINNDESCS) || (ndescs > EFX_RXQ_MAXNDESCS)) {

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#161: FILE: drivers/net/sfc/base/ef10_rx.c:1024:
+	if ((rc = efx_mcdi_init_rxq(enp, ndescs, eep->ee_index, label, index,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#283: FILE: drivers/net/sfc/base/efx_rx.c:646:
+	if ((rc = erxop->erxo_qcreate(enp, index, label, type, esmp, ndescs, id,

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ndescs < EFX_RXQ_MINNDESCS'
#337: FILE: drivers/net/sfc/base/efx_rx.c:1328:
+	if (!ISP2(ndescs) ||
+	    (ndescs < EFX_RXQ_MINNDESCS) || (ndescs > EFX_RXQ_MAXNDESCS)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ndescs > EFX_RXQ_MAXNDESCS'
#337: FILE: drivers/net/sfc/base/efx_rx.c:1328:
+	if (!ISP2(ndescs) ||
+	    (ndescs < EFX_RXQ_MINNDESCS) || (ndescs > EFX_RXQ_MAXNDESCS)) {

total: 2 errors, 0 warnings, 4 checks, 286 lines checked


More information about the test-report mailing list