[dpdk-test-report] |WARNING| pw31460 [PATCH] virtio: add new driver for crypto devices

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Nov 17 18:15:20 CET 2017
Previous message: [dpdk-test-report] |FAILURE| pw31458 [PATCH v2 6/6] net/ixgbe: Enable port representor PMD and broker for ixgbe PMD driver
Next message: [dpdk-test-report] |SUCCESS| pw31461 [PATCH] test/mempool: improve default mempool ops selection
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31460

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#21: 
Currently supporting symmetric algorithms(cipher only or chained algorithms),

WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#147: FILE: MAINTAINERS:523:
+M: Jay Zhou <jianjay.zhou at huawei.com>

WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#148: FILE: MAINTAINERS:524:
+F: drivers/crypto/virtio/

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#277: FILE: drivers/crypto/virtio/virtio_crypto.h:12:
+ *    ^I notice, this list of conditions and the following disclaimer.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#279: FILE: drivers/crypto/virtio/virtio_crypto.h:14:
+ *    ^I notice, this list of conditions and the following disclaimer in$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#280: FILE: drivers/crypto/virtio/virtio_crypto.h:15:
+ *    ^I the documentation and/or other materials provided with the$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#281: FILE: drivers/crypto/virtio/virtio_crypto.h:16:
+ *    ^I distribution.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#284: FILE: drivers/crypto/virtio/virtio_crypto.h:19:
+ *    ^I from this software without specific prior written permission.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#735: FILE: drivers/crypto/virtio/virtio_crypto_algs.h:12:
+ *    ^I notice, this list of conditions and the following disclaimer.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#737: FILE: drivers/crypto/virtio/virtio_crypto_algs.h:14:
+ *    ^I notice, this list of conditions and the following disclaimer in$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#738: FILE: drivers/crypto/virtio/virtio_crypto_algs.h:15:
+ *    ^I the documentation and/or other materials provided with the$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#739: FILE: drivers/crypto/virtio/virtio_crypto_algs.h:16:
+ *    ^I distribution.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#742: FILE: drivers/crypto/virtio/virtio_crypto_algs.h:19:
+ *    ^I from this software without specific prior written permission.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#797: FILE: drivers/crypto/virtio/virtio_cryptodev.c:12:
+ *    ^I notice, this list of conditions and the following disclaimer.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#799: FILE: drivers/crypto/virtio/virtio_cryptodev.c:14:
+ *    ^I notice, this list of conditions and the following disclaimer in$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#800: FILE: drivers/crypto/virtio/virtio_cryptodev.c:15:
+ *    ^I the documentation and/or other materials provided with the$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#801: FILE: drivers/crypto/virtio/virtio_cryptodev.c:16:
+ *    ^I distribution.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#804: FILE: drivers/crypto/virtio/virtio_cryptodev.c:19:
+ *    ^I from this software without specific prior written permission.$

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#871: FILE: drivers/crypto/virtio/virtio_cryptodev.c:86:
+static unsigned virtio_crypto_sym_get_session_private_size(

ERROR:SPACING: space prohibited after that open parenthesis '('
#873: FILE: drivers/crypto/virtio/virtio_cryptodev.c:88:
+static void virtio_crypto_sym_clear_session(		struct rte_cryptodev *dev,

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1090: FILE: drivers/crypto/virtio/virtio_cryptodev.c:305:
+		return -1;
+	} else {

ERROR:OPEN_BRACE: open brace '{' following function declarations go on the next line
#1100: FILE: drivers/crypto/virtio/virtio_cryptodev.c:315:
+void virtio_crypto_queue_release(struct virtqueue *vq) {

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1300: FILE: drivers/crypto/virtio/virtio_cryptodev.c:515:
+	unsigned i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1651: FILE: drivers/crypto/virtio/virtio_cryptodev.c:866:
+static unsigned virtio_crypto_sym_get_session_private_size(

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1733: FILE: drivers/crypto/virtio/virtio_cryptodev.c:948:
+	if (session == NULL) {
+		PMD_SESSION_LOG(ERR, "Invalid session parameter");
+	}

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1748: FILE: drivers/crypto/virtio/virtio_cryptodev.c:963:
+	/*
+	* malloc memory to store information of ctrl request op,

WARNING:LONG_LINE: line over 90 characters
#1909: FILE: drivers/crypto/virtio/virtio_cryptodev.c:1124:
+static int virtio_crypto_sym_pad_cipher_param(struct virtio_crypto_cipher_session_para *para,

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'ctrl->u.sym_create_session.u.chain.para.u.mac_param.auth_key_len'
#2116: FILE: drivers/crypto/virtio/virtio_cryptodev.c:1331:
+			ctrl->u.sym_create_session.u.chain.para.u.mac_param.
+				auth_key_len = (uint32_t)auth_xform->key.length;

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'ctrl->u.sym_create_session.u.chain.para.u.mac_param.hash_result_len'
#2118: FILE: drivers/crypto/virtio/virtio_cryptodev.c:1333:
+			ctrl->u.sym_create_session.u.chain.para.u.mac_param.
+				hash_result_len = auth_xform->digest_length;

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'ctrl->u.sym_create_session.u.chain.para.u.hash_param.hash_result_len'
#2125: FILE: drivers/crypto/virtio/virtio_cryptodev.c:1340:
+			ctrl->u.sym_create_session.u.chain.para.u.hash_param.
+				hash_result_len = auth_xform->digest_length;

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#2345: FILE: drivers/crypto/virtio/virtio_cryptodev.h:12:
+ *    ^I notice, this list of conditions and the following disclaimer.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#2347: FILE: drivers/crypto/virtio/virtio_cryptodev.h:14:
+ *    ^I notice, this list of conditions and the following disclaimer in$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#2348: FILE: drivers/crypto/virtio/virtio_cryptodev.h:15:
+ *    ^I the documentation and/or other materials provided with the$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#2349: FILE: drivers/crypto/virtio/virtio_cryptodev.h:16:
+ *    ^I distribution.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#2352: FILE: drivers/crypto/virtio/virtio_cryptodev.h:19:
+ *    ^I from this software without specific prior written permission.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#2438: FILE: drivers/crypto/virtio/virtio_logs.h:12:
+ *    ^I notice, this list of conditions and the following disclaimer.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#2440: FILE: drivers/crypto/virtio/virtio_logs.h:14:
+ *    ^I notice, this list of conditions and the following disclaimer in$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#2441: FILE: drivers/crypto/virtio/virtio_logs.h:15:
+ *    ^I the documentation and/or other materials provided with the$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#2442: FILE: drivers/crypto/virtio/virtio_logs.h:16:
+ *    ^I distribution.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#2445: FILE: drivers/crypto/virtio/virtio_logs.h:19:
+ *    ^I from this software without specific prior written permission.$

WARNING:MISSING_EOF_NEWLINE: adding a line without newline at end of file
#2502: FILE: drivers/crypto/virtio/virtio_logs.h:76:
+#endif /* _VIRTIO_LOGS_H_ */

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#2521: FILE: drivers/crypto/virtio/virtio_pci.c:12:
+ *    ^I notice, this list of conditions and the following disclaimer.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#2523: FILE: drivers/crypto/virtio/virtio_pci.c:14:
+ *    ^I notice, this list of conditions and the following disclaimer in$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#2524: FILE: drivers/crypto/virtio/virtio_pci.c:15:
+ *    ^I the documentation and/or other materials provided with the$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#2525: FILE: drivers/crypto/virtio/virtio_pci.c:16:
+ *    ^I distribution.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#2528: FILE: drivers/crypto/virtio/virtio_pci.c:19:
+ *    ^I from this software without specific prior written permission.$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 21)
#3208: FILE: drivers/crypto/virtio/virtio_pci.c:699:
+		if (dev->kdrv == RTE_KDRV_UNKNOWN &&
[...]
+		     PMD_INIT_LOG(INFO,

WARNING:TABSTOP: Statements should start on a tabstop
#3214: FILE: drivers/crypto/virtio/virtio_pci.c:705:
+			 return -1;

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#3241: FILE: drivers/crypto/virtio/virtio_pci.h:12:
+ *    ^I notice, this list of conditions and the following disclaimer.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#3243: FILE: drivers/crypto/virtio/virtio_pci.h:14:
+ *    ^I notice, this list of conditions and the following disclaimer in$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#3244: FILE: drivers/crypto/virtio/virtio_pci.h:15:
+ *    ^I the documentation and/or other materials provided with the$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#3245: FILE: drivers/crypto/virtio/virtio_pci.h:16:
+ *    ^I distribution.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#3248: FILE: drivers/crypto/virtio/virtio_pci.h:19:
+ *    ^I from this software without specific prior written permission.$

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_crypto_hw *' should also have an identifier name
#3498: FILE: drivers/crypto/virtio/virtio_pci.h:269:
+void vtpci_reset_crypto(struct virtio_crypto_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_crypto_hw *' should also have an identifier name
#3500: FILE: drivers/crypto/virtio/virtio_pci.h:271:
+void vtpci_reinit_complete_crypto(struct virtio_crypto_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_crypto_hw *' should also have an identifier name
#3502: FILE: drivers/crypto/virtio/virtio_pci.h:273:
+uint8_t vtpci_get_status_crypto(struct virtio_crypto_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_crypto_hw *' should also have an identifier name
#3503: FILE: drivers/crypto/virtio/virtio_pci.h:274:
+void vtpci_set_status_crypto(struct virtio_crypto_hw *, uint8_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint8_t' should also have an identifier name
#3503: FILE: drivers/crypto/virtio/virtio_pci.h:274:
+void vtpci_set_status_crypto(struct virtio_crypto_hw *, uint8_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_crypto_hw *' should also have an identifier name
#3505: FILE: drivers/crypto/virtio/virtio_pci.h:276:
+uint64_t vtpci_negotiate_features_crypto(struct virtio_crypto_hw *, uint64_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint64_t' should also have an identifier name
#3505: FILE: drivers/crypto/virtio/virtio_pci.h:276:
+uint64_t vtpci_negotiate_features_crypto(struct virtio_crypto_hw *, uint64_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_crypto_hw *' should also have an identifier name
#3507: FILE: drivers/crypto/virtio/virtio_pci.h:278:
+void vtpci_write_dev_config_crypto(struct virtio_crypto_hw *, size_t, const void *, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'size_t' should also have an identifier name
#3507: FILE: drivers/crypto/virtio/virtio_pci.h:278:
+void vtpci_write_dev_config_crypto(struct virtio_crypto_hw *, size_t, const void *, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'const void *' should also have an identifier name
#3507: FILE: drivers/crypto/virtio/virtio_pci.h:278:
+void vtpci_write_dev_config_crypto(struct virtio_crypto_hw *, size_t, const void *, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name
#3507: FILE: drivers/crypto/virtio/virtio_pci.h:278:
+void vtpci_write_dev_config_crypto(struct virtio_crypto_hw *, size_t, const void *, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_crypto_hw *' should also have an identifier name
#3509: FILE: drivers/crypto/virtio/virtio_pci.h:280:
+void vtpci_read_dev_config_crypto(struct virtio_crypto_hw *, uint64_t, void *, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint64_t' should also have an identifier name
#3509: FILE: drivers/crypto/virtio/virtio_pci.h:280:
+void vtpci_read_dev_config_crypto(struct virtio_crypto_hw *, uint64_t, void *, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name
#3509: FILE: drivers/crypto/virtio/virtio_pci.h:280:
+void vtpci_read_dev_config_crypto(struct virtio_crypto_hw *, uint64_t, void *, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name
#3509: FILE: drivers/crypto/virtio/virtio_pci.h:280:
+void vtpci_read_dev_config_crypto(struct virtio_crypto_hw *, uint64_t, void *, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_crypto_hw *' should also have an identifier name
#3511: FILE: drivers/crypto/virtio/virtio_pci.h:282:
+uint8_t vtpci_isr_crypto(struct virtio_crypto_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_crypto_hw *' should also have an identifier name
#3513: FILE: drivers/crypto/virtio/virtio_pci.h:284:
+uint16_t vtpci_irq_config(struct virtio_crypto_hw *, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name
#3513: FILE: drivers/crypto/virtio/virtio_pci.h:284:
+uint16_t vtpci_irq_config(struct virtio_crypto_hw *, uint16_t);

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#3533: FILE: drivers/crypto/virtio/virtio_ring.h:12:
+ *    ^I notice, this list of conditions and the following disclaimer.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#3535: FILE: drivers/crypto/virtio/virtio_ring.h:14:
+ *    ^I notice, this list of conditions and the following disclaimer in$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#3536: FILE: drivers/crypto/virtio/virtio_ring.h:15:
+ *    ^I the documentation and/or other materials provided with the$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#3537: FILE: drivers/crypto/virtio/virtio_ring.h:16:
+ *    ^I distribution.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#3540: FILE: drivers/crypto/virtio/virtio_ring.h:19:
+ *    ^I from this software without specific prior written permission.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#3708: FILE: drivers/crypto/virtio/virtio_rxtx.c:12:
+ *    ^I notice, this list of conditions and the following disclaimer.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#3710: FILE: drivers/crypto/virtio/virtio_rxtx.c:14:
+ *    ^I notice, this list of conditions and the following disclaimer in$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#3711: FILE: drivers/crypto/virtio/virtio_rxtx.c:15:
+ *    ^I the documentation and/or other materials provided with the$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#3712: FILE: drivers/crypto/virtio/virtio_rxtx.c:16:
+ *    ^I distribution.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#3715: FILE: drivers/crypto/virtio/virtio_rxtx.c:19:
+ *    ^I from this software without specific prior written permission.$

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'ctrl->u.sym_create_session.u.chain.para.u.hash_param.hash_result_len'
#3917: FILE: drivers/crypto/virtio/virtio_rxtx.c:221:
+				ctrl->u.sym_create_session.u.chain.para.u.hash_param.
+				hash_result_len;

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'ctrl->u.sym_create_session.u.chain.para.u.mac_param.hash_result_len'
#3922: FILE: drivers/crypto/virtio/virtio_rxtx.c:226:
+				ctrl->u.sym_create_session.u.chain.para.u.mac_param.
+				hash_result_len;

WARNING:LONG_LINE: line over 90 characters
#3971: FILE: drivers/crypto/virtio/virtio_rxtx.c:275:
+	malloc_addr = rte_malloc(NULL, req_data_len	+ sizeof(struct virtio_crypto_inhdr)

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'session->ctrl.u.sym_create_session.u.chain.para.u.hash_param.hash_result_len'
#4042: FILE: drivers/crypto/virtio/virtio_rxtx.c:346:
+			session->ctrl.u.sym_create_session.u.chain.para.u.hash_param.
+			hash_result_len;

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'session->ctrl.u.sym_create_session.u.chain.para.u.mac_param.hash_result_len'
#4047: FILE: drivers/crypto/virtio/virtio_rxtx.c:351:
+			session->ctrl.u.sym_create_session.u.chain.para.u.mac_param.
+			hash_result_len;

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#4283: FILE: drivers/crypto/virtio/virtqueue.c:12:
+ *    ^I notice, this list of conditions and the following disclaimer.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#4285: FILE: drivers/crypto/virtio/virtqueue.c:14:
+ *    ^I notice, this list of conditions and the following disclaimer in$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#4286: FILE: drivers/crypto/virtio/virtqueue.c:15:
+ *    ^I the documentation and/or other materials provided with the$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#4287: FILE: drivers/crypto/virtio/virtqueue.c:16:
+ *    ^I distribution.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#4290: FILE: drivers/crypto/virtio/virtqueue.c:19:
+ *    ^I from this software without specific prior written permission.$

WARNING:TYPO_SPELLING: 'suppport' may be misspelled - perhaps 'support'?
#4478: FILE: drivers/crypto/virtio/virtqueue.h:121:
+/* If multiqueue is provided by host, then we suppport it. */

ERROR:CODE_INDENT: code indent should use tabs where possible
#4831: FILE: test/test/test_cryptodev_blockcipher.c:100:
+            RTE_STR(CRYPTODEV_NAME_VIRTIO_SYM_PMD));$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#4831: FILE: test/test/test_cryptodev_blockcipher.c:100:
+            RTE_STR(CRYPTODEV_NAME_VIRTIO_SYM_PMD));$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#4849: FILE: test/test/test_cryptodev_blockcipher.c:603:
+    int virtio_pmd = rte_cryptodev_driver_id_get($

ERROR:CODE_INDENT: code indent should use tabs where possible
#4850: FILE: test/test/test_cryptodev_blockcipher.c:604:
+            RTE_STR(CRYPTODEV_NAME_VIRTIO_SYM_PMD));$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#4850: FILE: test/test/test_cryptodev_blockcipher.c:604:
+            RTE_STR(CRYPTODEV_NAME_VIRTIO_SYM_PMD));$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#4858: FILE: test/test/test_cryptodev_blockcipher.c:667:
+    else if (driver_id == virtio_pmd)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#4859: FILE: test/test/test_cryptodev_blockcipher.c:668:
+        target_pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_VIRTIO;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#4859: FILE: test/test/test_cryptodev_blockcipher.c:668:
+        target_pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_VIRTIO;$

total: 5 errors, 95 warnings, 4599 lines checked
Previous message: [dpdk-test-report] |FAILURE| pw31458 [PATCH v2 6/6] net/ixgbe: Enable port representor PMD and broker for ixgbe PMD driver
Next message: [dpdk-test-report] |SUCCESS| pw31461 [PATCH] test/mempool: improve default mempool ops selection
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list