[dpdk-test-report] |WARNING| pw31489 [PATCH RFC v3 1/1] eventtimer: introduce event timer adapter

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Nov 20 23:35:44 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31489

_coding style issues_


WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#181: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:51:
+extern const struct rte_event_timer_adapter_ops sw_event_adapter_timer_ops;

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#189: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:59:
+#define ADAPTER_VALID_OR_ERR_RET(adapter, retval) do { \
+	if (!adapter_valid(adapter))		       \
+		return retval;			       \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#194: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:64:
+#define FUNC_PTR_OR_ERR_RET(func, errval) do { \
+	if ((func) == NULL)		       \
+		return errval;		       \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#199: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:69:
+#define FUNC_PTR_OR_NULL_RET_WITH_ERRNO(func, errval) do { \
+	if ((func) == NULL) {				   \
+		rte_errno = errval;			   \
+		return NULL;				   \
+	}						   \
+} while (0)

total: 0 errors, 4 warnings, 1497 lines checked


More information about the test-report mailing list