[dpdk-test-report] |WARNING| pw29545 [PATCH v2 10/12] net/ixgbe: enable inline ipsec

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Oct 3 15:17:48 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29545

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse '__reg' - possible side-effects?
#291: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:48:
+#define IXGBE_WAIT_RW(__reg, __rw)					\
+{									\
+	int cnt = 100;							\
+	IXGBE_WRITE_REG(hw, (__reg), reg);				\
+	while (((IXGBE_READ_REG(hw, (__reg))) & (__rw)) && (cnt--))	\
+		rte_delay_us(1);					\
+}

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'a' - possible side-effects?
#303: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:60:
+#define CMP_IP(a, b) (\
+	(a).ipv6[0] == (b).ipv6[0] && \
+	(a).ipv6[1] == (b).ipv6[1] && \
+	(a).ipv6[2] == (b).ipv6[2] && \
+	(a).ipv6[3] == (b).ipv6[3])

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects?
#303: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:60:
+#define CMP_IP(a, b) (\
+	(a).ipv6[0] == (b).ipv6[0] && \
+	(a).ipv6[1] == (b).ipv6[1] && \
+	(a).ipv6[2] == (b).ipv6[2] && \
+	(a).ipv6[3] == (b).ipv6[3])

CHECK:CAMELCASE: Avoid CamelCase: <IPv6>
#431: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:188:
+		if (ic_session->dst_ip.type == IPv6)

CHECK:CAMELCASE: Avoid CamelCase: <IPv4>
#438: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:195:
+		if (priv->rx_ip_tbl[ip_index].ip.type == IPv4) {

total: 0 errors, 0 warnings, 5 checks, 1234 lines checked


More information about the test-report mailing list