[dpdk-test-report] |WARNING| pw29634 [PATCH v8 4/7] net/i40e: finish integration FDIR with generic flow API
checkpatch at dpdk.org
checkpatch at dpdk.org
Thu Oct 5 10:17:25 CEST 2017
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29634
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv4>
#225: FILE: drivers/net/i40e/i40e_fdir.c:988:
+ *ether_type = rte_cpu_to_be_16(ETHER_TYPE_IPv4);
CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv6>
#252: FILE: drivers/net/i40e/i40e_fdir.c:1015:
+ *ether_type = rte_cpu_to_be_16(ETHER_TYPE_IPv6);
CHECK:CAMELCASE: Avoid CamelCase: <I40E_FDIR_IPv6_DEFAULT_VTC_FLOW>
#254: FILE: drivers/net/i40e/i40e_fdir.c:1017:
+ rte_cpu_to_be_32(I40E_FDIR_IPv6_DEFAULT_VTC_FLOW |
CHECK:CAMELCASE: Avoid CamelCase: <I40E_FDIR_IPv6_TC_OFFSET>
#256: FILE: drivers/net/i40e/i40e_fdir.c:1019:
+ I40E_FDIR_IPv6_TC_OFFSET));
CHECK:CAMELCASE: Avoid CamelCase: <I40E_FDIR_IPv6_PAYLOAD_LEN>
#258: FILE: drivers/net/i40e/i40e_fdir.c:1021:
+ rte_cpu_to_be_16(I40E_FDIR_IPv6_PAYLOAD_LEN);
CHECK:CAMELCASE: Avoid CamelCase: <I40E_FDIR_IPv6_DEFAULT_HOP_LIMITS>
#264: FILE: drivers/net/i40e/i40e_fdir.c:1027:
+ I40E_FDIR_IPv6_DEFAULT_HOP_LIMITS;
CHECK:BRACES: Unbalanced braces around else statement
#571: FILE: drivers/net/i40e/i40e_fdir.c:1464:
+ } else
CHECK:BRACES: braces {} should be used on all arms of this statement
#646: FILE: drivers/net/i40e/i40e_fdir.c:1686:
+ if (fdir_action->behavior == I40E_FDIR_REJECT)
[...]
+ else if (fdir_action->behavior == I40E_FDIR_ACCEPT)
[...]
+ else if (fdir_action->behavior == I40E_FDIR_PASSTHRU)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#652: FILE: drivers/net/i40e/i40e_fdir.c:1692:
+ else {
total: 0 errors, 0 warnings, 9 checks, 882 lines checked
More information about the test-report
mailing list