[dpdk-test-report] |WARNING| pw29705 [PATCH v2 14/30] net/mlx5: make indirection tables shareable

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Oct 5 14:52:12 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29705

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ind_tbl->queues_n == queues_n'
#315: FILE: drivers/net/mlx5/mlx5_rxq.c:1708:
+		if ((ind_tbl->queues_n == queues_n) &&
+		    (memcmp(ind_tbl->queues, queues,
+			    ind_tbl->queues_n * sizeof(ind_tbl->queues[0]))
+		     == 0))

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EBUSY)
#361: FILE: drivers/net/mlx5/mlx5_rxq.c:1754:
+	return EBUSY;

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#409: FILE: drivers/net/mlx5/mlx5_rxtx.h:357:
+struct mlx5_ind_table_ibv *mlx5_priv_ind_table_ibv_new(struct priv *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t []' should also have an identifier name
#409: FILE: drivers/net/mlx5/mlx5_rxtx.h:357:
+struct mlx5_ind_table_ibv *mlx5_priv_ind_table_ibv_new(struct priv *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name
#409: FILE: drivers/net/mlx5/mlx5_rxtx.h:357:
+struct mlx5_ind_table_ibv *mlx5_priv_ind_table_ibv_new(struct priv *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#412: FILE: drivers/net/mlx5/mlx5_rxtx.h:360:
+struct mlx5_ind_table_ibv *mlx5_priv_ind_table_ibv_get(struct priv *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t []' should also have an identifier name
#412: FILE: drivers/net/mlx5/mlx5_rxtx.h:360:
+struct mlx5_ind_table_ibv *mlx5_priv_ind_table_ibv_get(struct priv *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name
#412: FILE: drivers/net/mlx5/mlx5_rxtx.h:360:
+struct mlx5_ind_table_ibv *mlx5_priv_ind_table_ibv_get(struct priv *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#415: FILE: drivers/net/mlx5/mlx5_rxtx.h:363:
+int mlx5_priv_ind_table_ibv_release(struct priv *, struct mlx5_ind_table_ibv *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct mlx5_ind_table_ibv *' should also have an identifier name
#415: FILE: drivers/net/mlx5/mlx5_rxtx.h:363:
+int mlx5_priv_ind_table_ibv_release(struct priv *, struct mlx5_ind_table_ibv *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#416: FILE: drivers/net/mlx5/mlx5_rxtx.h:364:
+int mlx5_priv_ind_table_ibv_verify(struct priv *);

total: 0 errors, 10 warnings, 1 checks, 370 lines checked


More information about the test-report mailing list