[dpdk-test-report] |WARNING| pw29842 [PATCH v3 10/12] net/ixgbe: enable inline ipsec

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29842

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse '__reg' - possible side-effects?
#291: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:48:
+#define IXGBE_WAIT_RW(__reg, __rw)					\
+{									\
+	int cnt = 100;							\
+	IXGBE_WRITE_REG(hw, (__reg), reg);				\
+	while (((IXGBE_READ_REG(hw, (__reg))) & (__rw)) && (cnt--))	\
+		rte_delay_us(1);					\
+}

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'a' - possible side-effects?
#303: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:60:
+#define CMP_IP(a, b) (\
+	(a).ipv6[0] == (b).ipv6[0] && \
+	(a).ipv6[1] == (b).ipv6[1] && \
+	(a).ipv6[2] == (b).ipv6[2] && \
+	(a).ipv6[3] == (b).ipv6[3])

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects?
#303: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:60:
+#define CMP_IP(a, b) (\
+	(a).ipv6[0] == (b).ipv6[0] && \
+	(a).ipv6[1] == (b).ipv6[1] && \
+	(a).ipv6[2] == (b).ipv6[2] && \
+	(a).ipv6[3] == (b).ipv6[3])

CHECK:CAMELCASE: Avoid CamelCase: <IPv6>
#431: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:188:
+		if (ic_session->dst_ip.type == IPv6)

CHECK:CAMELCASE: Avoid CamelCase: <IPv4>
#438: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:195:
+		if (priv->rx_ip_tbl[ip_index].ip.type == IPv4) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'txq->tx_rs_thresh >= RTE_PMD_IXGBE_TX_MAX_BURST'
#1260: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:2410:
+	if (((txq->txq_flags & IXGBE_SIMPLE_FLAGS) == IXGBE_SIMPLE_FLAGS) &&
+			(txq->tx_rs_thresh >= RTE_PMD_IXGBE_TX_MAX_BURST) &&
+			!(dev->data->dev_conf.txmode.enable_sec)) {

total: 0 errors, 0 warnings, 6 checks, 1258 lines checked