[dpdk-test-report] |WARNING| pw29974 [PATCH v3 19/30] net/mlx5: use flow to enable unicast traffic

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Oct 9 16:50:32 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29974

_coding style issues_


WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#118: FILE: drivers/net/mlx5/mlx5.h:267:
+int priv_dev_traffic_enable(struct priv *, struct rte_eth_dev *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_eth_dev *' should also have an identifier name
#118: FILE: drivers/net/mlx5/mlx5.h:267:
+int priv_dev_traffic_enable(struct priv *, struct rte_eth_dev *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#119: FILE: drivers/net/mlx5/mlx5.h:268:
+int priv_dev_traffic_disable(struct priv *, struct rte_eth_dev *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_eth_dev *' should also have an identifier name
#119: FILE: drivers/net/mlx5/mlx5.h:268:
+int priv_dev_traffic_disable(struct priv *, struct rte_eth_dev *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#120: FILE: drivers/net/mlx5/mlx5.h:269:
+int priv_dev_traffic_restart(struct priv *, struct rte_eth_dev *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_eth_dev *' should also have an identifier name
#120: FILE: drivers/net/mlx5/mlx5.h:269:
+int priv_dev_traffic_restart(struct priv *, struct rte_eth_dev *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_eth_dev *' should also have an identifier name
#121: FILE: drivers/net/mlx5/mlx5.h:270:
+int mlx5_traffic_restart(struct rte_eth_dev *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_eth_dev *' should also have an identifier name
#129: FILE: drivers/net/mlx5/mlx5.h:293:
+int mlx5_ctrl_flow_vlan(struct rte_eth_dev *, struct rte_flow_item_eth *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_flow_item_eth *' should also have an identifier name
#129: FILE: drivers/net/mlx5/mlx5.h:293:
+int mlx5_ctrl_flow_vlan(struct rte_eth_dev *, struct rte_flow_item_eth *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_flow_item_eth *' should also have an identifier name
#129: FILE: drivers/net/mlx5/mlx5.h:293:
+int mlx5_ctrl_flow_vlan(struct rte_eth_dev *, struct rte_flow_item_eth *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_flow_item_vlan *' should also have an identifier name
#129: FILE: drivers/net/mlx5/mlx5.h:293:
+int mlx5_ctrl_flow_vlan(struct rte_eth_dev *, struct rte_flow_item_eth *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_flow_item_vlan *' should also have an identifier name
#129: FILE: drivers/net/mlx5/mlx5.h:293:
+int mlx5_ctrl_flow_vlan(struct rte_eth_dev *, struct rte_flow_item_eth *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#135: FILE: drivers/net/mlx5/mlx5.h:298:
+int priv_flow_create_drop_queue(struct priv *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#136: FILE: drivers/net/mlx5/mlx5.h:299:
+void priv_flow_delete_drop_queue(struct priv *);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EADDRINUSE)
#783: FILE: drivers/net/mlx5/mlx5_mac.c:138:
+		return EADDRINUSE;

total: 0 errors, 15 warnings, 0 checks, 1548 lines checked


More information about the test-report mailing list