[dpdk-test-report] |WARNING| pw29984 [PATCH v3 28/30] net/mlx5: handle RSS hash configuration in RSS flow
checkpatch at dpdk.org
checkpatch at dpdk.org
Mon Oct 9 16:52:23 CEST 2017
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29984
_coding style issues_
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#253: FILE: drivers/net/mlx5/mlx5_flow.c:552:
+ return EINVAL;
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i == parser->layer'
#554: FILE: drivers/net/mlx5/mlx5_flow.c:933:
+ if ((i == parser->layer) ||
+ (!parser->queue[i].ibv_attr))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around '!parser->queue[i].ibv_attr'
#554: FILE: drivers/net/mlx5/mlx5_flow.c:933:
+ if ((i == parser->layer) ||
+ (!parser->queue[i].ibv_attr))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i == HASH_RXQ_UDPV4'
#607: FILE: drivers/net/mlx5/mlx5_flow.c:986:
+ if ((i == HASH_RXQ_UDPV4) || (i == HASH_RXQ_TCPV4) ||
+ (i == HASH_RXQ_UDPV6) || (i == HASH_RXQ_TCPV6)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i == HASH_RXQ_TCPV4'
#607: FILE: drivers/net/mlx5/mlx5_flow.c:986:
+ if ((i == HASH_RXQ_UDPV4) || (i == HASH_RXQ_TCPV4) ||
+ (i == HASH_RXQ_UDPV6) || (i == HASH_RXQ_TCPV6)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i == HASH_RXQ_UDPV6'
#607: FILE: drivers/net/mlx5/mlx5_flow.c:986:
+ if ((i == HASH_RXQ_UDPV4) || (i == HASH_RXQ_TCPV4) ||
+ (i == HASH_RXQ_UDPV6) || (i == HASH_RXQ_TCPV6)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i == HASH_RXQ_TCPV6'
#607: FILE: drivers/net/mlx5/mlx5_flow.c:986:
+ if ((i == HASH_RXQ_UDPV4) || (i == HASH_RXQ_TCPV4) ||
+ (i == HASH_RXQ_UDPV6) || (i == HASH_RXQ_TCPV6)) {
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#687: FILE: drivers/net/mlx5/mlx5_flow.c:1066:
+ return ENOMEM;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#699: FILE: drivers/net/mlx5/mlx5_flow.c:1078:
+ return ENOMEM;
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i != HASH_RXQ_ETH'
#709: FILE: drivers/net/mlx5/mlx5_flow.c:1088:
+ if (!(parser->rss_conf.rss_hf &
+ hash_rxq_init[i].dpdk_rss_hf) &&
+ (i != HASH_RXQ_ETH))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hash_rxq_init[parser->layer].ip_version ==
hash_rxq_init[i].ip_version'
#804: FILE: drivers/net/mlx5/mlx5_flow.c:1183:
+ if (parser->layer == HASH_RXQ_ETH ||
+ (hash_rxq_init[parser->layer].ip_version ==
+ hash_rxq_init[i].ip_version) ||
+ (hash_rxq_init[i].ip_version == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hash_rxq_init[i].ip_version == 0'
#804: FILE: drivers/net/mlx5/mlx5_flow.c:1183:
+ if (parser->layer == HASH_RXQ_ETH ||
+ (hash_rxq_init[parser->layer].ip_version ==
+ hash_rxq_init[i].ip_version) ||
+ (hash_rxq_init[i].ip_version == 0)) {
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#1382: FILE: drivers/net/mlx5/mlx5_flow.c:1661:
+ return ENOMEM;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#1840: FILE: drivers/net/mlx5/mlx5_flow.c:2277:
+ return EINVAL;
total: 0 errors, 5 warnings, 9 checks, 1767 lines checked
More information about the test-report
mailing list