[dpdk-test-report] |WARNING| pw30625 [PATCH RFC 2/9] net/avf: initilization of avf PMD
checkpatch at dpdk.org
checkpatch at dpdk.org
Fri Oct 20 10:36:33 CEST 2017
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/30625
_coding style issues_
WARNING:TYPO_SPELLING: 'initilization' may be misspelled - perhaps 'initialization'?
#5:
Subject: [dpdk-dev] [PATCH RFC 2/9] net/avf: initilization of avf PMD
WARNING:ONE_SEMICOLON: Statements terminations use 1 semicolon
#645: FILE: drivers/net/avf/avf_ethdev.c:254:
+ hw->back = AVF_DEV_PRIVATE_TO_ADAPTER(eth_dev->data->dev_private);;
CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#778: FILE: drivers/net/avf/avf_ethdev.c:387:
+ snprintf(z_name, sizeof(z_name), "avf_dma_%"PRIu64, rte_rand());
CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#778: FILE: drivers/net/avf/avf_ethdev.c:387:
+ snprintf(z_name, sizeof(z_name), "avf_dma_%"PRIu64, rte_rand());
CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#789: FILE: drivers/net/avf/avf_ethdev.c:398:
+ "memzone %s allocated with physical address: %"PRIu64,
CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#803: FILE: drivers/net/avf/avf_ethdev.c:412:
+ "memzone %s to be freed with physical address: %"PRIu64,
WARNING:RETURN_VOID: void function return statements are not generally useful
#866: FILE: drivers/net/avf/avf_ethdev.c:475:
+ return;
+}
CHECK:BRACES: Unbalanced braces around else statement
#1081: FILE: drivers/net/avf/avf_vchnl.c:209:
+ } else
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vf->virtchnl_version.major < VIRTCHNL_VERSION_MAJOR_START'
#1132: FILE: drivers/net/avf/avf_vchnl.c:260:
+ if ((vf->virtchnl_version.major < VIRTCHNL_VERSION_MAJOR_START) ||
+ ((vf->virtchnl_version.major == VIRTCHNL_VERSION_MAJOR_START) &&
+ (vf->virtchnl_version.minor < VIRTCHNL_VERSION_MINOR_START))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vf->virtchnl_version.major == VIRTCHNL_VERSION_MAJOR_START'
#1132: FILE: drivers/net/avf/avf_vchnl.c:260:
+ if ((vf->virtchnl_version.major < VIRTCHNL_VERSION_MAJOR_START) ||
+ ((vf->virtchnl_version.major == VIRTCHNL_VERSION_MAJOR_START) &&
+ (vf->virtchnl_version.minor < VIRTCHNL_VERSION_MINOR_START))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vf->virtchnl_version.minor < VIRTCHNL_VERSION_MINOR_START'
#1132: FILE: drivers/net/avf/avf_vchnl.c:260:
+ if ((vf->virtchnl_version.major < VIRTCHNL_VERSION_MAJOR_START) ||
+ ((vf->virtchnl_version.major == VIRTCHNL_VERSION_MAJOR_START) &&
+ (vf->virtchnl_version.minor < VIRTCHNL_VERSION_MINOR_START))) {
CHECK:BRACES: braces {} should be used on all arms of this statement
#1132: FILE: drivers/net/avf/avf_vchnl.c:260:
+ if ((vf->virtchnl_version.major < VIRTCHNL_VERSION_MAJOR_START) ||
[...]
+ } else if ((vf->virtchnl_version.major > VIRTCHNL_VERSION_MAJOR) ||
[...]
+ } else
[...]
WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1149: FILE: drivers/net/avf/avf_vchnl.c:277:
+ return -1;
+ } else
CHECK:BRACES: Unbalanced braces around else statement
#1149: FILE: drivers/net/avf/avf_vchnl.c:277:
+ } else
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1169: FILE: drivers/net/avf/avf_vchnl.c:297:
+ /* TODO: basic offload capabilities, need to
+ * add advanced/optional offload capabilities
total: 0 errors, 5 warnings, 1153 lines checked
More information about the test-report
mailing list