[dpdk-test-report] |WARNING| pw30626 [PATCH RFC 3/9] net/avf: enable queue and device

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Oct 20 10:36:38 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/30626

_coding style issues_


WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#172: FILE: drivers/net/avf/avf_ethdev.c:141:
+	 * based on rss_conf->rss_hf. */

CHECK:BRACES: Unbalanced braces around else statement
#179: FILE: drivers/net/avf/avf_ethdev.c:148:
+	} else

WARNING:TYPO_SPELLING: 'accoding' may be misspelled - perhaps 'according'?
#264: FILE: drivers/net/avf/avf_ethdev.c:233:
+	 * accoding to parameters

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#340: FILE: drivers/net/avf/avf_ethdev.c:309:
+		 * write back. */

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#402: FILE: drivers/net/avf/avf_ethdev.c:371:
+
+}

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#667: FILE: drivers/net/avf/avf_rxtx.c:191:
+
+}

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_desc > AVF_MAX_RING_DESC'
#760: FILE: drivers/net/avf/avf_rxtx.c:284:
+	if (nb_desc % AVF_ALIGN_RING_DESC != 0 ||
+	    (nb_desc > AVF_MAX_RING_DESC) ||
+	    (nb_desc < AVF_MIN_RING_DESC)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_desc < AVF_MIN_RING_DESC'
#760: FILE: drivers/net/avf/avf_rxtx.c:284:
+	if (nb_desc % AVF_ALIGN_RING_DESC != 0 ||
+	    (nb_desc > AVF_MAX_RING_DESC) ||
+	    (nb_desc < AVF_MIN_RING_DESC)) {

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#818: FILE: drivers/net/avf/avf_rxtx.c:342:
+	 * a liitle more to support bulk allocate . */

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_desc > AVF_MAX_RING_DESC'
#861: FILE: drivers/net/avf/avf_rxtx.c:385:
+	if (nb_desc % AVF_ALIGN_RING_DESC != 0 ||
+	    (nb_desc > AVF_MAX_RING_DESC) ||
+	    (nb_desc < AVF_MIN_RING_DESC)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_desc < AVF_MIN_RING_DESC'
#861: FILE: drivers/net/avf/avf_rxtx.c:385:
+	if (nb_desc % AVF_ALIGN_RING_DESC != 0 ||
+	    (nb_desc > AVF_MAX_RING_DESC) ||
+	    (nb_desc < AVF_MIN_RING_DESC)) {

WARNING:MISSING_EOF_NEWLINE: adding a line without newline at end of file
#1123: FILE: drivers/net/avf/avf_rxtx.c:647:
+}

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#1276: FILE: drivers/net/avf/avf_rxtx.h:146:
+	printf("Queue %d Rx_desc %d: QW0: 0x%016"PRIx64" QW1: 0x%016"PRIx64"
",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#1276: FILE: drivers/net/avf/avf_rxtx.h:146:
+	printf("Queue %d Rx_desc %d: QW0: 0x%016"PRIx64" QW1: 0x%016"PRIx64"
",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#1282: FILE: drivers/net/avf/avf_rxtx.h:152:
+	printf("Queue %d Rx_desc %d: QW0: 0x%016"PRIx64" QW1: 0x%016"PRIx64

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#1283: FILE: drivers/net/avf/avf_rxtx.h:153:
+	       " QW2: 0x%016"PRIx64" QW3: 0x%016"PRIx64"
", rxq->queue_id,

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#1290: FILE: drivers/net/avf/avf_rxtx.h:160:
+ * to print the qwords */

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#1314: FILE: drivers/net/avf/avf_rxtx.h:184:
+	printf("Queue %d %s %d: QW0: 0x%016"PRIx64" QW1: 0x%016"PRIx64"
",

WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#1320: FILE: drivers/net/avf/avf_rxtx.h:190:
+#define AVF_DUMP_RX_DESC(rxq, desc, rx_id) \
+	avf_dump_rx_descriptor(rxq, desc, rx_id);

WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#1327: FILE: drivers/net/avf/avf_rxtx.h:197:
+#define AVF_DUMP_TX_DESC(txq, desc, tx_id) \
+	avf_dump_tx_descriptor(txq, desc, tx_id);

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17)
#1364: FILE: drivers/net/avf/avf_vchnl.c:240:
+	if (ret)
+		 PMD_DRV_LOG(ERR, "Failed to execute command of "

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17)
#1385: FILE: drivers/net/avf/avf_vchnl.c:261:
+	if (ret)
+		 PMD_DRV_LOG(ERR, "Failed to execute command of "

WARNING:TABSTOP: Statements should start on a tabstop
#1389: FILE: drivers/net/avf/avf_vchnl.c:265:
+	 return ret;

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#1423: FILE: drivers/net/avf/avf_vchnl.c:403:
+		return -ENOSYS;

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#1451: FILE: drivers/net/avf/avf_vchnl.c:431:
+		return -ENOSYS;

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#1514: FILE: drivers/net/avf/avf_vchnl.c:494:
+		err = -ENOSYS;

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#1547: FILE: drivers/net/avf/avf_vchnl.c:527:
+		err = -ENOSYS;

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#1607: FILE: drivers/net/avf/avf_vchnl.c:587:
+		err = -ENOSYS;

total: 0 errors, 16 warnings, 12 checks, 1635 lines checked


More information about the test-report mailing list