[dpdk-test-report] |WARNING| pw30810 [PATCH v5 09/11] net/ixgbe: enable inline ipsec

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/30810

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects?
#63: FILE: drivers/net/ixgbe/base/ixgbe_osdep.h:164:
+#define IXGBE_WRITE_REG_THEN_POLL_MASK(hw, reg, val, mask, poll_ms)	\
+do {									\
+	uint32_t cnt = poll_ms;						\
+	IXGBE_WRITE_REG(hw, (reg), (val));				\
+	while (((IXGBE_READ_REG(hw, (reg))) & (mask)) && (cnt--))	\
+		rte_delay_ms(1);					\
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'reg' - possible side-effects?
#63: FILE: drivers/net/ixgbe/base/ixgbe_osdep.h:164:
+#define IXGBE_WRITE_REG_THEN_POLL_MASK(hw, reg, val, mask, poll_ms)	\
+do {									\
+	uint32_t cnt = poll_ms;						\
+	IXGBE_WRITE_REG(hw, (reg), (val));				\
+	while (((IXGBE_READ_REG(hw, (reg))) & (mask)) && (cnt--))	\
+		rte_delay_ms(1);					\
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'a' - possible side-effects?
#292: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:62:
+#define CMP_IP(a, b) (\
+	(a).ipv6[0] == (b).ipv6[0] && \
+	(a).ipv6[1] == (b).ipv6[1] && \
+	(a).ipv6[2] == (b).ipv6[2] && \
+	(a).ipv6[3] == (b).ipv6[3])

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects?
#292: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:62:
+#define CMP_IP(a, b) (\
+	(a).ipv6[0] == (b).ipv6[0] && \
+	(a).ipv6[1] == (b).ipv6[1] && \
+	(a).ipv6[2] == (b).ipv6[2] && \
+	(a).ipv6[3] == (b).ipv6[3])

CHECK:CAMELCASE: Avoid CamelCase: <IPv6>
#420: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:190:
+		if (ic_session->dst_ip.type == IPv6)

CHECK:CAMELCASE: Avoid CamelCase: <IPv4>
#427: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:197:
+		if (priv->rx_ip_tbl[ip_index].ip.type == IPv4) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'txq->tx_rs_thresh >= RTE_PMD_IXGBE_TX_MAX_BURST'
#1234: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:2399:
+	if (((txq->txq_flags & IXGBE_SIMPLE_FLAGS) == IXGBE_SIMPLE_FLAGS) &&
+			(txq->tx_rs_thresh >= RTE_PMD_IXGBE_TX_MAX_BURST) &&
+			!(dev->data->dev_conf.txmode.offloads
+					& DEV_TX_OFFLOAD_SECURITY)) {

total: 0 errors, 0 warnings, 7 checks, 1284 lines checked