[dpdk-test-report] |WARNING| pw30914 [PATCH v7 11/25] pci: avoid inlining functions
checkpatch at dpdk.org
checkpatch at dpdk.org
Thu Oct 26 00:40:04 CEST 2017
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/30914
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#33: FILE: lib/librte_eal/common/eal_common_pci.c:91:
+#define GET_PCIADDR_FIELD(in, fd, lim, dlm) \
+do { \
+ unsigned long val; \
+ char *end; \
+ errno = 0; \
+ val = strtoul((in), &end, 16); \
+ if (errno != 0 || end[0] != (dlm) || val > (lim)) \
+ return -EINVAL; \
+ (fd) = (typeof (fd))val; \
+ (in) = end + 1; \
+} while(0)
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#41: FILE: lib/librte_eal/common/eal_common_pci.c:99:
+ (fd) = (typeof (fd))val; \
ERROR:SPACING: space required before the open parenthesis '('
#43: FILE: lib/librte_eal/common/eal_common_pci.c:101:
+} while(0)
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17)
#84: FILE: lib/librte_eal/common/eal_common_pci.c:142:
+ if ((addr == NULL) || (addr2 == NULL))
+ return -1;
WARNING:TABSTOP: Statements should start on a tabstop
#85: FILE: lib/librte_eal/common/eal_common_pci.c:143:
+ return -1;
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17)
#92: FILE: lib/librte_eal/common/eal_common_pci.c:150:
+ if (dev_addr > dev_addr2)
+ return 1;
WARNING:TABSTOP: Statements should start on a tabstop
#93: FILE: lib/librte_eal/common/eal_common_pci.c:151:
+ return 1;
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17)
#94: FILE: lib/librte_eal/common/eal_common_pci.c:152:
+ else if (dev_addr < dev_addr2)
+ return -1;
WARNING:TABSTOP: Statements should start on a tabstop
#95: FILE: lib/librte_eal/common/eal_common_pci.c:153:
+ return -1;
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17)
#96: FILE: lib/librte_eal/common/eal_common_pci.c:154:
+ else
+ return 0;
WARNING:TABSTOP: Statements should start on a tabstop
#97: FILE: lib/librte_eal/common/eal_common_pci.c:155:
+ return 0;
total: 1 errors, 10 warnings, 192 lines checked
More information about the test-report
mailing list