[dpdk-test-report] |WARNING| pw28358 [PATCH v2 1/5] eal: rename phys_addr_t to iova_addr_t

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Sep 5 12:32:13 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28358

_coding style issues_


CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'sc' may be better as '(sc)' to avoid precedence issues
#706: FILE: drivers/net/bnx2x/bnx2x.h:1245:
+#define GUNZIP_PHYS(sc)   (iova_addr_t)(sc->gz_buf_dma.paddr)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#733: FILE: drivers/net/bnx2x/bnx2x.h:1405:
+    iova_addr_t fw_stat_map; /* (dma) valid if FUNC_FLG_STATS */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#734: FILE: drivers/net/bnx2x/bnx2x.h:1406:
+    iova_addr_t spq_map;     /* (dma) valid if FUNC_FLG_SPQ */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#771: FILE: drivers/net/bnx2x/bnx2x_stats.c:1341:
+    iova_addr_t cur_data_offset;$

WARNING:LONG_LINE: line over 90 characters
#1284: FILE: drivers/net/xenvirt/rte_xen_lib.c:358:
+grant_node_create(uint32_t pg_num, uint32_t *gref_arr, iova_addr_t *pa_arr, char *val_str, size_t str_size)

WARNING:LONG_LINE: line over 90 characters
#1293: FILE: drivers/net/xenvirt/rte_xen_lib.c:422:
+grant_gntalloc_mbuf_pool(struct rte_mempool *mpool, uint32_t pg_num, uint32_t *gref_arr, iova_addr_t *pa_arr, int mempool_idx)

WARNING:LONG_LINE: line over 90 characters
#1324: FILE: drivers/net/xenvirt/rte_xen_lib.h:111:
+int grant_node_create(uint32_t pg_num, uint32_t *gref_arr, iova_addr_t *pa_arr, char *val_str, size_t str_size);

WARNING:LONG_LINE: line over 90 characters
#1328: FILE: drivers/net/xenvirt/rte_xen_lib.h:114:
+grant_gntalloc_mbuf_pool(struct rte_mempool *mpool, uint32_t pg_num, uint32_t *gref_arr, iova_addr_t *pa_arr, int mempool_idx);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'int32_t' should also have an identifier name
#1472: FILE: lib/librte_eal/common/include/rte_memory.h:204:
+iova_addr_t rte_xen_mem_phy2mch(int32_t, const iova_addr_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'const iova_addr_t' should also have an identifier name
#1472: FILE: lib/librte_eal/common/include/rte_memory.h:204:
+iova_addr_t rte_xen_mem_phy2mch(int32_t, const iova_addr_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'iova_addr_t' should also have an identifier name
#1632: FILE: lib/librte_mbuf/rte_mbuf.h:414:
+	iova_addr_t buf_physaddr __rte_aligned(sizeof(iova_addr_t));

total: 0 errors, 10 warnings, 1350 lines checked


More information about the test-report mailing list