[dpdk-test-report] |WARNING| pw28904 [PATCH 29/53] net/qede/base: fix macros to check chip revision/metal

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Sep 19 03:38:14 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28904

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse '_p_dev' - possible side-effects?
#73: FILE: drivers/net/qede/base/ecore.h:693:
+#define CHIP_REV_IS_EMUL(_p_dev) \
+	(CHIP_REV_IS_EMUL_A0(_p_dev) || CHIP_REV_IS_EMUL_B0(_p_dev))

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_p_dev' - possible side-effects?
#77: FILE: drivers/net/qede/base/ecore.h:697:
+#define CHIP_REV_IS_FPGA(_p_dev) \
+	(CHIP_REV_IS_FPGA_A0(_p_dev) || CHIP_REV_IS_FPGA_B0(_p_dev))

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_p_dev' - possible side-effects?
#79: FILE: drivers/net/qede/base/ecore.h:699:
+#define CHIP_REV_IS_SLOW(_p_dev) \
+	(CHIP_REV_IS_EMUL(_p_dev) || CHIP_REV_IS_FPGA(_p_dev))

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_p_dev' - possible side-effects?
#81: FILE: drivers/net/qede/base/ecore.h:701:
+#define CHIP_REV_IS_A0(_p_dev) \
+	(CHIP_REV_IS_EMUL_A0(_p_dev) || CHIP_REV_IS_FPGA_A0(_p_dev) || \
+	 (!(_p_dev)->chip_rev && !(_p_dev)->chip_metal))

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_p_dev' - possible side-effects?
#84: FILE: drivers/net/qede/base/ecore.h:704:
+#define CHIP_REV_IS_B0(_p_dev) \
+	(CHIP_REV_IS_EMUL_B0(_p_dev) || CHIP_REV_IS_FPGA_B0(_p_dev) || \
+	 ((_p_dev)->chip_rev == 1 && !(_p_dev)->chip_metal))

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_p_dev' - possible side-effects?
#91: FILE: drivers/net/qede/base/ecore.h:709:
+#define CHIP_REV_IS_A0(_p_dev) \
+	(!(_p_dev)->chip_rev && !(_p_dev)->chip_metal)

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_p_dev' - possible side-effects?
#93: FILE: drivers/net/qede/base/ecore.h:711:
+#define CHIP_REV_IS_B0(_p_dev) \
+	((_p_dev)->chip_rev == 1 && !(_p_dev)->chip_metal)

total: 0 errors, 0 warnings, 7 checks, 147 lines checked


More information about the test-report mailing list