[dpdk-test-report] |WARNING| pw29388 [PATCH v4 18/24] net/bnxt: add support for flow filter ops

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29388

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv4>
#151: FILE: drivers/net/bnxt/bnxt_ethdev.c:1662:
+	if (efilter->ether_type != ETHER_TYPE_IPv4 &&

CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv6>
#152: FILE: drivers/net/bnxt/bnxt_ethdev.c:1663:
+		efilter->ether_type != ETHER_TYPE_IPv6) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mfilter->flags ==
 			      HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_DROP'
#171: FILE: drivers/net/bnxt/bnxt_ethdev.c:1682:
+			if ((!memcmp(efilter->mac_addr.addr_bytes,
+				     mfilter->l2_addr, ETHER_ADDR_LEN) &&
+			     (mfilter->flags ==
+			      HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_DROP) &&
+			     (mfilter->ethertype == efilter->ether_type))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mfilter->ethertype == efilter->ether_type'
#171: FILE: drivers/net/bnxt/bnxt_ethdev.c:1682:
+			if ((!memcmp(efilter->mac_addr.addr_bytes,
+				     mfilter->l2_addr, ETHER_ADDR_LEN) &&
+			     (mfilter->flags ==
+			      HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_DROP) &&
+			     (mfilter->ethertype == efilter->ether_type))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mfilter->ethertype == efilter->ether_type'
#182: FILE: drivers/net/bnxt/bnxt_ethdev.c:1693:
+			if ((!memcmp(efilter->mac_addr.addr_bytes,
+				     mfilter->l2_addr, ETHER_ADDR_LEN) &&
+			     (mfilter->ethertype == efilter->ether_type) &&
+			     (mfilter->flags ==
+			      HWRM_CFA_L2_FILTER_CFG_INPUT_FLAGS_PATH_RX))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mfilter->flags ==
 			      HWRM_CFA_L2_FILTER_CFG_INPUT_FLAGS_PATH_RX'
#182: FILE: drivers/net/bnxt/bnxt_ethdev.c:1693:
+			if ((!memcmp(efilter->mac_addr.addr_bytes,
+				     mfilter->l2_addr, ETHER_ADDR_LEN) &&
+			     (mfilter->ethertype == efilter->ether_type) &&
+			     (mfilter->flags ==
+			      HWRM_CFA_L2_FILTER_CFG_INPUT_FLAGS_PATH_RX))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vxlan_spec->flags != 0x8'
#809: FILE: drivers/net/bnxt/bnxt_filter.c:613:
+			if (vxlan_spec->rsvd1 || vxlan_spec->rsvd0[0] ||
+			    vxlan_spec->rsvd0[1] || vxlan_spec->rsvd0[2] ||
+			    (vxlan_spec->flags != 0x8)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nvgre_spec->c_k_s_rsvd0_ver != 0x2000'
#858: FILE: drivers/net/bnxt/bnxt_filter.c:662:
+			if ((nvgre_spec->c_k_s_rsvd0_ver != 0x2000) ||
+			    (nvgre_spec->protocol != 0x6558)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nvgre_spec->protocol != 0x6558'
#858: FILE: drivers/net/bnxt/bnxt_filter.c:662:
+			if ((nvgre_spec->c_k_s_rsvd0_ver != 0x2000) ||
+			    (nvgre_spec->protocol != 0x6558)) {

total: 0 errors, 0 warnings, 9 checks, 1699 lines checked