[dpdk-test-report] |WARNING| pw37955 [PATCH] examples/l3fwd: adding event queue support

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/37955

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#24: 
Cc: Sunil Kumar Kori <sunil.kori at nxp.com>; Hemant Agrawal <hemant.agrawal at nxp.com>

ERROR:TRAILING_WHITESPACE: trailing whitespace
#98: FILE: examples/l3fwd/l3fwd.h:95:
+extern int numa_on; /**< NUMA is enabled by default. */ extern uint16_t $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#305: FILE: examples/l3fwd/l3fwd_eventdev.c:58:
+static struct adapter_params rx_adapter_config; struct link_params $

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#310: FILE: examples/l3fwd/l3fwd_eventdev.c:63:
+int
+parse_eventdev_config(const char *evq_arg) {

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#336: FILE: examples/l3fwd/l3fwd_eventdev.c:89:
+		if ((p0 = strchr(p, ')')) == NULL)

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#373: FILE: examples/l3fwd/l3fwd_eventdev.c:126:
+int
+parse_adapter_config(const char *evq_arg) {

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#397: FILE: examples/l3fwd/l3fwd_eventdev.c:150:
+		if ((p0 = strchr(p, ')')) == NULL)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#464: FILE: examples/l3fwd/l3fwd_eventdev.c:217:
+		if ((p0 = strchr(p, ')')) == NULL)

WARNING:LONG_LINE: line over 90 characters
#607: FILE: examples/l3fwd/l3fwd_eventdev.c:360:
+					rx_adapter_config.config[i].connections[j].eventdev_id,

WARNING:LONG_LINE: line over 90 characters
#640: FILE: examples/l3fwd/l3fwd_eventdev.c:393:
+				rx_adapter_config.config[i].connections[j].ethdev_rx_qid_mode;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#672: FILE: examples/l3fwd/l3fwd_eventdev.c:425:
+	unsigned nb_ports;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#674: FILE: examples/l3fwd/l3fwd_eventdev.c:427:
+	unsigned lcore_id;

WARNING:LONG_LINE: line over 90 characters
#690: FILE: examples/l3fwd/l3fwd_eventdev.c:443:
+			queueid = rx_adapter_config.config[i].connections[j].ethdev_rx_qid;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#726: FILE: examples/l3fwd/l3fwd_eventdev.c:479:
+		if ((enabled_port_mask & (1 << portid)) == 0) {
+			continue;
+		}

ERROR:TRAILING_WHITESPACE: trailing whitespace
#855: FILE: examples/l3fwd/l3fwd_eventdev.h:66:
+extern struct eventdev_info *event_devices; extern enum dequeue_mode $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#865: FILE: examples/l3fwd/l3fwd_eventdev.h:76:
+parse_eventdev_config(const char *evq_arg); int $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#866: FILE: examples/l3fwd/l3fwd_eventdev.h:77:
+parse_adapter_config(const char *evq_arg); int parse_link_config(const $

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#1080: FILE: examples/l3fwd/main.c:311:
+^I^I"  ^I^I^I1: Dequeue packet via eventdev
"$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#1129: FILE: examples/l3fwd/main.c:661:
+/* Parse the argument given in the command line of the application */ $

ERROR:OPEN_BRACE: open brace '{' following function declarations go on the next line
#1130: FILE: examples/l3fwd/main.c:662:
+static int parse_args_eventdev(int argc, char **argv) {

ERROR:TRAILING_WHITESPACE: trailing whitespace
#1288: FILE: examples/l3fwd/main.c:820:
+/* Parse the argument given in the command line of the application */ $

ERROR:OPEN_BRACE: open brace '{' following function declarations go on the next line
#1289: FILE: examples/l3fwd/main.c:821:
+static int parse_args(int argc, char **argv) {

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 32)
#1301: FILE: examples/l3fwd/main.c:833:
+		if (opt == CMD_LINE_OPT_DEQUEUE_MODE_NUM)  {
+				dq_mode = strtoul(optarg, &end, 10);

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#1317: FILE: examples/l3fwd/main.c:849:
+void
 check_all_ports_link_status(uint16_t port_num, uint32_t port_mask)  {  #define CHECK_INTERVAL 100 /* 100ms */ @@ -761,7 +972,7 @@ signal_handler(int signum)

total: 15 errors, 9 warnings, 1247 lines checked