[dpdk-test-report] |WARNING| pw35281 [PATCH 48/80] net/sfc/base: move port config to ef10 NIC board config

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Feb 20 08:46:37 CET 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35281

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#52: FILE: drivers/net/sfc/base/ef10_nic.c:1470:
+static	__checkReturn	efx_rc_t

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#60: FILE: drivers/net/sfc/base/ef10_nic.c:1549:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#61: FILE: drivers/net/sfc/base/ef10_nic.c:1550:
+	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#66: FILE: drivers/net/sfc/base/ef10_nic.c:1555:
+	if ((rc = efx_mcdi_get_port_assignment(enp, &port)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#72: FILE: drivers/net/sfc/base/ef10_nic.c:1561:
+	if ((rc = ef10_external_port_mapping(enp, port,

total: 2 errors, 0 warnings, 3 checks, 453 lines checked


More information about the test-report mailing list