[dpdk-test-report] |WARNING| pw32967 [PATCH v2 02/16] net/axgbe: add register map and related macros
checkpatch at dpdk.org
checkpatch at dpdk.org
Fri Jan 5 10:54:04 CET 2018
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32967
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_var' - possible side-effects?
#1313: FILE: drivers/net/axgbe/axgbe_common.h:1458:
+#define SET_BITS(_var, _index, _width, _val) \
+do { \
+ (_var) &= ~(((0x1 << (_width)) - 1) << (_index)); \
+ (_var) |= (((_val) & ((0x1 << (_width)) - 1)) << (_index)); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_index' - possible side-effects?
#1313: FILE: drivers/net/axgbe/axgbe_common.h:1458:
+#define SET_BITS(_var, _index, _width, _val) \
+do { \
+ (_var) &= ~(((0x1 << (_width)) - 1) << (_index)); \
+ (_var) |= (((_val) & ((0x1 << (_width)) - 1)) << (_index)); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_width' - possible side-effects?
#1313: FILE: drivers/net/axgbe/axgbe_common.h:1458:
+#define SET_BITS(_var, _index, _width, _val) \
+do { \
+ (_var) &= ~(((0x1 << (_width)) - 1) << (_index)); \
+ (_var) |= (((_val) & ((0x1 << (_width)) - 1)) << (_index)); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_var' - possible side-effects?
#1322: FILE: drivers/net/axgbe/axgbe_common.h:1467:
+#define SET_BITS_LE(_var, _index, _width, _val) \
+do { \
+ (_var) &= rte_cpu_to_le_32(~(((0x1 << (_width)) - 1) << (_index)));\
+ (_var) |= rte_cpu_to_le_32((((_val) & \
+ ((0x1 << (_width)) - 1)) << (_index))); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_index' - possible side-effects?
#1322: FILE: drivers/net/axgbe/axgbe_common.h:1467:
+#define SET_BITS_LE(_var, _index, _width, _val) \
+do { \
+ (_var) &= rte_cpu_to_le_32(~(((0x1 << (_width)) - 1) << (_index)));\
+ (_var) |= rte_cpu_to_le_32((((_val) & \
+ ((0x1 << (_width)) - 1)) << (_index))); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_width' - possible side-effects?
#1322: FILE: drivers/net/axgbe/axgbe_common.h:1467:
+#define SET_BITS_LE(_var, _index, _width, _val) \
+do { \
+ (_var) &= rte_cpu_to_le_32(~(((0x1 << (_width)) - 1) << (_index)));\
+ (_var) |= rte_cpu_to_le_32((((_val) & \
+ ((0x1 << (_width)) - 1)) << (_index))); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects?
#1375: FILE: drivers/net/axgbe/axgbe_common.h:1520:
+#define AXGMAC_IOWRITE_BITS(_pdata, _reg, _field, _val) \
+do { \
+ u32 reg_val = AXGMAC_IOREAD((_pdata), _reg); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ AXGMAC_IOWRITE((_pdata), _reg, reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_reg' - possible side-effects?
#1375: FILE: drivers/net/axgbe/axgbe_common.h:1520:
+#define AXGMAC_IOWRITE_BITS(_pdata, _reg, _field, _val) \
+do { \
+ u32 reg_val = AXGMAC_IOREAD((_pdata), _reg); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ AXGMAC_IOWRITE((_pdata), _reg, reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects?
#1401: FILE: drivers/net/axgbe/axgbe_common.h:1546:
+#define AXGMAC_MTL_IOWRITE_BITS(_pdata, _n, _reg, _field, _val) \
+do { \
+ u32 reg_val = AXGMAC_MTL_IOREAD((_pdata), (_n), _reg); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ AXGMAC_MTL_IOWRITE((_pdata), (_n), _reg, reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_n' - possible side-effects?
#1401: FILE: drivers/net/axgbe/axgbe_common.h:1546:
+#define AXGMAC_MTL_IOWRITE_BITS(_pdata, _n, _reg, _field, _val) \
+do { \
+ u32 reg_val = AXGMAC_MTL_IOREAD((_pdata), (_n), _reg); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ AXGMAC_MTL_IOWRITE((_pdata), (_n), _reg, reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_reg' - possible side-effects?
#1401: FILE: drivers/net/axgbe/axgbe_common.h:1546:
+#define AXGMAC_MTL_IOWRITE_BITS(_pdata, _n, _reg, _field, _val) \
+do { \
+ u32 reg_val = AXGMAC_MTL_IOREAD((_pdata), (_n), _reg); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ AXGMAC_MTL_IOWRITE((_pdata), (_n), _reg, reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_channel' - possible side-effects?
#1425: FILE: drivers/net/axgbe/axgbe_common.h:1570:
+#define AXGMAC_DMA_IOWRITE_BITS(_channel, _reg, _field, _val) \
+do { \
+ u32 reg_val = AXGMAC_DMA_IOREAD((_channel), _reg); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ AXGMAC_DMA_IOWRITE((_channel), _reg, reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_reg' - possible side-effects?
#1425: FILE: drivers/net/axgbe/axgbe_common.h:1570:
+#define AXGMAC_DMA_IOWRITE_BITS(_channel, _reg, _field, _val) \
+do { \
+ u32 reg_val = AXGMAC_DMA_IOREAD((_channel), _reg); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ AXGMAC_DMA_IOWRITE((_channel), _reg, reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects?
#1483: FILE: drivers/net/axgbe/axgbe_common.h:1628:
+#define XSIR0_IOWRITE_BITS(_pdata, _reg, _field, _val) \
+do { \
+ u16 reg_val = XSIR0_IOREAD((_pdata), _reg); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ XSIR0_IOWRITE((_pdata), _reg, reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_reg' - possible side-effects?
#1483: FILE: drivers/net/axgbe/axgbe_common.h:1628:
+#define XSIR0_IOWRITE_BITS(_pdata, _reg, _field, _val) \
+do { \
+ u16 reg_val = XSIR0_IOREAD((_pdata), _reg); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ XSIR0_IOWRITE((_pdata), _reg, reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects?
#1503: FILE: drivers/net/axgbe/axgbe_common.h:1648:
+#define XSIR1_IOWRITE_BITS(_pdata, _reg, _field, _val) \
+do { \
+ u16 reg_val = XSIR1_IOREAD((_pdata), _reg); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ XSIR1_IOWRITE((_pdata), _reg, reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_reg' - possible side-effects?
#1503: FILE: drivers/net/axgbe/axgbe_common.h:1648:
+#define XSIR1_IOWRITE_BITS(_pdata, _reg, _field, _val) \
+do { \
+ u16 reg_val = XSIR1_IOREAD((_pdata), _reg); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ XSIR1_IOWRITE((_pdata), _reg, reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects?
#1526: FILE: drivers/net/axgbe/axgbe_common.h:1671:
+#define XRXTX_IOWRITE_BITS(_pdata, _reg, _field, _val) \
+do { \
+ u16 reg_val = XRXTX_IOREAD((_pdata), _reg); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ XRXTX_IOWRITE((_pdata), _reg, reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_reg' - possible side-effects?
#1526: FILE: drivers/net/axgbe/axgbe_common.h:1671:
+#define XRXTX_IOWRITE_BITS(_pdata, _reg, _field, _val) \
+do { \
+ u16 reg_val = XRXTX_IOREAD((_pdata), _reg); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ XRXTX_IOWRITE((_pdata), _reg, reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects?
#1559: FILE: drivers/net/axgbe/axgbe_common.h:1704:
+#define XP_IOWRITE_BITS(_pdata, _reg, _field, _val) \
+do { \
+ u32 reg_val = XP_IOREAD((_pdata), (_reg)); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ XP_IOWRITE((_pdata), (_reg), reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_reg' - possible side-effects?
#1559: FILE: drivers/net/axgbe/axgbe_common.h:1704:
+#define XP_IOWRITE_BITS(_pdata, _reg, _field, _val) \
+do { \
+ u32 reg_val = XP_IOREAD((_pdata), (_reg)); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ XP_IOWRITE((_pdata), (_reg), reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects?
#1592: FILE: drivers/net/axgbe/axgbe_common.h:1737:
+#define XI2C_IOWRITE_BITS(_pdata, _reg, _field, _val) \
+do { \
+ u32 reg_val = XI2C_IOREAD((_pdata), (_reg)); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ XI2C_IOWRITE((_pdata), (_reg), reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_reg' - possible side-effects?
#1592: FILE: drivers/net/axgbe/axgbe_common.h:1737:
+#define XI2C_IOWRITE_BITS(_pdata, _reg, _field, _val) \
+do { \
+ u32 reg_val = XI2C_IOREAD((_pdata), (_reg)); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ XI2C_IOWRITE((_pdata), (_reg), reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects?
#1606: FILE: drivers/net/axgbe/axgbe_common.h:1751:
+#define XMDIO_READ(_pdata, _mmd, _reg) \
+ ((_pdata)->hw_if.read_mmd_regs((_pdata), 0, \
+ MII_ADDR_C45 | ((_mmd) << 16) | ((_reg) & 0xffff)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects?
#1613: FILE: drivers/net/axgbe/axgbe_common.h:1758:
+#define XMDIO_WRITE(_pdata, _mmd, _reg, _val) \
+ ((_pdata)->hw_if.write_mmd_regs((_pdata), 0, \
+ MII_ADDR_C45 | ((_mmd) << 16) | ((_reg) & 0xffff), (_val)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects?
#1617: FILE: drivers/net/axgbe/axgbe_common.h:1762:
+#define XMDIO_WRITE_BITS(_pdata, _mmd, _reg, _mask, _val) \
+do { \
+ u32 mmd_val = XMDIO_READ((_pdata), (_mmd), (_reg)); \
+ mmd_val &= ~(_mask); \
+ mmd_val |= (_val); \
+ XMDIO_WRITE((_pdata), (_mmd), (_reg), (mmd_val)); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_mmd' - possible side-effects?
#1617: FILE: drivers/net/axgbe/axgbe_common.h:1762:
+#define XMDIO_WRITE_BITS(_pdata, _mmd, _reg, _mask, _val) \
+do { \
+ u32 mmd_val = XMDIO_READ((_pdata), (_mmd), (_reg)); \
+ mmd_val &= ~(_mask); \
+ mmd_val |= (_val); \
+ XMDIO_WRITE((_pdata), (_mmd), (_reg), (mmd_val)); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_reg' - possible side-effects?
#1617: FILE: drivers/net/axgbe/axgbe_common.h:1762:
+#define XMDIO_WRITE_BITS(_pdata, _mmd, _reg, _mask, _val) \
+do { \
+ u32 mmd_val = XMDIO_READ((_pdata), (_mmd), (_reg)); \
+ mmd_val &= ~(_mask); \
+ mmd_val |= (_val); \
+ XMDIO_WRITE((_pdata), (_mmd), (_reg), (mmd_val)); \
+} while (0)
total: 0 errors, 0 warnings, 28 checks, 1648 lines checked
More information about the test-report
mailing list