[dpdk-test-report] |WARNING| pw33128 [PATCH 2/2] event/sw: use dynamically-sized IQs

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Jan 8 19:37:22 CET 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/33128

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#19: 
Thanks for the report and the GDB output. We've reproduced this and traced it down to how the PMD (mis)handles the re-configuration case. When the SW PMD is reconfigured, it reallocates the IQ chunks and reinitializes the chunk freelist, but it doesn't delete the stale pointers in sw->qids[*].iq. This causes multiple references to the same IQ memory to exist in the system, eventually resulting in the segfault.

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#284: FILE: drivers/event/sw/sw_evdev.c:438:
        if (sw->chunks)
+               return 0;

ERROR:CODE_INDENT: code indent should use tabs where possible
#286: FILE: drivers/event/sw/sw_evdev.c:439:
+               return 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#286: FILE: drivers/event/sw/sw_evdev.c:439:
+               return 0;$

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 2 errors, 3 warnings, 8 lines checked


More information about the test-report mailing list