[dpdk-test-report] |WARNING| pw40882 [PATCH v10 3/5] net/netvsc: add hyper-v netvsc network device

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Jun 8 19:00:49 CEST 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/40882

_coding style issues_


WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#160: FILE: drivers/net/netvsc/hn_ethdev.c:1:
+/* SPDX-License-Identifier: BSD-3-Clause

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#348: FILE: drivers/net/netvsc/hn_ethdev.c:189:
+	dev_info->flow_type_rss_offloads
+		= ETH_RSS_IPV4 | ETH_RSS_IPV6 | ETH_RSS_TCP | ETH_RSS_UDP;

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#451: FILE: drivers/net/netvsc/hn_ethdev.c:292:
+	const struct rte_eth_rss_conf *rss_conf
+		= &dev_conf->rx_adv_conf.rss_conf;

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#461: FILE: drivers/net/netvsc/hn_ethdev.c:302:
+			    "unsupported TX offload: %#" PRIx64,

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#621: FILE: drivers/net/netvsc/hn_ethdev.c:462:
+	const unsigned int nstats
+		= dev->data->nb_tx_queues * RTE_DIM(hn_stat_strings)

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#966: FILE: drivers/net/netvsc/hn_nvs.c:1:
+/* SPDX-License-Identifier: BSD-3-Clause

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#1758: FILE: drivers/net/netvsc/hn_rndis.c:1:
+/* SPDX-License-Identifier: BSD-3-Clause

CHECK:CAMELCASE: Avoid CamelCase: <PRIx32>
#2477: FILE: drivers/net/netvsc/hn_rndis.c:720:
+		PMD_DRV_LOG(ERR, "exec RNDIS set %#" PRIx32 " failed",

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#2893: FILE: drivers/net/netvsc/hn_rxtx.c:1:
+/* SPDX-License-Identifier: BSD-3-Clause

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#3333: FILE: drivers/net/netvsc/hn_rxtx.c:441:
+		struct rte_eth_dev *dev
+			= &rte_eth_devices[rxq->port_id];

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ofs' - possible side-effects?
#3417: FILE: drivers/net/netvsc/hn_rxtx.c:525:
+#define IS_OFFSET_INVALID(ofs)			\
+	((ofs) < RNDIS_PACKET_MSG_OFFSET_MIN ||	\
+	 ((ofs) & RNDIS_PACKET_MSG_OFFSET_ALIGNMASK))

total: 0 errors, 4 warnings, 4929 lines checked


More information about the test-report mailing list