[dpdk-test-report] |WARNING| pw41212 [v2] [PATCH 18/22] net/softnic: add cli for meter action

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Jun 15 18:54:49 CEST 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/41212

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dscp_table == NULL'
#277: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3663:
+	if ((dscp_table == NULL) ||
+		(file_name == NULL) ||
+		(line_number == NULL)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'file_name == NULL'
#277: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3663:
+	if ((dscp_table == NULL) ||
+		(file_name == NULL) ||
+		(line_number == NULL)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'line_number == NULL'
#277: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3663:
+	if ((dscp_table == NULL) ||
+		(file_name == NULL) ||
+		(line_number == NULL)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dscp >= RTE_DIM(dscp_table->entry)'
#314: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3700:
+		if ((dscp >= RTE_DIM(dscp_table->entry)) ||
+			(n_tokens != RTE_DIM(tokens)) ||
+			softnic_parser_read_uint32(&tc_id, tokens[0]) ||
+			(tc_id >= RTE_TABLE_ACTION_TC_MAX) ||
+			softnic_parser_read_uint32(&tc_queue_id, tokens[1]) ||
+			(tc_queue_id >= RTE_TABLE_ACTION_TC_QUEUE_MAX) ||
+			(strlen(tokens[2]) != 1)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens != RTE_DIM(tokens)'
#314: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3700:
+		if ((dscp >= RTE_DIM(dscp_table->entry)) ||
+			(n_tokens != RTE_DIM(tokens)) ||
+			softnic_parser_read_uint32(&tc_id, tokens[0]) ||
+			(tc_id >= RTE_TABLE_ACTION_TC_MAX) ||
+			softnic_parser_read_uint32(&tc_queue_id, tokens[1]) ||
+			(tc_queue_id >= RTE_TABLE_ACTION_TC_QUEUE_MAX) ||
+			(strlen(tokens[2]) != 1)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tc_id >= RTE_TABLE_ACTION_TC_MAX'
#314: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3700:
+		if ((dscp >= RTE_DIM(dscp_table->entry)) ||
+			(n_tokens != RTE_DIM(tokens)) ||
+			softnic_parser_read_uint32(&tc_id, tokens[0]) ||
+			(tc_id >= RTE_TABLE_ACTION_TC_MAX) ||
+			softnic_parser_read_uint32(&tc_queue_id, tokens[1]) ||
+			(tc_queue_id >= RTE_TABLE_ACTION_TC_QUEUE_MAX) ||
+			(strlen(tokens[2]) != 1)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tc_queue_id >= RTE_TABLE_ACTION_TC_QUEUE_MAX'
#314: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3700:
+		if ((dscp >= RTE_DIM(dscp_table->entry)) ||
+			(n_tokens != RTE_DIM(tokens)) ||
+			softnic_parser_read_uint32(&tc_id, tokens[0]) ||
+			(tc_id >= RTE_TABLE_ACTION_TC_MAX) ||
+			softnic_parser_read_uint32(&tc_queue_id, tokens[1]) ||
+			(tc_queue_id >= RTE_TABLE_ACTION_TC_QUEUE_MAX) ||
+			(strlen(tokens[2]) != 1)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 8'
#421: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:4072:
+		if ((n_tokens >= 8) &&
+			(strcmp(tokens[2], "table") == 0) &&
+			(strcmp(tokens[4], "meter") == 0) &&
+			(strcmp(tokens[5], "profile") == 0) &&
+			(strcmp(tokens[7], "add") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 8'
#431: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:4082:
+		if ((n_tokens >= 8) &&
+			(strcmp(tokens[2], "table") == 0) &&
+			(strcmp(tokens[4], "meter") == 0) &&
+			(strcmp(tokens[5], "profile") == 0) &&
+			(strcmp(tokens[7], "delete") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 7'
#441: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:4092:
+		if ((n_tokens >= 7) &&
+			(strcmp(tokens[2], "table") == 0) &&
+			(strcmp(tokens[4], "rule") == 0) &&
+			(strcmp(tokens[5], "read") == 0) &&
+			(strcmp(tokens[6], "meter") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 5'
#451: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:4102:
+		if ((n_tokens >= 5) &&
+			(strcmp(tokens[2], "table") == 0) &&
+			(strcmp(tokens[4], "dscp") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL'
#591: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1402:
+	if ((pipeline_name == NULL) ||
+		(profile == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'profile == NULL'
#591: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1402:
+	if ((pipeline_name == NULL) ||
+		(profile == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#596: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1407:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(table_id >= p->n_tables))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->enabled == 0'
#596: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1407:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(table_id >= p->n_tables))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table_id >= p->n_tables'
#596: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1407:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(table_id >= p->n_tables))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#642: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1453:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(table_id >= p->n_tables))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->enabled == 0'
#642: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1453:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(table_id >= p->n_tables))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table_id >= p->n_tables'
#642: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1453:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(table_id >= p->n_tables))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL'
#686: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1497:
+	if ((pipeline_name == NULL) ||
+		(data == NULL) ||
+		(stats == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'data == NULL'
#686: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1497:
+	if ((pipeline_name == NULL) ||
+		(data == NULL) ||
+		(stats == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'stats == NULL'
#686: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1497:
+	if ((pipeline_name == NULL) ||
+		(data == NULL) ||
+		(stats == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#692: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1503:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(table_id >= p->n_tables))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->enabled == 0'
#692: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1503:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(table_id >= p->n_tables))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table_id >= p->n_tables'
#692: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1503:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(table_id >= p->n_tables))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL'
#738: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1549:
+	if ((pipeline_name == NULL) ||
+		(dscp_table == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dscp_table == NULL'
#738: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1549:
+	if ((pipeline_name == NULL) ||
+		(dscp_table == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#743: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1554:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(table_id >= p->n_tables))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->enabled == 0'
#743: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1554:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(table_id >= p->n_tables))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table_id >= p->n_tables'
#743: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1554:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(table_id >= p->n_tables))

CHECK:SPACING: No space is necessary after a cast
#785: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:2412:
+	struct pipeline_msg_rsp *rsp = (struct pipeline_msg_rsp *) req;

CHECK:SPACING: No space is necessary after a cast
#803: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:2430:
+	struct pipeline_msg_rsp *rsp = (struct pipeline_msg_rsp *) req;

CHECK:SPACING: No space is necessary after a cast
#819: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:2446:
+	struct pipeline_msg_rsp *rsp = (struct pipeline_msg_rsp *) req;

CHECK:SPACING: No space is necessary after a cast
#839: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:2466:
+	struct pipeline_msg_rsp *rsp = (struct pipeline_msg_rsp *) req;

total: 0 errors, 0 warnings, 34 checks, 831 lines checked


More information about the test-report mailing list