[dpdk-test-report] |WARNING| pw41213 [v2] [PATCH 19/22] net/softnic: add cli for ttl action

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Jun 15 18:54:49 CEST 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/41213

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 7'
#54: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:4123:
+		if ((n_tokens >= 7) &&
+			(strcmp(tokens[2], "table") == 0) &&
+			(strcmp(tokens[4], "rule") == 0) &&
+			(strcmp(tokens[5], "read") == 0) &&
+			(strcmp(tokens[6], "ttl") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL'
#154: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1611:
+	if ((pipeline_name == NULL) ||
+		(data == NULL) ||
+		(stats == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'data == NULL'
#154: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1611:
+	if ((pipeline_name == NULL) ||
+		(data == NULL) ||
+		(stats == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'stats == NULL'
#154: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1611:
+	if ((pipeline_name == NULL) ||
+		(data == NULL) ||
+		(stats == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#160: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1617:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(table_id >= p->n_tables))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->enabled == 0'
#160: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1617:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(table_id >= p->n_tables))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table_id >= p->n_tables'
#160: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1617:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(table_id >= p->n_tables))

CHECK:SPACING: No space is necessary after a cast
#203: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:2548:
+	struct pipeline_msg_rsp *rsp = (struct pipeline_msg_rsp *) req;

total: 0 errors, 0 warnings, 8 checks, 183 lines checked


More information about the test-report mailing list