[dpdk-test-report] |WARNING| pw35666 [PATCH RFC 1/4] drivers/bus/ifpga:Intel FPGA Bus Lib Code

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Mar 6 02:43:27 CET 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35666

_coding style issues_


ERROR:TRAILING_WHITESPACE: trailing whitespace
#195: FILE: drivers/bus/ifpga/ifpga_bus.c:87:
+^I$

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#196: FILE: drivers/bus/ifpga/ifpga_bus.c:88:
+	TAILQ_FOREACH (afu_dev, &rte_ifpga_bus.afu_list, next) {

ERROR:CODE_INDENT: code indent should use tabs where possible
#198: FILE: drivers/bus/ifpga/ifpga_bus.c:90:
+        if(!ifpga_afu_id_cmp(&afu_dev->id, afu_id)) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#198: FILE: drivers/bus/ifpga/ifpga_bus.c:90:
+        if(!ifpga_afu_id_cmp(&afu_dev->id, afu_id)) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#198: FILE: drivers/bus/ifpga/ifpga_bus.c:90:
+        if(!ifpga_afu_id_cmp(&afu_dev->id, afu_id)) {
+            return afu_dev;

ERROR:SPACING: space required before the open parenthesis '('
#198: FILE: drivers/bus/ifpga/ifpga_bus.c:90:
+        if(!ifpga_afu_id_cmp(&afu_dev->id, afu_id)) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#198: FILE: drivers/bus/ifpga/ifpga_bus.c:90:
+        if(!ifpga_afu_id_cmp(&afu_dev->id, afu_id)) {
+            return afu_dev;
+        }

ERROR:CODE_INDENT: code indent should use tabs where possible
#199: FILE: drivers/bus/ifpga/ifpga_bus.c:91:
+            return afu_dev;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#199: FILE: drivers/bus/ifpga/ifpga_bus.c:91:
+            return afu_dev;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#200: FILE: drivers/bus/ifpga/ifpga_bus.c:92:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#200: FILE: drivers/bus/ifpga/ifpga_bus.c:92:
+        }$

WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#205: FILE: drivers/bus/ifpga/ifpga_bus.c:97:
+static const char *valid_args[] = {

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#242: FILE: drivers/bus/ifpga/ifpga_bus.c:134:
+    memset((char *)(&afu_pr_conf), 0, sizeof(struct rte_afu_pr_conf));$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#243: FILE: drivers/bus/ifpga/ifpga_bus.c:135:
+^I$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#244: FILE: drivers/bus/ifpga/ifpga_bus.c:136:
+    kvlist = rte_kvargs_parse(devargs->args, valid_args);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#245: FILE: drivers/bus/ifpga/ifpga_bus.c:137:
+    if (!kvlist) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#246: FILE: drivers/bus/ifpga/ifpga_bus.c:138:
+    ^IIFPGA_BUS_ERR("error when parsing param");$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#246: FILE: drivers/bus/ifpga/ifpga_bus.c:138:
+    ^IIFPGA_BUS_ERR("error when parsing param");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#246: FILE: drivers/bus/ifpga/ifpga_bus.c:138:
+    ^IIFPGA_BUS_ERR("error when parsing param");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#247: FILE: drivers/bus/ifpga/ifpga_bus.c:139:
+    ^Igoto end;$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#247: FILE: drivers/bus/ifpga/ifpga_bus.c:139:
+    ^Igoto end;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#247: FILE: drivers/bus/ifpga/ifpga_bus.c:139:
+    ^Igoto end;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#248: FILE: drivers/bus/ifpga/ifpga_bus.c:140:
+    }$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#249: FILE: drivers/bus/ifpga/ifpga_bus.c:141:
+    $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#249: FILE: drivers/bus/ifpga/ifpga_bus.c:141:
+    $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#250: FILE: drivers/bus/ifpga/ifpga_bus.c:142:
+    if (rte_kvargs_count(kvlist, IFPGA_ARG_BDF) == 1) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (4, 16)
#250: FILE: drivers/bus/ifpga/ifpga_bus.c:142:
+    if (rte_kvargs_count(kvlist, IFPGA_ARG_BDF) == 1) {
+		if (rte_kvargs_process(kvlist, IFPGA_ARG_BDF,

WARNING:LONG_LINE: line over 90 characters
#252: FILE: drivers/bus/ifpga/ifpga_bus.c:144:
+				       &ifpga_get_bdf_arg, &afu_pr_conf.afu_id.pci_addr) < 0) {

ERROR:TRAILING_WHITESPACE: trailing whitespace
#262: FILE: drivers/bus/ifpga/ifpga_bus.c:154:
+    $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#262: FILE: drivers/bus/ifpga/ifpga_bus.c:154:
+    $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#263: FILE: drivers/bus/ifpga/ifpga_bus.c:155:
+    if (rte_kvargs_count(kvlist, IFPGA_ARG_PORT) == 1) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (4, 16)
#263: FILE: drivers/bus/ifpga/ifpga_bus.c:155:
+    if (rte_kvargs_count(kvlist, IFPGA_ARG_PORT) == 1) {
+		if (rte_kvargs_process(kvlist, IFPGA_ARG_PORT,

WARNING:LONG_LINE: line over 90 characters
#265: FILE: drivers/bus/ifpga/ifpga_bus.c:157:
+				       &ifpga_get_integer32_arg, &afu_pr_conf.afu_id.port) < 0) {

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#271: FILE: drivers/bus/ifpga/ifpga_bus.c:163:
+	}
+	else {

ERROR:TRAILING_WHITESPACE: trailing whitespace
#276: FILE: drivers/bus/ifpga/ifpga_bus.c:168:
+^I$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#277: FILE: drivers/bus/ifpga/ifpga_bus.c:169:
+    if (rte_kvargs_count(kvlist, IFPGA_ARG_PATH) == 1) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (4, 16)
#277: FILE: drivers/bus/ifpga/ifpga_bus.c:169:
+    if (rte_kvargs_count(kvlist, IFPGA_ARG_PATH) == 1) {
+		if (rte_kvargs_process(kvlist, IFPGA_ARG_PATH,

ERROR:TRAILING_WHITESPACE: trailing whitespace
#289: FILE: drivers/bus/ifpga/ifpga_bus.c:181:
+^I$

WARNING:LONG_LINE: line over 90 characters
#292: FILE: drivers/bus/ifpga/ifpga_bus.c:184:
+				       &ifpga_get_integer64_arg, &afu_pr_conf.afu_id.uuid_high) < 0) {

ERROR:TRAILING_WHITESPACE: trailing whitespace
#302: FILE: drivers/bus/ifpga/ifpga_bus.c:194:
+^I$

WARNING:LONG_LINE: line over 90 characters
#305: FILE: drivers/bus/ifpga/ifpga_bus.c:197:
+				       &ifpga_get_integer64_arg, &afu_pr_conf.afu_id.uuid_low) < 0) {

ERROR:TRAILING_WHITESPACE: trailing whitespace
#315: FILE: drivers/bus/ifpga/ifpga_bus.c:207:
+^I$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#324: FILE: drivers/bus/ifpga/ifpga_bus.c:216:
+^I$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#333: FILE: drivers/bus/ifpga/ifpga_bus.c:225:
+^I$

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#334: FILE: drivers/bus/ifpga/ifpga_bus.c:226:
+	if(!debug)
+	{

ERROR:SPACING: space required before the open parenthesis '('
#334: FILE: drivers/bus/ifpga/ifpga_bus.c:226:
+	if(!debug)

WARNING:TABSTOP: Statements should start on a tabstop
#337: FILE: drivers/bus/ifpga/ifpga_bus.c:229:
+	    if (pci_bus == NULL) {

ERROR:CODE_INDENT: code indent should use tabs where possible
#338: FILE: drivers/bus/ifpga/ifpga_bus.c:230:
+^I    ^IIFPGA_BUS_ERR("unable to find PCI bus
");$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#338: FILE: drivers/bus/ifpga/ifpga_bus.c:230:
+^I    ^IIFPGA_BUS_ERR("unable to find PCI bus
");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#339: FILE: drivers/bus/ifpga/ifpga_bus.c:231:
+^I    ^Igoto end;$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#339: FILE: drivers/bus/ifpga/ifpga_bus.c:231:
+^I    ^Igoto end;$

WARNING:TABSTOP: Statements should start on a tabstop
#340: FILE: drivers/bus/ifpga/ifpga_bus.c:232:
+	    }

ERROR:TRAILING_WHITESPACE: trailing whitespace
#341: FILE: drivers/bus/ifpga/ifpga_bus.c:233:
+^I    $

WARNING:LONG_LINE: line over 90 characters
#342: FILE: drivers/bus/ifpga/ifpga_bus.c:234:
+	    dev = pci_bus->find_device(NULL, ifpga_pci_addr_cmp, &afu_pr_conf.afu_id.pci_addr);

WARNING:TABSTOP: Statements should start on a tabstop
#343: FILE: drivers/bus/ifpga/ifpga_bus.c:235:
+	    if (dev == NULL) {

ERROR:CODE_INDENT: code indent should use tabs where possible
#344: FILE: drivers/bus/ifpga/ifpga_bus.c:236:
+^I    ^IIFPGA_BUS_ERR("unable to find PCI device
");$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#344: FILE: drivers/bus/ifpga/ifpga_bus.c:236:
+^I    ^IIFPGA_BUS_ERR("unable to find PCI device
");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#345: FILE: drivers/bus/ifpga/ifpga_bus.c:237:
+^I    ^Igoto end;$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#345: FILE: drivers/bus/ifpga/ifpga_bus.c:237:
+^I    ^Igoto end;$

WARNING:TABSTOP: Statements should start on a tabstop
#346: FILE: drivers/bus/ifpga/ifpga_bus.c:238:
+	    }

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#348: FILE: drivers/bus/ifpga/ifpga_bus.c:240:
+	else
+	{

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#348: FILE: drivers/bus/ifpga/ifpga_bus.c:240:
+	}
+	else

WARNING:LONG_LINE: line over 90 characters
#350: FILE: drivers/bus/ifpga/ifpga_bus.c:242:
+		IFPGA_BUS_DEBUG("pci_addr domain   : %x
",   afu_pr_conf.afu_id.pci_addr.domain);

WARNING:LONG_LINE: line over 90 characters
#351: FILE: drivers/bus/ifpga/ifpga_bus.c:243:
+		IFPGA_BUS_DEBUG("pci_addr bus      : %x
",   afu_pr_conf.afu_id.pci_addr.bus);

WARNING:LONG_LINE: line over 90 characters
#352: FILE: drivers/bus/ifpga/ifpga_bus.c:244:
+		IFPGA_BUS_DEBUG("pci_addr devid    : %x
",   afu_pr_conf.afu_id.pci_addr.devid);

WARNING:LONG_LINE: line over 90 characters
#353: FILE: drivers/bus/ifpga/ifpga_bus.c:245:
+		IFPGA_BUS_DEBUG("pci_addr function : %x
",   afu_pr_conf.afu_id.pci_addr.function);

ERROR:TRAILING_WHITESPACE: trailing whitespace
#354: FILE: drivers/bus/ifpga/ifpga_bus.c:246:
+^I^I$

WARNING:LONG_LINE: line over 90 characters
#356: FILE: drivers/bus/ifpga/ifpga_bus.c:248:
+		IFPGA_BUS_DEBUG("uuid_high         : %lx
", afu_pr_conf.afu_id.uuid_high);

ERROR:TRAILING_WHITESPACE: trailing whitespace
#357: FILE: drivers/bus/ifpga/ifpga_bus.c:249:
+^I^I$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#360: FILE: drivers/bus/ifpga/ifpga_bus.c:252:
+^I$

ERROR:MEMSET: memset to 0's uses 0 as the 2nd argument, not the 3rd
#364: FILE: drivers/bus/ifpga/ifpga_bus.c:256:
+	memset(rawdev_name, sizeof(rawdev_name), 0);

WARNING:LONG_LINE: line over 90 characters
#365: FILE: drivers/bus/ifpga/ifpga_bus.c:257:
+	snprintf(rawdev_name, RTE_RAWDEV_NAME_MAX_LEN, "IFPGA:%x:%x:%x", afu_pr_conf.afu_id.pci_addr.bus, afu_pr_conf.afu_id.pci_addr.devid, afu_pr_conf.afu_id.pci_addr.function);

ERROR:SPACING: space required before the open parenthesis '('
#367: FILE: drivers/bus/ifpga/ifpga_bus.c:259:
+	if(!rawdev)

ERROR:TRAILING_WHITESPACE: trailing whitespace
#369: FILE: drivers/bus/ifpga/ifpga_bus.c:261:
+^I$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#371: FILE: drivers/bus/ifpga/ifpga_bus.c:263:
+^I^I$

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#372: FILE: drivers/bus/ifpga/ifpga_bus.c:264:
+	if (pr_enable)
+	{

ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#374: FILE: drivers/bus/ifpga/ifpga_bus.c:266:
+		ret=rawdev->dev_ops->firmware_load(rawdev, &afu_pr_conf);
 		   ^

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 16)
#375: FILE: drivers/bus/ifpga/ifpga_bus.c:267:
+		if (ret) {
+    		printf("do pr error
");

ERROR:CODE_INDENT: code indent should use tabs where possible
#376: FILE: drivers/bus/ifpga/ifpga_bus.c:268:
+    ^I^Iprintf("do pr error
");$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#376: FILE: drivers/bus/ifpga/ifpga_bus.c:268:
+    ^I^Iprintf("do pr error
");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#376: FILE: drivers/bus/ifpga/ifpga_bus.c:268:
+    ^I^Iprintf("do pr error
");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#377: FILE: drivers/bus/ifpga/ifpga_bus.c:269:
+    ^I^Ireturn NULL;$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#377: FILE: drivers/bus/ifpga/ifpga_bus.c:269:
+    ^I^Ireturn NULL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#377: FILE: drivers/bus/ifpga/ifpga_bus.c:269:
+    ^I^Ireturn NULL;$

WARNING:TABSTOP: Statements should start on a tabstop
#378: FILE: drivers/bus/ifpga/ifpga_bus.c:270:
+	    }

ERROR:TRAILING_WHITESPACE: trailing whitespace
#380: FILE: drivers/bus/ifpga/ifpga_bus.c:272:
+^I^I$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#396: FILE: drivers/bus/ifpga/ifpga_bus.c:288:
+^I$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#399: FILE: drivers/bus/ifpga/ifpga_bus.c:291:
+    return afu_dev;$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#400: FILE: drivers/bus/ifpga/ifpga_bus.c:292:
+    $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#400: FILE: drivers/bus/ifpga/ifpga_bus.c:292:
+    $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#406: FILE: drivers/bus/ifpga/ifpga_bus.c:298:
+^I$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#421: FILE: drivers/bus/ifpga/ifpga_bus.c:313:
+    pci_bus = rte_bus_find_by_name("pci");$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#426: FILE: drivers/bus/ifpga/ifpga_bus.c:318:
+^I$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#429: FILE: drivers/bus/ifpga/ifpga_bus.c:321:
+    $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#429: FILE: drivers/bus/ifpga/ifpga_bus.c:321:
+    $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#432: FILE: drivers/bus/ifpga/ifpga_bus.c:324:
+^I^I$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#434: FILE: drivers/bus/ifpga/ifpga_bus.c:326:
+^I    $

WARNING:TABSTOP: Statements should start on a tabstop
#435: FILE: drivers/bus/ifpga/ifpga_bus.c:327:
+	    if(afu_dev)

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (12, 20)
#435: FILE: drivers/bus/ifpga/ifpga_bus.c:327:
+	    if(afu_dev)
+		    TAILQ_INSERT_TAIL(&rte_ifpga_bus.afu_list, afu_dev, next);

ERROR:SPACING: space required before the open parenthesis '('
#435: FILE: drivers/bus/ifpga/ifpga_bus.c:327:
+	    if(afu_dev)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#448: FILE: drivers/bus/ifpga/ifpga_bus.c:340:
+    if((drv->id.pci_addr.bus == afu_dev->id.pci_addr.bus) &&$

ERROR:SPACING: space required before the open parenthesis '('
#448: FILE: drivers/bus/ifpga/ifpga_bus.c:340:
+    if((drv->id.pci_addr.bus == afu_dev->id.pci_addr.bus) &&

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#449: FILE: drivers/bus/ifpga/ifpga_bus.c:341:
+       (drv->id.pci_addr.devid == afu_dev->id.pci_addr.devid) &&$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#450: FILE: drivers/bus/ifpga/ifpga_bus.c:342:
+       (drv->id.pci_addr.function == afu_dev->id.pci_addr.function) &&$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#451: FILE: drivers/bus/ifpga/ifpga_bus.c:343:
+       (drv->id.uuid_low == afu_dev->id.uuid_low) &&$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#452: FILE: drivers/bus/ifpga/ifpga_bus.c:344:
+       (drv->id.uuid_high == afu_dev->id.uuid_high) &&$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#453: FILE: drivers/bus/ifpga/ifpga_bus.c:345:
+       (drv->id.port == afu_dev->id.port)) {$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#454: FILE: drivers/bus/ifpga/ifpga_bus.c:346:
+       ^I$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#454: FILE: drivers/bus/ifpga/ifpga_bus.c:346:
+       ^I$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#454: FILE: drivers/bus/ifpga/ifpga_bus.c:346:
+       ^I$

ERROR:CODE_INDENT: code indent should use tabs where possible
#455: FILE: drivers/bus/ifpga/ifpga_bus.c:347:
+       ^Iafu_dev->driver = drv;$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#455: FILE: drivers/bus/ifpga/ifpga_bus.c:347:
+       ^Iafu_dev->driver = drv;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#455: FILE: drivers/bus/ifpga/ifpga_bus.c:347:
+       ^Iafu_dev->driver = drv;$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#456: FILE: drivers/bus/ifpga/ifpga_bus.c:348:
+       ^I$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#456: FILE: drivers/bus/ifpga/ifpga_bus.c:348:
+       ^I$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#456: FILE: drivers/bus/ifpga/ifpga_bus.c:348:
+       ^I$

ERROR:CODE_INDENT: code indent should use tabs where possible
#457: FILE: drivers/bus/ifpga/ifpga_bus.c:349:
+       ^I/* call the driver probe() function */$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#457: FILE: drivers/bus/ifpga/ifpga_bus.c:349:
+       ^I/* call the driver probe() function */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#457: FILE: drivers/bus/ifpga/ifpga_bus.c:349:
+       ^I/* call the driver probe() function */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#462: FILE: drivers/bus/ifpga/ifpga_bus.c:354:
+    }$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#463: FILE: drivers/bus/ifpga/ifpga_bus.c:355:
+^I$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#481: FILE: drivers/bus/ifpga/ifpga_bus.c:373:
+^I^I$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#482: FILE: drivers/bus/ifpga/ifpga_bus.c:374:
+    name = rte_ifpga_device_name(afu_dev);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#483: FILE: drivers/bus/ifpga/ifpga_bus.c:375:
+    IFPGA_BUS_DEBUG("Search driver %s to probe device %s
", name,$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#485: FILE: drivers/bus/ifpga/ifpga_bus.c:377:
+    $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#485: FILE: drivers/bus/ifpga/ifpga_bus.c:377:
+    $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#497: FILE: drivers/bus/ifpga/ifpga_bus.c:389:
+ }$

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#510: FILE: drivers/bus/ifpga/ifpga_bus.c:402:
+	TAILQ_FOREACH (afu_dev, &rte_ifpga_bus.afu_list, next) {

ERROR:CODE_INDENT: code indent should use tabs where possible
#512: FILE: drivers/bus/ifpga/ifpga_bus.c:404:
+        if (afu_dev->device.driver)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#512: FILE: drivers/bus/ifpga/ifpga_bus.c:404:
+        if (afu_dev->device.driver)$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#512: FILE: drivers/bus/ifpga/ifpga_bus.c:404:
+        if (afu_dev->device.driver)
+			continue;

ERROR:TRAILING_WHITESPACE: trailing whitespace
#514: FILE: drivers/bus/ifpga/ifpga_bus.c:406:
+^I^I^I$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 20)
#516: FILE: drivers/bus/ifpga/ifpga_bus.c:408:
+		if (ret < 0)
+		    IFPGA_BUS_ERR("failed to initialize %s device
",

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#535: FILE: drivers/bus/ifpga/ifpga_bus.c:427:
+    name = rte_ifpga_device_name(afu_dev);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#579: FILE: drivers/bus/ifpga/ifpga_bus.c:471:
+^I^I                                        const void *data)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#625: FILE: drivers/bus/ifpga/ifpga_bus.c:517:
+ };$

ERROR:CODE_INDENT: code indent should use tabs where possible
#707: FILE: drivers/bus/ifpga/ifpga_common.c:66:
+^I                     const char *value, void *extra_args)$

WARNING:LONG_LINE: line over 90 characters
#719: FILE: drivers/bus/ifpga/ifpga_common.c:78:
+int ifpga_get_integer32_arg(const char *key __rte_unused, const char *value, void *extra_args)

WARNING:LONG_LINE: line over 90 characters
#728: FILE: drivers/bus/ifpga/ifpga_common.c:87:
+int ifpga_get_integer64_arg(const char *key __rte_unused, const char *value, void *extra_args)

ERROR:TRAILING_WHITESPACE: trailing whitespace
#758: FILE: drivers/bus/ifpga/ifpga_common.c:117:
+^I$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#762: FILE: drivers/bus/ifpga/ifpga_common.c:121:
+    addr = (struct rte_pci_addr *)extra_args;$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#790: FILE: drivers/bus/ifpga/ifpga_common.c:149:
+	if((afu_id0->pci_addr.bus       == afu_id1->pci_addr.bus) &&
[...]
+        return 0;

ERROR:SPACING: space required before the open parenthesis '('
#790: FILE: drivers/bus/ifpga/ifpga_common.c:149:
+	if((afu_id0->pci_addr.bus       == afu_id1->pci_addr.bus) &&

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#791: FILE: drivers/bus/ifpga/ifpga_common.c:150:
+       (afu_id0->pci_addr.devid     == afu_id1->pci_addr.devid) &&$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#792: FILE: drivers/bus/ifpga/ifpga_common.c:151:
+       (afu_id0->pci_addr.function  == afu_id1->pci_addr.function) &&$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#793: FILE: drivers/bus/ifpga/ifpga_common.c:152:
+       (afu_id0->uuid_low           == afu_id1->uuid_low) &&$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#794: FILE: drivers/bus/ifpga/ifpga_common.c:153:
+       (afu_id0->uuid_high          == afu_id1->uuid_high) &&$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#795: FILE: drivers/bus/ifpga/ifpga_common.c:154:
+       (afu_id0->port               == afu_id1->port)) {$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#796: FILE: drivers/bus/ifpga/ifpga_common.c:155:
+       ^I$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#796: FILE: drivers/bus/ifpga/ifpga_common.c:155:
+       ^I$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#796: FILE: drivers/bus/ifpga/ifpga_common.c:155:
+       ^I$

ERROR:CODE_INDENT: code indent should use tabs where possible
#797: FILE: drivers/bus/ifpga/ifpga_common.c:156:
+        return 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#797: FILE: drivers/bus/ifpga/ifpga_common.c:156:
+        return 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#798: FILE: drivers/bus/ifpga/ifpga_common.c:157:
+    }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#799: FILE: drivers/bus/ifpga/ifpga_common.c:158:
+    else$

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#799: FILE: drivers/bus/ifpga/ifpga_common.c:158:
+    }
+    else

ERROR:CODE_INDENT: code indent should use tabs where possible
#800: FILE: drivers/bus/ifpga/ifpga_common.c:159:
+    ^Ireturn 1;$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#800: FILE: drivers/bus/ifpga/ifpga_common.c:159:
+    ^Ireturn 1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#800: FILE: drivers/bus/ifpga/ifpga_common.c:159:
+    ^Ireturn 1;$

WARNING:LONG_LINE: line over 90 characters
#853: FILE: drivers/bus/ifpga/ifpga_common.h:38:
+extern int ifpga_get_string_arg(const char *key __rte_unused, const char *value, void *extra_args);

WARNING:LONG_LINE: line over 90 characters
#854: FILE: drivers/bus/ifpga/ifpga_common.h:39:
+extern int ifpga_get_integer32_arg(const char *key __rte_unused, const char *value, void *extra_args);

WARNING:LONG_LINE: line over 90 characters
#855: FILE: drivers/bus/ifpga/ifpga_common.h:40:
+extern int ifpga_get_integer64_arg(const char *key __rte_unused, const char *value, void *extra_args);

WARNING:LONG_LINE: line over 90 characters
#857: FILE: drivers/bus/ifpga/ifpga_common.h:42:
+extern int ifpga_get_bdf_arg(const char *key __rte_unused, const char *value, void *extra_args);

WARNING:LONG_LINE: line over 90 characters
#858: FILE: drivers/bus/ifpga/ifpga_common.h:43:
+extern int ifpga_afu_id_cmp(const struct rte_afu_id *afu_id0, const struct rte_afu_id *afu_id1);

ERROR:SPACING: space required after that close brace '}'
#1004: FILE: drivers/bus/ifpga/rte_bus_ifpga.h:72:
+}__attribute__ ((packed));

ERROR:TRAILING_WHITESPACE: trailing whitespace
#1007: FILE: drivers/bus/ifpga/rte_bus_ifpga.h:75:
+ * A structure pr configuration AFU driver. $

WARNING:LONG_LINE_COMMENT: line over 90 characters
#1026: FILE: drivers/bus/ifpga/rte_bus_ifpga.h:94:
+	uint32_t num_region;						/**< number of regions found */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#1060: FILE: drivers/bus/ifpga/rte_bus_ifpga.h:128:
+	uint32_t drv_flags;                     /**< Flags contolling handling of device. */

ERROR:TRAILING_WHITESPACE: trailing whitespace
#1097: FILE: drivers/bus/ifpga/rte_bus_ifpga_version.map:6:
+    $

total: 67 errors, 102 warnings, 1025 lines checked


More information about the test-report mailing list