[dpdk-test-report] |WARNING| pw35874 [PATCH v1 5/5] test: add few eBPF samples

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Mar 9 17:44:15 CET 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35874

_coding style issues_


WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#399: FILE: test/bpf/mbuf.h:338:
+ * mbuf */

ERROR:CODE_INDENT: code indent should use tabs where possible
#406: FILE: test/bpf/mbuf.h:345:
+                               * with a single assignment */$

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#406: FILE: test/bpf/mbuf.h:345:
+                               * with a single assignment */

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#406: FILE: test/bpf/mbuf.h:345:
+typedef uint64_t MARKER64[0]; /**< marker that allows us to overwrite 8 bytes
+                               * with a single assignment */

ERROR:CODE_INDENT: code indent should use tabs where possible
#409: FILE: test/bpf/mbuf.h:348:
+        volatile int16_t cnt; /**< An internal counter value. */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#409: FILE: test/bpf/mbuf.h:348:
+        volatile int16_t cnt; /**< An internal counter value. */$

WARNING:FUNCTION_ARGUMENTS: function definition argument 'phys_addr_t' should also have an identifier name
#425: FILE: test/bpf/mbuf.h:364:
+	phys_addr_t buf_physaddr __rte_aligned(sizeof(phys_addr_t));

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#495: FILE: test/bpf/mbuf.h:434:
+			/**< First 4 flexible bytes or FD ID, dependent on
+			     PKT_RX_FDIR_* flag in ol_flags. */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#495: FILE: test/bpf/mbuf.h:434:
+			     PKT_RX_FDIR_* flag in ol_flags. */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#549: FILE: test/bpf/mbuf.h:488:
+	 * mbuf, it stores the direct mbuf private data size. */

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#738: FILE: test/bpf/t3.c:20:
+extern void rte_pktmbuf_dump(FILE *f, const struct rte_mbuf *m,
                                   ^

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#739: FILE: test/bpf/t3.c:21:
+	unsigned dump_len);

total: 3 errors, 9 warnings, 695 lines checked


More information about the test-report mailing list