[dpdk-test-report] |WARNING| pw36460 [PATCH 1/1] testpmd: add parameters buffersize-before-send and flush-timeout

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Mar 23 16:36:22 CET 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/36460

_coding style issues_


ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#64: FILE: app/test-pmd/fifo.c:7:
+struct rte_ring * fifo_init(uint32_t qi)

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#142: FILE: app/test-pmd/iofwd.c:113:
+	if (ncf->prev_time == 0) {
[...]
+	} else {
[...]

ERROR:SPACING: space required before the open parenthesis '('
#153: FILE: app/test-pmd/iofwd.c:124:
+			if(rte_ring_empty(ncf->f))

ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#228: FILE: app/test-pmd/testpmd.c:259:
+uint16_t bsize_before_send = 0;

ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#233: FILE: app/test-pmd/testpmd.c:264:
+uint16_t flush_timer = 0;

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#246: FILE: app/test-pmd/testpmd.c:422:
+struct rte_ring * fifo_init(uint32_t qi, uint32_t pi)

ERROR:SPACING: exactly one space required after that #ifdef
#294: FILE: app/test-pmd/testpmd.c:1803:
+#ifdef  RTE_TEST_PMD_NOISY

total: 6 errors, 1 warnings, 268 lines checked


More information about the test-report mailing list